Re: [PATCH 1/2] drm/i915: call intel_tile_height with correct parameter

[Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>]

On 05/09/2015 04:22 AM, Chandra Konduru wrote:
> In skylake update plane functions, intel_tile_height() is called with
> bits_per_pixel instead of pixel_format. Correcting it.
>
> Signed-off-by: Chandra Konduru <chandra.konduru@intel.com>
> ---
>   drivers/gpu/drm/i915/intel_display.c |    2 +-
>   drivers/gpu/drm/i915/intel_sprite.c  |    2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

This BTW fixes a bug in:

commit 3b7a5119b5d2def1161226a4c6a643db537dff7e
Author: Sonika Jindal <sonika.jindal@intel.com>
Date:   Fri Apr 10 14:37:29 2015 +0530

     drm/i915/skl: Support for 90/270 rotation

I've also posted last week "drm/i915: Remove duplicated 
intel_tile_height declaration" which fixes one part of the fallout, but 
didn't notice this as well.

So I think both of these fixes can be merged early.

A bit intriguing is how passing in bits per pixel instead of pixel 
format and things still worked. Don't see at the moment how tile height 
could have been correct for 90/270 as exercised from kms_rotation_crc.

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx