From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH 37/42] drm/i915: swap state correctly in intel_atomic_commit Date: Tue, 12 May 2015 16:16:13 +0200 Message-ID: <55520B2D.2020407@linux.intel.com> References: <1431354318-11995-1-git-send-email-maarten.lankhorst@linux.intel.com> <1431354318-11995-38-git-send-email-maarten.lankhorst@linux.intel.com> <20150512130331.GU15256@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id A64C56E1C9 for ; Tue, 12 May 2015 07:16:15 -0700 (PDT) In-Reply-To: <20150512130331.GU15256@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: Ander Conselvan de Oliveira , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T3AgMTItMDUtMTUgb20gMTU6MDMgc2NocmVlZiBEYW5pZWwgVmV0dGVyOgo+IE9uIE1vbiwgTWF5 IDExLCAyMDE1IGF0IDA0OjI1OjEzUE0gKzAyMDAsIE1hYXJ0ZW4gTGFua2hvcnN0IHdyb3RlOgo+ PiBjcnRjLT5jb25maWcgaXMgZ29uZSwgc3dhcCBzd2FwIHN3YXAuIDpECj4+Cj4+IFNpZ25lZC1v ZmYtYnk6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5j b20+Cj4+IC0tLQo+PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYXRvbWljLmMgIHwgMzYg KystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4+ICBkcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9kaXNwbGF5LmMgfCAgNyArKysrKy0tCj4+ICAyIGZpbGVzIGNoYW5nZWQsIDcg aW5zZXJ0aW9ucygrKSwgMzYgZGVsZXRpb25zKC0pCj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9hdG9taWMuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2F0b21pYy5jCj4+IGluZGV4IGFjZTZhZWViMTM1OS4uMDMxNWRjNDRiMTdhIDEwMDY0NAo+PiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9hdG9taWMuYwo+PiArKysgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9hdG9taWMuYwo+PiBAQCAtMTMwLDcgKzEzMCw2IEBAIGludCBp bnRlbF9hdG9taWNfY29tbWl0KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4+ICAJCQlib29sIGFz eW5jKQo+PiAgewo+PiAgCWludCByZXQ7Cj4+IC0JaW50IGk7Cj4+ICAKPj4gIAlpZiAoYXN5bmMp IHsKPj4gIAkJRFJNX0RFQlVHX0tNUygiaTkxNSBkb2VzIG5vdCB5ZXQgc3VwcG9ydCBhc3luYyBj b21taXRcbiIpOwo+PiBAQCAtMTQyLDQ4ICsxNDEsMTcgQEAgaW50IGludGVsX2F0b21pY19jb21t aXQoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPj4gIAkJcmV0dXJuIHJldDsKPj4gIAo+PiAgCS8q IFBvaW50IG9mIG5vIHJldHVybiAqLwo+PiArCWRybV9hdG9taWNfaGVscGVyX3N3YXBfc3RhdGUo ZGV2LCBzdGF0ZSk7Cj4+ICAKPj4gIAkvKgo+PiAgCSAqIEZJWE1FOiAgVGhlIHByb3BlciBzZXF1 ZW5jZSBoZXJlIHdpbGwgZXZlbnR1YWxseSBiZToKPj4gIAkgKgo+PiAtCSAqIGRybV9hdG9taWNf aGVscGVyX3N3YXBfc3RhdGUoZGV2LCBzdGF0ZSkKPj4gIAkgKiBkcm1fYXRvbWljX2hlbHBlcl9j b21taXRfbW9kZXNldF9kaXNhYmxlcyhkZXYsIHN0YXRlKTsKPj4gIAkgKiBkcm1fYXRvbWljX2hl bHBlcl9jb21taXRfcGxhbmVzKGRldiwgc3RhdGUpOwo+PiAgCSAqIGRybV9hdG9taWNfaGVscGVy X2NvbW1pdF9tb2Rlc2V0X2VuYWJsZXMoZGV2LCBzdGF0ZSk7Cj4+IC0JICogZHJtX2F0b21pY19o ZWxwZXJfd2FpdF9mb3JfdmJsYW5rcyhkZXYsIHN0YXRlKTsKPj4gLQkgKiBkcm1fYXRvbWljX2hl bHBlcl9jbGVhbnVwX3BsYW5lcyhkZXYsIHN0YXRlKTsKPj4gLQkgKiBkcm1fYXRvbWljX3N0YXRl X2ZyZWUoc3RhdGUpOwo+PiAtCSAqCj4+IC0JICogb25jZSB3ZSBoYXZlIGZ1bGwgYXRvbWljIG1v ZGVzZXQuICBGb3Igbm93LCBqdXN0IG1hbnVhbGx5IHVwZGF0ZQo+PiAtCSAqIHBsYW5lIHN0YXRl cyB0byBhdm9pZCBjbG9iYmVyaW5nIGdvb2Qgc3RhdGVzIHdpdGggZHVtbXkgc3RhdGVzCj4+IC0J ICogd2hpbGUgbnVjbGVhciBwYWdlZmxpcHBpbmcuCj4+ICAJICovCj4+IC0JZm9yIChpID0gMDsg aSA8IGRldi0+bW9kZV9jb25maWcubnVtX3RvdGFsX3BsYW5lOyBpKyspIHsKPj4gLQkJc3RydWN0 IGRybV9wbGFuZSAqcGxhbmUgPSBzdGF0ZS0+cGxhbmVzW2ldOwo+PiAtCj4+IC0JCWlmICghcGxh bmUpCj4+IC0JCQljb250aW51ZTsKPj4gLQo+PiAtCQlwbGFuZS0+c3RhdGUtPnN0YXRlID0gc3Rh dGU7Cj4+IC0JCXN3YXAoc3RhdGUtPnBsYW5lX3N0YXRlc1tpXSwgcGxhbmUtPnN0YXRlKTsKPj4g LQkJcGxhbmUtPnN0YXRlLT5zdGF0ZSA9IE5VTEw7Cj4+IC0JfQo+PiAtCj4+IC0JLyogc3dhcCBj cnRjX3NjYWxlcl9zdGF0ZSAqLwo+PiAtCWZvciAoaSA9IDA7IGkgPCBkZXYtPm1vZGVfY29uZmln Lm51bV9jcnRjOyBpKyspIHsKPj4gLQkJc3RydWN0IGRybV9jcnRjICpjcnRjID0gc3RhdGUtPmNy dGNzW2ldOwo+PiAtCQlpZiAoIWNydGMpIHsKPj4gLQkJCWNvbnRpbnVlOwo+PiAtCQl9Cj4+IC0K Pj4gLQkJdG9faW50ZWxfY3J0Y19zdGF0ZShjcnRjLT5zdGF0ZSktPnNjYWxlcl9zdGF0ZSA9Cj4+ IC0JCQl0b19pbnRlbF9jcnRjX3N0YXRlKHN0YXRlLT5jcnRjX3N0YXRlc1tpXSktPnNjYWxlcl9z dGF0ZTsKPj4gLQo+PiAtCQlpZiAoSU5URUxfSU5GTyhkZXYpLT5nZW4gPj0gOSkKPj4gLQkJCXNr bF9kZXRhY2hfc2NhbGVycyh0b19pbnRlbF9jcnRjKGNydGMpKTsKPj4gLQl9Cj4+IC0KPj4gIAlk cm1fYXRvbWljX2hlbHBlcl9jb21taXRfcGxhbmVzKGRldiwgc3RhdGUpOwo+PiArCj4+ICAJZHJt X2F0b21pY19oZWxwZXJfd2FpdF9mb3JfdmJsYW5rcyhkZXYsIHN0YXRlKTsKPj4gIAlkcm1fYXRv bWljX2hlbHBlcl9jbGVhbnVwX3BsYW5lcyhkZXYsIHN0YXRlKTsKPj4gIAlkcm1fYXRvbWljX3N0 YXRlX2ZyZWUoc3RhdGUpOwo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4+IGlu ZGV4IDY1ZWUyY2QwNDM3Yy4uMTA1YmRmODRlNDZhIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZGlzcGxheS5jCj4+IEBAIC0xMzIwMiwxMSArMTMyMDIsMTQgQEAgc3RhdGljIHZvaWQg aW50ZWxfYmVnaW5fY3J0Y19jb21taXQoc3RydWN0IGRybV9jcnRjICpjcnRjKQo+PiAgCj4+ICAJ LyogUGVyZm9ybSB2YmxhbmsgZXZhc2lvbiBhcm91bmQgY29tbWl0IG9wZXJhdGlvbiAqLwo+PiAg CWlmIChpbnRlbF9jcnRjLT5hdG9taWMuZXZhZGUgJiYKPj4gLQkgICAgIWRldl9wcml2LT5wb3dl cl9kb21haW5zLmluaXRfcG93ZXJfb24pCj4+ICsJICAgICFkZXZfcHJpdi0+cG93ZXJfZG9tYWlu cy5pbml0X3Bvd2VyX29uKSB7Cj4+ICsJCWlmIChkZXZfcHJpdi0+aW5mby5nZW4gPj0gOSkKPj4g KwkJCXNrbF9kZXRhY2hfc2NhbGVycyh0b19pbnRlbF9jcnRjKGNydGMpKTsKPiBEb24ndCB3ZSBu ZWVkIHRvIHVwZGF0ZSBza2xfZGV0YWNoX3NjYWxlcnMgdG8gbG9vayBhdCB0aGUgb3RoZXIgY29u ZmlnCj4gbm93PyBPciBpcyB0aGlzIGFuIGlzc3VlIHdpdGggdGhlIHBhdGNoIHNwbGl0dGluZz8K Pgo+IEFsc28gd2h5IGlzIHRoaXMgcHJvdGVjdGVkIGJ5IGF0b21pYy5ldmFkZT8KTW9zdGx5IHRv IG5vdCBydW4gaWYgYSBtb2Rlc2V0J3MgZG9uZSwgdGhhdCBhbHJlYWR5IGtpbGxzIHRoZSBzY2Fs ZXJzLgoKfk1hYXJ0ZW4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1n ZngK