public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: Mika Kuoppala <mika.kuoppala@intel.com>
Subject: Re: [PATCH] drm/i915: Use uninterruptible mutex_lock for userptr bo creation
Date: Fri, 15 May 2015 12:09:00 +0100	[thread overview]
Message-ID: <5555D3CC.5080303@linux.intel.com> (raw)
In-Reply-To: <1431686541-21292-1-git-send-email-chris@chris-wilson.co.uk>


Hi,

On 05/15/2015 11:42 AM, Chris Wilson wrote:
> Mika encountered one pathological scenario under X where acquiring all
> the mm locks (required to insert a mmu notifier) was very slow, so slow
> that by the time we tried to lock the struct_mutex with the usual call
> to i915_mutex_lock_interruptible(), X's signal timer had fired causing
> us to restart the ioctl (and so looped indefinitely).

Indefinite loop? Are you saying userptr creation endlessly fails to 
manages to finish in 10ms (or is it even 100ms, forgot what timer Xorg 
setups up)? The __mmu_notifier_register call?

> While I suspect this is the result of another bug (something leaking mm
> perhaps?) we can forgo the error checking and interuptible nature of the
> lock here so we only have to pay the expense once and get on with it.
> This does expose the userptr creation routine to a driver livelock
> though by not being interruptible.

How is this acceptable then if it can live-lock? How does that happen?

Regards,

Tvrtko



_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2015-05-15 11:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-15 10:42 [PATCH] drm/i915: Use uninterruptible mutex_lock for userptr bo creation Chris Wilson
2015-05-15 11:09 ` Tvrtko Ursulin [this message]
2015-05-18  8:30   ` Daniel Vetter
2015-05-18 13:18     ` Chris Wilson
2015-05-18 17:10     ` Damien Lespiau
2015-05-18 20:21       ` Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5555D3CC.5080303@linux.intel.com \
    --to=tvrtko.ursulin@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=mika.kuoppala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox