From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH v2 07/17] drm/i915: Use crtc_state->active instead of crtc_state->enable Date: Mon, 18 May 2015 18:35:59 +0200 Message-ID: <555A14EF.1060509@linux.intel.com> References: <1431548627-2527-1-git-send-email-maarten.lankhorst@linux.intel.com> <1431548627-2527-8-git-send-email-maarten.lankhorst@linux.intel.com> <20150518153047.GW15256@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id E88DC6E537 for ; Mon, 18 May 2015 09:36:07 -0700 (PDT) In-Reply-To: <20150518153047.GW15256@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T3AgMTgtMDUtMTUgb20gMTc6MzAgc2NocmVlZiBEYW5pZWwgVmV0dGVyOgo+IE9uIFdlZCwgTWF5 IDEzLCAyMDE1IGF0IDEwOjIzOjM3UE0gKzAyMDAsIE1hYXJ0ZW4gTGFua2hvcnN0IHdyb3RlOgo+ PiBjcnRjX3N0YXRlLT5lbmFibGUgbWVhbnMgYSBjcnRjIGlzIGNvbmZpZ3VyZWQsIGJ1dCBpdCBt YXkgYmUgdHVybmVkCj4+IG9mZiBmb3IgZHBtcy4gVW50aWwgdGhlIHByZXZpb3VzIGNvbW1pdCBj cnRjX3N0YXRlLT5hY3RpdmUgd2FzIG5vdAo+PiB1cGRhdGVkIG9uIGNydGMgb2ZmLCBidXQgbm93 IHRoYXQgd2UgZG8gd2Ugc2hvdWxkIHVzZSB0aGF0IGZvciB0cmFja2luZwo+PiB3aGV0aGVyIGEg Y3J0YyBpcyBzY2FubmluZyBvdXQgb3Igbm90Lgo+Pgo+PiBBdCB0aGlzIHBvaW50IGNydGMtPmFj dGl2ZSBzaG91bGQgbWlycm9yIGNydGNfc3RhdGUtPmFjdGl2ZSwKPj4gc28gc29tZSBwYXJhbm9p YSBmcm9tIHRoZSBjcnRjX2Rpc2FibGUgZnVuY3Rpb25zIGNhbiBiZSByZW1vdmVkLgo+Pgo+PiBO b3RlIHRoYXQgaW50ZWxfc2V0X21vZGVfc2V0dXBfcGxscyBzdGlsbCBjaGVja3MgZm9yIC0+ZW5h YmxlLAo+PiBiZWNhdXNlIGFsbCByZXNvdXJjZXMgdGhhdCBhcmUgbmVlZGVkIGhhdmUgdG8gYmUg Y2FsY3VsYXRlZCwgc28KPj4gZHBtcyBjaGFuZ2VzIHdpbGwgc3RpbGwgc3VjY2VlZC4KPj4KPj4g U2lnbmVkLW9mZi1ieTogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4 LmludGVsLmNvbT4KPiBBIGZldyBkZXRhaWwgY29tbWVudHMgYmVsb3cuCj4gLURhbmllbAo+Cj4+ IC0tLQo+PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYyAgICAgIHwgIDIgKy0KPj4g IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8IDQ0ICsrKysrKysrKysrKysr KysrKy0tLS0tLS0tLS0tLS0tLS0tLQo+PiAgMiBmaWxlcyBjaGFuZ2VkLCAyMyBpbnNlcnRpb25z KCspLCAyMyBkZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfaXJxLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jCj4+IGluZGV4 IDU1N2FmODg3N2EyZS4uY2E0NTczMTdhOGFjIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2lycS5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfaXJx LmMKPj4gQEAgLTc5Niw3ICs3OTYsNyBAQCBzdGF0aWMgaW50IGk5MTVfZ2V0X3ZibGFua190aW1l c3RhbXAoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgaW50IHBpcGUsCj4+ICAJCXJldHVybiAtRUlO VkFMOwo+PiAgCX0KPj4gIAo+PiAtCWlmICghY3J0Yy0+c3RhdGUtPmVuYWJsZSkgewo+PiArCWlm ICghY3J0Yy0+c3RhdGUtPmFjdGl2ZSkgewo+IFRoaXMgY2hhbmdlIGxvb2tzIHVuanVzdGlmaWVk IEkgdGhpbmsuCldoeT8gQ2FuIHlvdSBnZXQgYSB2Ymxhbmsgb24gY3J0YyB0aGF0IGlzIGRwbXMg b2ZmPyBJIHRoaW5rIG5vdC4uCgpFaXRoZXIgd2F5IGxhdGVyIG9uIEkgdXNlIGh3bW9kZS0+Y3J0 Y19jbG9jayB3aGljaCByZW5kZXJzIHRoaXMgbW9vdC4KPj4gPHNuaXA+Cj4+IEBAIC01NzQyLDcg KzU3MzgsNyBAQCBzdGF0aWMgaW50IHZhbGxleXZpZXdfbW9kZXNldF9nbG9iYWxfcGlwZXMoc3Ry dWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlKQo+PiAgCj4+ICAJLyogYWRkIGFsbCBhY3RpdmUg cGlwZXMgdG8gdGhlIHN0YXRlICovCj4+ICAJZm9yX2VhY2hfY3J0YyhzdGF0ZS0+ZGV2LCBjcnRj KSB7Cj4+IC0JCWlmICghY3J0Yy0+c3RhdGUtPmVuYWJsZSkKPj4gKwkJaWYgKCFjcnRjLT5zdGF0 ZS0+YWN0aXZlKQo+IFRoaXMgaXMgYSBmdW5jdGlvbmFsIGNoYW5nZSB0byB0aGUgY2RjbGsgY29k ZSBhbmQgbWlnaHQgYnJlYWsgaXQgYW5kL29yCj4gY29uZmxpY3Qgd2l0aCB0aGUgb25nb2luZyBj ZGNsayB3b3JrIGZyb20gVmlsbGUvTWlrYS4gRGVmaW5pdGVseSBuZWVkcyB0bwo+IGJlIHNwbGl0 IG91dC4KTm8gdGhpcyBmdW5jdGlvbiBqdXN0IHNldHMgbW9kZV9jaGFuZ2VkIG9uIGFsbCBhY3Rp dmUgY3J0YydzLgoKVGhpcyBpcyBkb25lIHRvIHR1cm4gdGhlbSBvZmYgd2hpbGUgY2hhbmdpbmcg dGhlIGNsb2NrLiBJbiBjYXNlIHRoZXkncmUgYWxyZWFkeSB0dXJuZWQgb2ZmIHlvdSBkb24ndCBo YXZlIHRvIHR1cm4gdGhlbSBvZmYuCgo+PiAgCQkJY29udGludWU7Cj4+ICAKPj4gIAkJY3J0Y19z dGF0ZSA9IGRybV9hdG9taWNfZ2V0X2NydGNfc3RhdGUoc3RhdGUsIGNydGMpOwo+PiBAQCAtNTc1 Miw3ICs1NzQ4LDcgQEAgc3RhdGljIGludCB2YWxsZXl2aWV3X21vZGVzZXRfZ2xvYmFsX3BpcGVz KHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSkKPj4gIAo+PiAgCS8qIGRpc2FibGUvZW5h YmxlIGFsbCBjdXJyZW50bHkgYWN0aXZlIHBpcGVzIHdoaWxlIHdlIGNoYW5nZSBjZGNsayAqLwo+ PiAgCWZvcl9lYWNoX2NydGNfaW5fc3RhdGUoc3RhdGUsIGNydGMsIGNydGNfc3RhdGUsIGkpCj4+ IC0JCWlmIChjcnRjX3N0YXRlLT5lbmFibGUpCj4+ICsJCWlmIChjcnRjX3N0YXRlLT5hY3RpdmUp Cj4+ICAJCQljcnRjX3N0YXRlLT5tb2RlX2NoYW5nZWQgPSB0cnVlOwo+IFNhbWUgaGVyZS4KPgo+ IEhtLCBhc2lkZSBvZiBhbGwgdGhhdCBtYXliZSB3ZSBzaG91bGQgZHJvcCB2bHZfbW9kZXNldF9n bG9iYWxfcGlwZXMgYW5kCj4gaW5zdGVhZCBqdXN0IGxvb2sgYXQgY3J0Y19zdGF0ZS0+bW9kZV9j aGFuZ2VkPyBUaGF0IHdheSB3ZSBkb24ndCBuZWVkIHRvCj4gZHVwbGljYXRlIHRoZSBzYW1lIGNo ZWNrcyB0d2ljZSwgb25jZSB0byBzZXQgLT5tb2RlX2NoYW5nZWQgYW5kIG9uY2UgdG8KPiBmb3Ig dGhlIHByZXBhcmVfcGlwZXMgbWFzay4gT3IgaXMgdGhhdCBkdXBsaWNhdGlvbiBhbHJlYWR5IGdl dHRpbmcKPiByZW1vdmVkPwpJIHRoaW5rIHdlIGNvdWxkIGdldCByaWQgb2YgYSBsb3Qgb2YgdGhv c2UgZXh0cmEgbG9vcHMgaWYgd2Ugd2FudCB0byBsYXRlciwKYnV0IGZvciBub3cgcmVhZGFiaWxp dHkgaXMgbW9yZSBpbXBvcnRhbnQuCgp+TWFhcnRlbgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2ludGVsLWdmeAo=