Re: [PATCH v3 1/3] drm/i915: Expose I915_EXEC_RESOURCE_STREAMER flag

Daniel Vetter
2015-05-18T14:49:07Z

On Mon, May 18, 2015 at 01:52:12PM +0300, Abdiel Janulgue wrote:
>
>
> On 05/18/2015 12:01 PM, Daniel Vetter wrote:
> > On Mon, May 18, 2015 at 11:31:54AM +0300, Abdiel Janulgue wrote:
> >> Ensures that the batch buffer is executed by the resource streamer
> >>
> >> Signed-off-by: Abdiel Janulgue <abdiel.janulgue@linux.intel.com>
> >
> > Maybe I missed them, but we also need a patch to update gem_exec_params
> > from igt. At least the invalid-flag subtest should fail with this
> > applied. Also please add a Testcase: tag once you've added the testcase
> > for this new flag.
>
> I'm not sure what you mean here. When I run unmodified gem_exec_params
> with this resource streamer patches applied. I get this results, at
> least on the invalid-flag section:
>
> Subtest invalid-flag: SUCCESS (0.000s)
>
> Is this supposed to fail?

Yup, but because it wasn't updated for the bsd mask feature and
accidentally still passes there it still passes when you add yet another
flag.

Anyway that one needs to be updated to hopefully make sure we'll catch
bit17. And you need flag checks to make sure the new RS flag doesn't go
through on !RCS and pre-hsw.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation