Re: [PATCH 12/12] drm/i915: Disable FDI RX/TX before the ports

From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 12/12] drm/i915: Disable FDI RX/TX before the ports
Date: Thu, 21 May 2015 12:27:08 -0700	[thread overview]
Message-ID: <555E318C.4090900@virtuousgeek.org> (raw)
In-Reply-To: <1430835458-11187-13-git-send-email-ville.syrjala@linux.intel.com>

On 05/05/2015 07:17 AM, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Bspec says we should disable the FDI RX/TX before disabling the PCH
> ports. Do so.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
>  drivers/gpu/drm/i915/intel_display.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index a177f2e..fbcf26d 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -5096,13 +5096,14 @@ static void ironlake_crtc_disable(struct drm_crtc *crtc)
>  
>  	ironlake_pfit_disable(intel_crtc);
>  
> +	if (intel_crtc->config->has_pch_encoder)
> +		ironlake_fdi_disable(crtc);
> +
>  	for_each_encoder_on_crtc(dev, crtc, encoder)
>  		if (encoder->post_disable)
>  			encoder->post_disable(encoder);
>  
>  	if (intel_crtc->config->has_pch_encoder) {
> -		ironlake_fdi_disable(crtc);
> -
>  		ironlake_disable_pch_transcoder(dev_priv, pipe);
>  
>  		if (HAS_PCH_CPT(dev)) {
> 

Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx