From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Beckett Subject: Re: [PATCH 33/70] drm/i915: Use a separate slab for requests Date: Fri, 22 May 2015 15:48:59 +0100 Message-ID: <555F41DB.2010204@intel.com> References: <1428420094-18352-1-git-send-email-chris@chris-wilson.co.uk> <1428420094-18352-34-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 2BA286EAA7 for ; Fri, 22 May 2015 07:49:02 -0700 (PDT) In-Reply-To: <1428420094-18352-34-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMDcvMDQvMjAxNSAxNjoyMCwgQ2hyaXMgV2lsc29uIHdyb3RlOgo+IHJlcXVlc3RzIGFyZSBl dmVuIG1vcmUgZnJlcXVlbnRseSBhbGxvY2F0ZWQgdGhhbiBvYmplY3RzIGFuZCBlcXVhbGx5Cj4g YmVuZWZpdCBmcm9tIGhhdmluZyBhIGRlZGljYXRlZCBzbGFiLgo+Cj4gdjI6IFJlYmFzZQo+Cj4g U2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4g LS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RtYS5jICAgICAgICAgfCAxMiArKysr KystLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oICAgICAgICAgfCAgNCAr KystCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jICAgICAgICAgfCA0MSArKysr KysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX3JpbmdidWZmZXIuYyB8ICAxIC0KPiAgIDQgZmlsZXMgY2hhbmdlZCwgMzUgaW5zZXJ0aW9u cygrKSwgMjMgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9kbWEuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZG1hLmMKPiBpbmRleCA3 YjAxMDllMmFiMjMuLjEzNWZiY2FkMzY3ZiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X2RtYS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kbWEuYwo+ IEBAIC0xMDEwLDggKzEwMTAsMTAgQEAgb3V0X3JlZ3M6Cj4gICBwdXRfYnJpZGdlOgo+ICAgCXBj aV9kZXZfcHV0KGRldl9wcml2LT5icmlkZ2VfZGV2KTsKPiAgIGZyZWVfcHJpdjoKPiAtCWlmIChk ZXZfcHJpdi0+c2xhYikKPiAtCQlrbWVtX2NhY2hlX2Rlc3Ryb3koZGV2X3ByaXYtPnNsYWIpOwo+ ICsJaWYgKGRldl9wcml2LT5yZXF1ZXN0cykKPiArCQlrbWVtX2NhY2hlX2Rlc3Ryb3koZGV2X3By aXYtPnJlcXVlc3RzKTsKPiArCWlmIChkZXZfcHJpdi0+b2JqZWN0cykKPiArCQlrbWVtX2NhY2hl X2Rlc3Ryb3koZGV2X3ByaXYtPm9iamVjdHMpOwo+ICAgCWtmcmVlKGRldl9wcml2KTsKPiAgIAly ZXR1cm4gcmV0Owo+ICAgfQo+IEBAIC0xMDk0LDggKzEwOTYsMTAgQEAgaW50IGk5MTVfZHJpdmVy X3VubG9hZChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ICAgCWlmIChkZXZfcHJpdi0+cmVncyAh PSBOVUxMKQo+ICAgCQlwY2lfaW91bm1hcChkZXYtPnBkZXYsIGRldl9wcml2LT5yZWdzKTsKPgo+ IC0JaWYgKGRldl9wcml2LT5zbGFiKQo+IC0JCWttZW1fY2FjaGVfZGVzdHJveShkZXZfcHJpdi0+ c2xhYik7Cj4gKwlpZiAoZGV2X3ByaXYtPnJlcXVlc3RzKQo+ICsJCWttZW1fY2FjaGVfZGVzdHJv eShkZXZfcHJpdi0+cmVxdWVzdHMpOwo+ICsJaWYgKGRldl9wcml2LT5vYmplY3RzKQo+ICsJCWtt ZW1fY2FjaGVfZGVzdHJveShkZXZfcHJpdi0+b2JqZWN0cyk7Cj4KPiAgIAlwY2lfZGV2X3B1dChk ZXZfcHJpdi0+YnJpZGdlX2Rldik7Cj4gICAJa2ZyZWUoZGV2X3ByaXYpOwo+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9kcnYuaAo+IGluZGV4IDYwMGI2ZDRhMDEzOS4uYWQwOGFhNTMyNDU2IDEwMDY0NAo+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiArKysgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2Rydi5oCj4gQEAgLTE1NzgsNyArMTU3OCw4IEBAIHN0cnVjdCBpOTE1X3Zp cnR1YWxfZ3B1IHsKPgo+ICAgc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgewo+ICAgCXN0cnVjdCBk cm1fZGV2aWNlICpkZXY7Cj4gLQlzdHJ1Y3Qga21lbV9jYWNoZSAqc2xhYjsKPiArCXN0cnVjdCBr bWVtX2NhY2hlICpvYmplY3RzOwo+ICsJc3RydWN0IGttZW1fY2FjaGUgKnJlcXVlc3RzOwo+Cj4g ICAJY29uc3Qgc3RydWN0IGludGVsX2RldmljZV9pbmZvIGluZm87Cj4KPiBAQCAtMjA3MCw2ICsy MDcxLDcgQEAgc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0IHsKPiAgIAlzdHJ1Y3Qga3JlZiBy ZWY7Cj4KPiAgIAkvKiogT24gV2hpY2ggcmluZyB0aGlzIHJlcXVlc3Qgd2FzIGdlbmVyYXRlZCAq Lwo+ICsJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTU7Cj4gICAJc3RydWN0IGludGVsX2Vu Z2luZV9jcyAqcmluZzsKPgo+ICAgCS8qKiBHRU0gc2VxdWVuY2UgbnVtYmVyIGFzc29jaWF0ZWQg d2l0aCB0aGlzIHJlcXVlc3QuICovCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfZ2VtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gaW5kZXggMWYw N2NkMTdiZTA0Li5hNGE2MjU5MmYwZjggMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9nZW0uYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPiBA QCAtMzgxLDEzICszODEsMTMgQEAgb3V0Ogo+ICAgdm9pZCAqaTkxNV9nZW1fb2JqZWN0X2FsbG9j KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gICB7Cj4gICAJc3RydWN0IGRybV9pOTE1X3ByaXZh dGUgKmRldl9wcml2ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPiAtCXJldHVybiBrbWVtX2NhY2hlX3ph bGxvYyhkZXZfcHJpdi0+c2xhYiwgR0ZQX0tFUk5FTCk7Cj4gKwlyZXR1cm4ga21lbV9jYWNoZV96 YWxsb2MoZGV2X3ByaXYtPm9iamVjdHMsIEdGUF9LRVJORUwpOwo+ICAgfQo+Cj4gICB2b2lkIGk5 MTVfZ2VtX29iamVjdF9mcmVlKHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmopCj4gICB7 Cj4gICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gb2JqLT5iYXNlLmRldi0+ ZGV2X3ByaXZhdGU7Cj4gLQlrbWVtX2NhY2hlX2ZyZWUoZGV2X3ByaXYtPnNsYWIsIG9iaik7Cj4g KwlrbWVtX2NhY2hlX2ZyZWUoZGV2X3ByaXYtPm9iamVjdHMsIG9iaik7Cj4gICB9Cj4KPiAgIHN0 YXRpYyBpbnQKPiBAQCAtMjYzMyw0MyArMjYzMyw0NSBAQCB2b2lkIGk5MTVfZ2VtX3JlcXVlc3Rf ZnJlZShzdHJ1Y3Qga3JlZiAqcmVxX3JlZikKPiAgIAkJaTkxNV9nZW1fY29udGV4dF91bnJlZmVy ZW5jZShjdHgpOwo+ICAgCX0KPgo+IC0Ja2ZyZWUocmVxKTsKPiArCWttZW1fY2FjaGVfZnJlZShy ZXEtPmk5MTUtPnJlcXVlc3RzLCByZXEpOwo+ICAgfQo+Cj4gICBpbnQgaTkxNV9nZW1fcmVxdWVz dF9hbGxvYyhzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICpyaW5nLAo+ICAgCQkJICAgc3RydWN0IGlu dGVsX2NvbnRleHQgKmN0eCkKPiAgIHsKPiArCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZf cHJpdiA9IHRvX2k5MTUocmluZy0+ZGV2KTsKPiArCXN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVz dCAqcnE7Cj4gICAJaW50IHJldDsKPiAtCXN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVx dWVzdDsKPiAtCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdmF0ZSA9IHJpbmctPmRl di0+ZGV2X3ByaXZhdGU7Cj4KPiAgIAlpZiAocmluZy0+b3V0c3RhbmRpbmdfbGF6eV9yZXF1ZXN0 KQo+ICAgCQlyZXR1cm4gMDsKPgo+IC0JcmVxdWVzdCA9IGt6YWxsb2Moc2l6ZW9mKCpyZXF1ZXN0 KSwgR0ZQX0tFUk5FTCk7Cj4gLQlpZiAocmVxdWVzdCA9PSBOVUxMKQo+ICsJcnEgPSBrbWVtX2Nh Y2hlX3phbGxvYyhkZXZfcHJpdi0+cmVxdWVzdHMsIEdGUF9LRVJORUwpOwo+ICsJaWYgKHJxID09 IE5VTEwpCj4gICAJCXJldHVybiAtRU5PTUVNOwo+Cj4gLQlyZXQgPSBpOTE1X2dlbV9nZXRfc2Vx bm8ocmluZy0+ZGV2LCAmcmVxdWVzdC0+c2Vxbm8pOwo+ICsJa3JlZl9pbml0KCZycS0+cmVmKTsK PiArCXJxLT5pOTE1ID0gZGV2X3ByaXY7Cj4gKwo+ICsJcmV0ID0gaTkxNV9nZW1fZ2V0X3NlcW5v KHJpbmctPmRldiwgJnJxLT5zZXFubyk7Cj4gICAJaWYgKHJldCkgewo+IC0JCWtmcmVlKHJlcXVl c3QpOwo+ICsJCWtmcmVlKHJxKTsKPiAgIAkJcmV0dXJuIHJldDsKPiAgIAl9Cj4KPiAtCWtyZWZf aW5pdCgmcmVxdWVzdC0+cmVmKTsKPiAtCXJlcXVlc3QtPnJpbmcgPSByaW5nOwo+IC0JcmVxdWVz dC0+dW5pcSA9IGRldl9wcml2YXRlLT5yZXF1ZXN0X3VuaXErKzsKPiArCXJxLT5yaW5nID0gcmlu ZzsKPiArCXJxLT51bmlxID0gZGV2X3ByaXYtPnJlcXVlc3RfdW5pcSsrOwo+Cj4gICAJaWYgKGk5 MTUuZW5hYmxlX2V4ZWNsaXN0cykKPiAtCQlyZXQgPSBpbnRlbF9sb2dpY2FsX3JpbmdfYWxsb2Nf cmVxdWVzdF9leHRyYXMocmVxdWVzdCwgY3R4KTsKPiArCQlyZXQgPSBpbnRlbF9sb2dpY2FsX3Jp bmdfYWxsb2NfcmVxdWVzdF9leHRyYXMocnEsIGN0eCk7Cj4gICAJZWxzZQo+IC0JCXJldCA9IGlu dGVsX3JpbmdfYWxsb2NfcmVxdWVzdF9leHRyYXMocmVxdWVzdCk7Cj4gKwkJcmV0ID0gaW50ZWxf cmluZ19hbGxvY19yZXF1ZXN0X2V4dHJhcyhycSk7Cj4gICAJaWYgKHJldCkgewo+IC0JCWtmcmVl KHJlcXVlc3QpOwo+ICsJCWtmcmVlKHJxKTsKPiAgIAkJcmV0dXJuIHJldDsKPiAgIAl9Cj4KPiAt CXJpbmctPm91dHN0YW5kaW5nX2xhenlfcmVxdWVzdCA9IHJlcXVlc3Q7Cj4gKwlyaW5nLT5vdXRz dGFuZGluZ19sYXp5X3JlcXVlc3QgPSBycTsKPiAgIAlyZXR1cm4gMDsKPiAgIH0KPgo+IEBAIC01 MjA0LDExICs1MjA2LDE2IEBAIGk5MTVfZ2VtX2xvYWQoc3RydWN0IGRybV9kZXZpY2UgKmRldikK PiAgIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBkZXYtPmRldl9wcml2YXRl Owo+ICAgCWludCBpOwo+Cj4gLQlkZXZfcHJpdi0+c2xhYiA9Cj4gKwlkZXZfcHJpdi0+b2JqZWN0 cyA9Cj4gICAJCWttZW1fY2FjaGVfY3JlYXRlKCJpOTE1X2dlbV9vYmplY3QiLAo+ICAgCQkJCSAg c2l6ZW9mKHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0KSwgMCwKPiAgIAkJCQkgIFNMQUJfSFdD QUNIRV9BTElHTiwKPiAgIAkJCQkgIE5VTEwpOwo+ICsJZGV2X3ByaXYtPnJlcXVlc3RzID0KPiAr CQlrbWVtX2NhY2hlX2NyZWF0ZSgiaTkxNV9nZW1fcmVxdWVzdCIsCj4gKwkJCQkgIHNpemVvZihz dHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QpLCAwLAo+ICsJCQkJICBTTEFCX0hXQ0FDSEVfQUxJ R04sCj4gKwkJCQkgIE5VTEwpOwo+Cj4gICAJSU5JVF9MSVNUX0hFQUQoJmRldl9wcml2LT52bV9s aXN0KTsKPiAgIAlpOTE1X2luaXRfdm0oZGV2X3ByaXYsICZkZXZfcHJpdi0+Z3R0LmJhc2UpOwo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmMgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmMKPiBpbmRleCA5OWExZmRmZjQ5 MjQuLmJmNzgzN2QzMDM4OCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9yaW5nYnVmZmVyLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVm ZmVyLmMKPiBAQCAtMjE2Miw3ICsyMTYyLDYgQEAgaW50IGludGVsX3JpbmdfaWRsZShzdHJ1Y3Qg aW50ZWxfZW5naW5lX2NzICpyaW5nKQo+ICAgaW50IGludGVsX3JpbmdfYWxsb2NfcmVxdWVzdF9l eHRyYXMoc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpyZXF1ZXN0KQo+ICAgewo+ICAgCXJl cXVlc3QtPnJpbmdidWYgPSByZXF1ZXN0LT5yaW5nLT5idWZmZXI7Cj4gLQo+ICAgCXJldHVybiAw Owo+ICAgfQo+Cj4KCllvdSBtaXNzZWQgYSByZXF1ZXN0IGFsbG9jYXRpb24gaW4gZXhlY2xpc3Rz X2NvbnRleHRfcXVldWUgaW4gCmludGVsX2xyYy5jIHdoZW4gIXJlcXVlc3QuIEJ5IHRoZSBsb29r IG9mIGl0IHRoYXQgY29kZSBjb3VsZCBiZSBjaGFuZ2VkIAp0byB1c2UgaTkxNV9nZW1fcmVxdWVz dF9hbGxvYywgdW5sZXNzIHRoZXJlIGlzIGFueSByZWFzb24gbm90IHRvIHNldCB0aGUgCm91dHN0 YW5kaW5nX2xhenlfcmVxdWVzdCB0byB0aGUgZHVtbXkgcmVxdWVzdC4KCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QK SW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==