From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH v3 14/22] drm/i915: Move cdclk and pll setup to intel_modeset_compute_config() Date: Mon, 01 Jun 2015 08:31:57 +0200 Message-ID: <556BFC5D.7000300@linux.intel.com> References: <1432129094-11765-1-git-send-email-maarten.lankhorst@linux.intel.com> <1432137874-20543-1-git-send-email-maarten.lankhorst@linux.intel.com> <1432137874-20543-5-git-send-email-maarten.lankhorst@linux.intel.com> <20150529005522.GB15716@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 254E66E172 for ; Sun, 31 May 2015 23:32:00 -0700 (PDT) In-Reply-To: <20150529005522.GB15716@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Matt Roper Cc: Ander Conselvan de Oliveira , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T3AgMjktMDUtMTUgb20gMDI6NTUgc2NocmVlZiBNYXR0IFJvcGVyOgo+IE9uIFdlZCwgTWF5IDIw LCAyMDE1IGF0IDA2OjA0OjI2UE0gKzAyMDAsIG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVs LmNvbSB3cm90ZToKPj4gRnJvbTogQW5kZXIgQ29uc2VsdmFuIGRlIE9saXZlaXJhIDxhbmRlci5j b25zZWx2YW4uZGUub2xpdmVpcmFAaW50ZWwuY29tPgo+Pgo+PiBJdCBtYWtlcyBtb3JlIHNlbnNl IHRoZXJlLCBzaW5jZSB0aGVzZSBhcmUgY29tcHV0YXRpb24gc3RlcHMgdGhhdCBjYW4KPj4gZmFp bC4KPj4KPj4gU2lnbmVkLW9mZi1ieTogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hv cnN0QGxpbnV4LmludGVsLmNvbT4KPiBJJ3ZlIG5vdGljZWQgdGhhdCBhIGZldyBvZiB0aGUgcGF0 Y2hlcyBpbiB0aGlzIHNlcmllcyB3ZXJlIG9yaWdpbmFsbHkKPiB3cml0dGVuIGJ5IEFuZGVyLCBi dXQgc2VlbSB0byBiZSBtaXNzaW5nIGhpcyBzLW8tYiBsaW5lLiAgSSB0aGluayB5b3UKPiBnZW5l cmFsbHkgd2FudCB0byBqdXN0IGFwcGVuZCB5b3VyIGxpbmUgYWZ0ZXIgaGlzIGluIHRoYXQgY2Fz ZS4KPgo+IE9uZSBvdGhlciBjb3NtZXRpYyBub3RlIGZhcnRoZXIgZG93bi4KPgo+PiAtLS0KPj4g IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8IDcwICsrKysrKysrKysrKysr KysrKy0tLS0tLS0tLS0tLS0tLS0tLQo+PiAgMSBmaWxlIGNoYW5nZWQsIDM1IGluc2VydGlvbnMo KyksIDM1IGRlbGV0aW9ucygtKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5j Cj4+IGluZGV4IDgxZDUzNThlZmRkZS4uZTdhYTg2MTBjYmRjIDEwMDY0NAo+PiAtLS0gYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZGlzcGxheS5jCj4+IEBAIC0xMjA4NSwzNyArMTIwODUsNiBAQCBzdGF0aWMg dm9pZCB1cGRhdGVfc2NhbmxpbmVfb2Zmc2V0KHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjKQo+PiAg CQljcnRjLT5zY2FubGluZV9vZmZzZXQgPSAxOwo+PiAgfQo+PiAgCj4+IC1zdGF0aWMgaW50Cj4+ IC1pbnRlbF9tb2Rlc2V0X2NvbXB1dGVfY29uZmlnKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpz dGF0ZSkKPj4gLXsKPj4gLQlzdHJ1Y3QgZHJtX2NydGMgKmNydGM7Cj4+IC0Jc3RydWN0IGRybV9j cnRjX3N0YXRlICpjcnRjX3N0YXRlOwo+PiAtCWludCByZXQsIGk7Cj4+IC0KPj4gLQlyZXQgPSBk cm1fYXRvbWljX2hlbHBlcl9jaGVja19tb2Rlc2V0KHN0YXRlLT5kZXYsIHN0YXRlKTsKPj4gLQlp ZiAocmV0KQo+PiAtCQlyZXR1cm4gcmV0Owo+PiAtCj4+IC0JZm9yX2VhY2hfY3J0Y19pbl9zdGF0 ZShzdGF0ZSwgY3J0YywgY3J0Y19zdGF0ZSwgaSkgewo+PiAtCQlpZiAoIWNydGNfc3RhdGUtPmVu YWJsZSAmJgo+PiAtCQkgICAgV0FSTl9PTihjcnRjX3N0YXRlLT5hY3RpdmUpKQo+PiAtCQkJY3J0 Y19zdGF0ZS0+YWN0aXZlID0gZmFsc2U7Cj4+IC0KPj4gLQkJaWYgKCFjcnRjX3N0YXRlLT5lbmFi bGUpCj4+IC0JCQljb250aW51ZTsKPj4gLQo+PiAtCQlyZXQgPSBpbnRlbF9tb2Rlc2V0X3BpcGVf Y29uZmlnKGNydGMsIHN0YXRlKTsKPj4gLQkJaWYgKHJldCkKPj4gLQkJCXJldHVybiByZXQ7Cj4+ IC0KPj4gLQkJaW50ZWxfZHVtcF9waXBlX2NvbmZpZyh0b19pbnRlbF9jcnRjKGNydGMpLAo+PiAt CQkJCSAgICAgICB0b19pbnRlbF9jcnRjX3N0YXRlKGNydGNfc3RhdGUpLAo+PiAtCQkJCSAgICAg ICAiW21vZGVzZXRdIik7Cj4+IC0JfQo+PiAtCj4+IC0JcmV0dXJuIGRybV9hdG9taWNfaGVscGVy X2NoZWNrX3BsYW5lcyhzdGF0ZS0+ZGV2LCBzdGF0ZSk7Cj4+IC19Cj4+IC0KPj4gIHN0YXRpYyBp bnQgX19pbnRlbF9zZXRfbW9kZV9zZXR1cF9wbGxzKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpz dGF0ZSkKPj4gIHsKPj4gIAlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gc3RhdGUtPmRldjsKPj4g QEAgLTEyMTkxLDYgKzEyMTYwLDQxIEBAIHN0YXRpYyBpbnQgX19pbnRlbF9zZXRfbW9kZV9jaGVj a3Moc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlKQo+PiAgCXJldHVybiAwOwo+PiAgfQo+ PiAgCj4+ICtzdGF0aWMgaW50Cj4+ICtpbnRlbF9tb2Rlc2V0X2NvbXB1dGVfY29uZmlnKHN0cnVj dCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSkKPj4gK3sKPj4gKwlzdHJ1Y3QgZHJtX2NydGMgKmNy dGM7Cj4+ICsJc3RydWN0IGRybV9jcnRjX3N0YXRlICpjcnRjX3N0YXRlOwo+PiArCWludCByZXQs IGk7Cj4+ICsKPj4gKwlyZXQgPSBkcm1fYXRvbWljX2hlbHBlcl9jaGVja19tb2Rlc2V0KHN0YXRl LT5kZXYsIHN0YXRlKTsKPj4gKwlpZiAocmV0KQo+PiArCQlyZXR1cm4gcmV0Owo+PiArCj4+ICsJ Zm9yX2VhY2hfY3J0Y19pbl9zdGF0ZShzdGF0ZSwgY3J0YywgY3J0Y19zdGF0ZSwgaSkgewo+PiAr CQlpZiAoIWNydGNfc3RhdGUtPmVuYWJsZSAmJgo+PiArCQkgICAgV0FSTl9PTihjcnRjX3N0YXRl LT5hY3RpdmUpKQo+PiArCQkJY3J0Y19zdGF0ZS0+YWN0aXZlID0gZmFsc2U7Cj4+ICsKPj4gKwkJ aWYgKCFjcnRjX3N0YXRlLT5lbmFibGUpCj4+ICsJCQljb250aW51ZTsKPj4gKwo+PiArCQlyZXQg PSBpbnRlbF9tb2Rlc2V0X3BpcGVfY29uZmlnKGNydGMsIHN0YXRlKTsKPj4gKwkJaWYgKHJldCkK Pj4gKwkJCXJldHVybiByZXQ7Cj4+ICsKPj4gKwkJaW50ZWxfZHVtcF9waXBlX2NvbmZpZyh0b19p bnRlbF9jcnRjKGNydGMpLAo+PiArCQkJCSAgICAgICB0b19pbnRlbF9jcnRjX3N0YXRlKGNydGNf c3RhdGUpLAo+PiArCQkJCSAgICAgICAiW21vZGVzZXRdIik7Cj4+ICsJfQo+PiArCj4+ICsJcmV0 ID0gZHJtX2F0b21pY19oZWxwZXJfY2hlY2tfcGxhbmVzKHN0YXRlLT5kZXYsIHN0YXRlKTsKPj4g KwlpZiAocmV0KQo+PiArCQlyZXR1cm4gcmV0Owo+PiArCj4+ICsJcmV0dXJuIF9faW50ZWxfc2V0 X21vZGVfY2hlY2tzKHN0YXRlKTsKPiBKdXN0IGEgY29zbWV0aWMgbm90ZSwgYnV0IG1heWJlIHdl IHNob3VsZCByZW5hbWUgdGhpcyBmdW5jdGlvbiBub3c/Cj4gSXQncyBub3QgY2FsbGVkIGZyb20g X19pbnRlbF9zZXRfbW9kZSBhbnltb3JlIGFuZCBpdCBpc24ndCByZWFsbHkKPiAnY2hlY2tzJyAo YnV0IHJhdGhlciBzZXR1cCB0aGF0IHdlIGludGVuZCB0byBiZSBkb25lIGR1cmluZyB0aGUgY2hl Y2sKPiBwaGFzZSksIHNvIHRoZSB3aG9sZSBuYW1lIHNlZW1zIGEgYml0IG1pc2xlYWRpbmcgbm93 Lgo+CkxhdGVyIG9uIGludGVsX21vZGVzZXRfY29tcHV0ZV9jb25maWcgZ2V0cyByZW5hbWVkIHRv IGludGVsX2F0b21pY19jaGVjaywKYW5kIEkgY29uZGl0aW9uYWxseSBydW4gaW50ZWxfc2V0X21v ZGVfY2hlY2tzIGRlcGVuZGluZyBvbiB3aGV0aGVyIGEgbW9kZXNldAppcyByZXF1ZXN0ZWQgb3Ig bm90LiBJIGd1ZXNzIF9faW50ZWxfc2V0X21vZGVfY2hlY2tzIGNvdWxkIGJlIHJlbmFtZWQgdG8g aW50ZWxfbW9kZXNldF9jaGVja3MuCgp+TWFhcnRlbgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2ludGVsLWdmeAo=