From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH v3.6 16/22] drm/i915: Implement intel_crtc_control using atomic state, v4. Date: Mon, 01 Jun 2015 08:39:13 +0200 Message-ID: <556BFE11.60406@linux.intel.com> References: <1432129094-11765-1-git-send-email-maarten.lankhorst@linux.intel.com> <1432137874-20543-1-git-send-email-maarten.lankhorst@linux.intel.com> <1432137874-20543-7-git-send-email-maarten.lankhorst@linux.intel.com> <5564304A.8090808@linux.intel.com> <20150529005751.GE15716@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 56ADD6E58E for ; Sun, 31 May 2015 23:39:15 -0700 (PDT) In-Reply-To: <20150529005751.GE15716@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Matt Roper Cc: Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org T3AgMjktMDUtMTUgb20gMDI6NTcgc2NocmVlZiBNYXR0IFJvcGVyOgo+IE9uIFR1ZSwgTWF5IDI2 LCAyMDE1IGF0IDEwOjM1OjIyQU0gKzAyMDAsIE1hYXJ0ZW4gTGFua2hvcnN0IHdyb3RlOgo+PiBB c3N1bWUgdGhlIGNhbGxlcnMgbG9jayBldmVyeXRoaW5nIHdpdGggZHJtX21vZGVzZXRfbG9ja19h bGwuCj4+Cj4+IFRoaXMgY2hhbmdlIGhhZCB0byBiZSBkb25lIGFmdGVyIGNvbnZlcnRpbmcgc3Vz cGVuZC9yZXN1bWUgdG8KPj4gdXNlIGF0b21pY19zdGF0ZSBzbyB0aGUgYXRvbWljIHN0YXRlIGlz IHByZXNlcnZlZCwgb3RoZXJ3aXNlCj4+IGFsbCB0cmFuc2l0aW9uYWwgc3RhdGUgaXMgZXJhc2Vk Lgo+Pgo+PiBOb3cgYWxsIGNhbGxlcnMgb2YgLmNydGNfZW5hYmxlIGFuZCAuY3J0Y19kaXNhYmxl IGdvIHRocm91Z2gKPj4gYXRvbWljIG1vZGVzZXQhIDotRAo+Pgo+PiBDaGFuZ2VzIHNpbmNlIHYx Ogo+PiAtIE9ubHkgY2hlY2sgZm9yIGNydGNfc3RhdGUtPmFjdGl2ZSBpbiB2YWxsZXl2aWV3X21v ZGVzZXRfZ2xvYmFsX3BpcGVzLgo+PiAtIE9ubHkgY2hlY2sgZm9yIGNydGNfc3RhdGUtPmFjdGl2 ZSBpbiBtb2Rlc2V0X3VwZGF0ZV9jcnRjX3Bvd2VyX2RvbWFpbnMuCj4+IENoYW5nZXMgc2luY2Ug djI6Cj4+IC0gUmV3b3JrIG9uIHRvcCBvZiB0aGUgY2hhbmdlZCBwYXRjaCBvcmRlci4KPj4gQ2hh bmdlcyBzaW5jZSB2MzoKPj4gLSBSZW5hbWUgaW50ZWxfY3J0Y190b2dnbGUgaW4gZGVzY3JpcHRp b24gdG8gKl9jb250cm9sCj4+IC0gQ2hhbmdlIHJldHVybiB2YWx1ZSB0byBpbnQuCj4+IC0gRG8g bm90IGFkZCBwbGFuZSBzdGF0ZSwgc2hvdWxkIGJlIGRvbmUgaW1wbGljaXRseSBhbHJlYWR5Lgo+ Pgo+PiBTaWduZWQtb2ZmLWJ5OiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RA bGludXguaW50ZWwuY29tPgo+PiAtLS0KPj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rp c3BsYXkuYyB8IDUzICsrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLQo+PiAgZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmggICAgIHwgIDIgKy0KPj4gIDIgZmlsZXMgY2hh bmdlZCwgMzMgaW5zZXJ0aW9ucygrKSwgMjIgZGVsZXRpb25zKC0pCj4+Cj4+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9kaXNwbGF5LmMKPj4gaW5kZXggZTk2ODBlYjg1YmQwLi4zMmJhYjI4NDMyZjcg MTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+PiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPj4gQEAgLTU5NzMsMzgg KzU5NzMsNDkgQEAgdm9pZCBpbnRlbF9kaXNwbGF5X3N1c3BlbmQoc3RydWN0IGRybV9kZXZpY2Ug KmRldikKPj4gIH0KPj4gIAo+PiAgLyogTWFzdGVyIGZ1bmN0aW9uIHRvIGVuYWJsZS9kaXNhYmxl IENSVEMgYW5kIGNvcnJlc3BvbmRpbmcgcG93ZXIgd2VsbHMgKi8KPj4gLXZvaWQgaW50ZWxfY3J0 Y19jb250cm9sKHN0cnVjdCBkcm1fY3J0YyAqY3J0YywgYm9vbCBlbmFibGUpCj4+ICtpbnQgaW50 ZWxfY3J0Y19jb250cm9sKHN0cnVjdCBkcm1fY3J0YyAqY3J0YywgYm9vbCBlbmFibGUpCj4gV2Ug Y2hhbmdlIHRoZSByZXR1cm4gdmFsdWUgdG8gJ2ludCcgaGVyZSwgYnV0IHdlIG5ldmVyIGNoZWNr IHRoZSBlcnJvcgo+IGNvZGUgYW55d2hlcmUuICBNYXliZSB3ZSBzaG91bGQgaG9sZCB0aGlzIG9m ZiBmb3IgYW5vdGhlciBwYXRjaCBhbmQgdGhlbgo+IGFsc28gcHJvcGFnYXRlIHRoZSByZXR1cm4g dmFsdWUgYmFjayB1cCB0aGUgY2FsbCBjaGFpbj8gIEl0IHNlZW1zIGxpa2UKPiBhdCBsZWFzdCBz b21lIG9mIHRoZSBjb25uZWN0b3Itc3BlY2lmaWMgRFBNUyBmdW5jdGlvbnMgc2hvdWxkIHJlY29n bml6ZQo+IHRoZSBmYWlsdXJlIG9mIGludGVsX2NydGNfdXBkYXRlX2RwbXMoKSBiZWZvcmUgdHJ5 aW5nIHRvIGNvbnRpbnVlIHdpdGgKPiBvdGhlciBvcGVyYXRpb25zLgpZZWFoLCBidXQgSSB3YXNu J3Qgc3VyZSB3aGljaCBvbmVzLCBhbmQgaGFuZGxpbmcgaXMgYSBsb3QgaGFyZGVyLiBTbyBJIHdh bnRlZCB0bwptYXJrIHRoaXMgYXMgJ2ludCcgdG8gd2FybiBmdXR1cmUgdXNlcnMgdGhhdCB0aGlz IGZ1bmN0aW9uIG1heSBmYWlsIHNvIHRoZXkgY2FuIGNoZWNrLgo+PiAgewo+PiAgCXN0cnVjdCBk cm1fZGV2aWNlICpkZXYgPSBjcnRjLT5kZXY7Cj4+IC0Jc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg KmRldl9wcml2ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPj4gKwlzdHJ1Y3QgZHJtX21vZGVfY29uZmln ICpjb25maWcgPSAmZGV2LT5tb2RlX2NvbmZpZzsKPj4gKwlzdHJ1Y3QgZHJtX21vZGVzZXRfYWNx dWlyZV9jdHggKmN0eCA9IGNvbmZpZy0+YWNxdWlyZV9jdHg7Cj4+ICAJc3RydWN0IGludGVsX2Ny dGMgKmludGVsX2NydGMgPSB0b19pbnRlbF9jcnRjKGNydGMpOwo+PiAtCWVudW0gaW50ZWxfZGlz cGxheV9wb3dlcl9kb21haW4gZG9tYWluOwo+PiAtCXVuc2lnbmVkIGxvbmcgZG9tYWluczsKPj4g KwlzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqcGlwZV9jb25maWc7Cj4+ICsJc3RydWN0IGRybV9h dG9taWNfc3RhdGUgKnN0YXRlOwo+PiArCWludCByZXQ7Cj4+ICAKPj4gIAlpZiAoZW5hYmxlID09 IGludGVsX2NydGMtPmFjdGl2ZSkKPj4gLQkJcmV0dXJuOwo+PiArCQlyZXR1cm4gMDsKPj4gIAo+ PiAgCWlmIChlbmFibGUgJiYgIWNydGMtPnN0YXRlLT5lbmFibGUpCj4+IC0JCXJldHVybjsKPj4g KwkJcmV0dXJuIDA7Cj4+ICAKPj4gLQljcnRjLT5zdGF0ZS0+YWN0aXZlID0gZW5hYmxlOwo+PiAt CWlmIChlbmFibGUpIHsKPj4gLQkJZG9tYWlucyA9IGdldF9jcnRjX3Bvd2VyX2RvbWFpbnMoY3J0 Yyk7Cj4+IC0JCWZvcl9lYWNoX3Bvd2VyX2RvbWFpbihkb21haW4sIGRvbWFpbnMpCj4+IC0JCQlp bnRlbF9kaXNwbGF5X3Bvd2VyX2dldChkZXZfcHJpdiwgZG9tYWluKTsKPj4gLQkJaW50ZWxfY3J0 Yy0+ZW5hYmxlZF9wb3dlcl9kb21haW5zID0gZG9tYWluczsKPj4gKwkvKiB0aGlzIGZ1bmN0aW9u IHNob3VsZCBiZSBjYWxsZWQgd2l0aCBkcm1fbW9kZXNldF9sb2NrX2FsbCBmb3Igbm93ICovCj4+ ICsJaWYgKFdBUk5fT04oIWN0eCkpCj4+ICsJCXJldHVybiAtRUlPOwo+IEVJTyBzZWVtcyBsaWtl IGFuIHVudXN1YWwgY2hvaWNlIGhlcmUgKGJ1dCBJJ20gbm90IHJlYWxseSBzdXJlIHdoYXQgdGhl Cj4gYmVzdCBvcHRpb24gd291bGQgYmUpLgpObyBpZGVhLCBJIGp1c3Qgd2FudGVkIHRvIG1ha2Ug c3VyZSB0aGF0IGl0IHdhcyByZWNvZ25pemVkIGFzIHByb2dyYW1taW5nIGVycm9yLgotRUlOVkFM IElzIHVzZWQgZXZlcnl3aGVyZSBpbiB0aGUgYXRvbWljIHBhdGgsIC1FTk9ERVYgZGlkbid0IHNl ZW0gYXBwcm9wcmlhdGUuCj4+ICsJbG9ja2RlcF9hc3NlcnRfaGVsZCgmY3R4LT53d19jdHgpOwo+ PiAgCj4+IC0JCWRldl9wcml2LT5kaXNwbGF5LmNydGNfZW5hYmxlKGNydGMpOwo+PiAtCQlpbnRl bF9jcnRjX2VuYWJsZV9wbGFuZXMoY3J0Yyk7Cj4+IC0JfSBlbHNlIHsKPj4gLQkJaW50ZWxfY3J0 Y19kaXNhYmxlX3BsYW5lcyhjcnRjKTsKPj4gLQkJZGV2X3ByaXYtPmRpc3BsYXkuY3J0Y19kaXNh YmxlKGNydGMpOwo+PiArCXN0YXRlID0gZHJtX2F0b21pY19zdGF0ZV9hbGxvYyhkZXYpOwo+PiAr CWlmIChXQVJOX09OKCFzdGF0ZSkpCj4+ICsJCXJldHVybiAtRU5PTUVNOwo+PiAgCj4+IC0JCWRv bWFpbnMgPSBpbnRlbF9jcnRjLT5lbmFibGVkX3Bvd2VyX2RvbWFpbnM7Cj4+IC0JCWZvcl9lYWNo X3Bvd2VyX2RvbWFpbihkb21haW4sIGRvbWFpbnMpCj4+IC0JCQlpbnRlbF9kaXNwbGF5X3Bvd2Vy X3B1dChkZXZfcHJpdiwgZG9tYWluKTsKPj4gLQkJaW50ZWxfY3J0Yy0+ZW5hYmxlZF9wb3dlcl9k b21haW5zID0gMDsKPj4gKwlzdGF0ZS0+YWNxdWlyZV9jdHggPSBjdHg7Cj4+ICsJc3RhdGUtPmFs bG93X21vZGVzZXQgPSB0cnVlOwo+PiArCj4+ICsJcGlwZV9jb25maWcgPSBpbnRlbF9hdG9taWNf Z2V0X2NydGNfc3RhdGUoc3RhdGUsIGludGVsX2NydGMpOwo+PiArCWlmIChJU19FUlIocGlwZV9j b25maWcpKSB7Cj4+ICsJCXJldCA9IFBUUl9FUlIocGlwZV9jb25maWcpOwo+PiArCQlnb3RvIGVy cjsKPj4gIAl9Cj4+ICsJcGlwZV9jb25maWctPmJhc2UuYWN0aXZlID0gZW5hYmxlOwo+PiArCj4+ ICsJcmV0ID0gaW50ZWxfc2V0X21vZGUoc3RhdGUpOwo+PiArCWlmICghcmV0KQo+PiArCQlyZXR1 cm4gcmV0Owo+PiArCj4+ICtlcnI6Cj4+ICsJRFJNX0VSUk9SKCJVcGRhdGluZyBjcnRjIGFjdGl2 ZSBmYWlsZWQgd2l0aCAlaVxuIiwgcmV0KTsKPj4gKwlkcm1fYXRvbWljX3N0YXRlX2ZyZWUoc3Rh dGUpOwo+PiArCXJldHVybiByZXQ7Cj4+ICB9Cj4+ICAKPj4gIC8qKgo+PiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kcnYuaAo+PiBpbmRleCA2MGEyOWZmNjVmMWYuLmMxMTNmMTg3MDkwZiAxMDA2NDQKPj4g LS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPj4gQEAgLTk4OSw3ICs5ODksNyBAQCB2b2lkIGludGVs X21hcmtfYnVzeShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KTsKPj4gIHZvaWQgaW50ZWxfbWFya19p ZGxlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpOwo+PiAgdm9pZCBpbnRlbF9jcnRjX3Jlc3RvcmVf bW9kZShzdHJ1Y3QgZHJtX2NydGMgKmNydGMpOwo+PiAgdm9pZCBpbnRlbF9kaXNwbGF5X3N1c3Bl bmQoc3RydWN0IGRybV9kZXZpY2UgKmRldik7Cj4+IC12b2lkIGludGVsX2NydGNfY29udHJvbChz dHJ1Y3QgZHJtX2NydGMgKmNydGMsIGJvb2wgZW5hYmxlKTsKPj4gK2ludCBpbnRlbF9jcnRjX2Nv bnRyb2woc3RydWN0IGRybV9jcnRjICpjcnRjLCBib29sIGVuYWJsZSk7Cj4+ICB2b2lkIGludGVs X2NydGNfdXBkYXRlX2RwbXMoc3RydWN0IGRybV9jcnRjICpjcnRjKTsKPj4gIHZvaWQgaW50ZWxf ZW5jb2Rlcl9kZXN0cm95KHN0cnVjdCBkcm1fZW5jb2RlciAqZW5jb2Rlcik7Cj4+ICBpbnQgaW50 ZWxfY29ubmVjdG9yX2luaXQoc3RydWN0IGludGVsX2Nvbm5lY3RvciAqKTsKPj4gLS0gCj4+IDIu MS4wCj4+Cj4+Cj4+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCj4+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNr dG9wLm9yZwo+PiBodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v aW50ZWwtZ2Z4CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=