Re: [PATCH 00/24] Convert to atomic, part 3.

[Maarten Lankhorst <maarten.lankhorst@linux.intel.com>]

Op 01-06-15 om 15:27 schreef Maarten Lankhorst:
> This patch series requires the following prerequisites:
> "[PATCH v4 00/27] Convert to atomic, part 2"
> "[PATCH] drm/atomic: Clear crtc_state->active in drm_atomic_helper_set_config."
>
> Now that suspend/restore is atomic it's time to clean up some
> remaining issues. First I clean up the suspend code some more now
> that it's atomic.
>
> After that I try to make a better separation between checking and
> modeset. This meant that intel_modeset_pipe_config should no longer
> touch mode_changed, because it will only be called when a modeset
> will already happen to prevent excessive rechecking.
>
> I also clean up the scaler stuff slightly, and add a hack to allow
> switching a plane to/from hq mode without requiring it to be part
> of the state. This allows calling intel_atomic_update_scalers from
> the crtc_check function, although I guess in theory there wouldn't
> be much harm adding a plane. This part's open for debate, if people
> prefer a different approach I'd be fine with it. :-)
>
> After those changes drm_atomic_commit and intel_set_mode become very
> similar, but it's still too early to use intel_set_mode as a
> replacement.
>
> First planes have to be converted to atomic, which is done by
> splitting out the updates of intel_crtc->atomic to a helper.
> Most of the changes to intel_crtc->atomic will not be done during a
> modeset, because all state will be updated regardless.
>
> After this is split out converting planes to atomic in intel_set_mode
> is simply a matter of updating intel_crtc->atomic during modeset and
> calling the helpers we split out.
>
> Maarten Lankhorst (24):
>   drm/i915: Always reset in intel_crtc_restore_mode
>   drm/i915: Use crtc state in intel_modeset_pipe_config
>   drm/i915: clean up intel_sanitize_crtc
>   drm/i915: Update power domains only on affected crtc's.
>   drm/i915: add fastboot checks for has_audio and has_infoframe
>   drm/i915: Clean up intel_atomic_setup_scalers slightly.
>   drm/i915: Add a simple atomic crtc check function.
>   drm/i915: Do not add planes from intel_atomic_setup_scalers.
>   drm/i915: Assign a new pll from the crtc check function.
>   drm/i915: Do not run most checks when there's no modeset.
>   drm/i915: Split skl_update_scaler.
>   drm/i915: Split plane updates of crtc->atomic into a helper.
>   drm/i915: move detaching scalers to begin_crtc_commit
>   drm/i915: Move crtc commit updates to separate functions.

Note to reviewers: after I looked at how to clear cursor/sprites on initial modeset work I had to reorder some patches.

Can I get this series only reviewed for up to "[PATCH 14/24] drm/i915: Move crtc commit updates to separate functions." ?

Although I wouldn't mind a cursory glance at the other patches, see if the approach looks sane. :-)

~Maarten
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx