Re: [PATCH 03/21] drm/i915/gtt: Check va range against vm size

Michel Thierry
2015-06-24T14:49:00Z

On 6/11/2015 3:23 PM, Mika Kuoppala wrote:
> Joonas Lahtinen <joonas.lahtinen@linux.intel.com> writes:
>
>> On pe, 2015-05-22 at 20:04 +0300, Mika Kuoppala wrote:
>>> Check the allocation area against the known end
>>> of address space instead of against fixed value.
>>>
>>> v2: Return ENODEV on internal bugs (Chris)
>>>
>>> Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
>>> ---
>>> drivers/gpu/drm/i915/i915_gem_gtt.c | 18 +++++++++++-------
>>> 1 file changed, 11 insertions(+), 7 deletions(-)
>>>
>>
>> Why is it not enough just to change the WARN_ON test?
>>
>
> Might have be cleaner yes. I just wanted to keep the pde iteration
> loop using 32bit arithmetic like it used to.

Unless Joonas has any more comments,

Reviewed-by: Michel Thierry <michel.thierry@intel.com>

> -Mika
>
>>>
>>> bitmap_zero(new_page_tables, I915_PDES);
>>>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx