From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michel Thierry Subject: Re: [PATCH 11/21] drm/i915/gtt: Introduce fill_page_dma() Date: Tue, 02 Jun 2015 15:51:26 +0100 Message-ID: <556DC2EE.2020207@intel.com> References: <1432314314-23530-1-git-send-email-mika.kuoppala@intel.com> <1432314314-23530-12-git-send-email-mika.kuoppala@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id CB70B6E877 for ; Tue, 2 Jun 2015 07:51:29 -0700 (PDT) In-Reply-To: <1432314314-23530-12-git-send-email-mika.kuoppala@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Mika Kuoppala , "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org T24gNS8yMi8yMDE1IDY6MDUgUE0sIE1pa2EgS3VvcHBhbGEgd3JvdGU6Cj4gV2hlbiB3ZSBzZXR1 cCBwYWdlIGRpcmVjdG9yaWVzIGFuZCB0YWJsZXMsIHdlIHBvaW50IHRoZSBlbnRyaWVzCj4gdG8g YSB0byB0aGUgbmV4dCBsZXZlbCBzY3JhdGNoIHN0cnVjdHVyZS4gTWFrZSB0aGlzIGdlbmVyaWMK PiBieSBpbnRyb2R1Y2luZyBhIGZpbGxfcGFnZV9kbWEgd2hpY2ggbWFwcyBhbmQgZmx1c2hlcy4g V2UgYWxzbwo+IG5lZWQgMzIgYml0IHZhcmlhbnQgZm9yIGxlZ2FjeSBnZW5zLgo+Cj4gdjI6IEZp eCBmbHVzaGVzIGFuZCBoYW5kbGUgdmFsbGV5dmlldyAoVmlsbGUpCj4KPiBTaWduZWQtb2ZmLWJ5 OiBNaWthIEt1b3BwYWxhIDxtaWthLmt1b3BwYWxhQGludGVsLmNvbT4KPiAtLS0KPiAgIGRyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2d0dC5jIHwgNzEgKysrKysrKysrKysrKysrKysrKy0t LS0tLS0tLS0tLS0tLS0tLQo+ICAgMSBmaWxlIGNoYW5nZWQsIDM3IGluc2VydGlvbnMoKyksIDM0 IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf Z2VtX2d0dC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZ3R0LmMKPiBpbmRleCBm NzQ3YmQzLi5kMDIwYjVlIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf Z2VtX2d0dC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZ3R0LmMKPiBA QCAtMzMwLDYgKzMzMCwzMSBAQCBzdGF0aWMgdm9pZCBjbGVhbnVwX3BhZ2VfZG1hKHN0cnVjdCBk cm1fZGV2aWNlICpkZXYsIHN0cnVjdCBpOTE1X3BhZ2VfZG1hICpwKQo+ICAgICAgICAgIG1lbXNl dChwLCAwLCBzaXplb2YoKnApKTsKPiAgIH0KPgo+ICtzdGF0aWMgdm9pZCBmaWxsX3BhZ2VfZG1h KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHN0cnVjdCBpOTE1X3BhZ2VfZG1hICpwLAo+ICsgICAg ICAgICAgICAgICAgICAgICAgICAgY29uc3QgdWludDY0X3QgdmFsKQo+ICt7Cj4gKyAgICAgICBp bnQgaTsKPiArICAgICAgIHVpbnQ2NF90ICogY29uc3QgdmFkZHIgPSBrbWFwX2F0b21pYyhwLT5w YWdlKTsKPiArCj4gKyAgICAgICBmb3IgKGkgPSAwOyBpIDwgNTEyOyBpKyspCj4gKyAgICAgICAg ICAgICAgIHZhZGRyW2ldID0gdmFsOwo+ICsKPiArICAgICAgIGlmICghSEFTX0xMQyhkZXYpICYm ICFJU19WQUxMRVlWSUVXKGRldikpCj4gKyAgICAgICAgICAgICAgIGRybV9jbGZsdXNoX3ZpcnRf cmFuZ2UodmFkZHIsIFBBR0VfU0laRSk7CgpDaGVycnl2aWV3IHJldHVybnMgdHJ1ZSB0byBJU19W QUxMRVlWSUVXKCkuCgpZb3UgY2FuIHVzZSghSEFTX0xMQyAmJiBJU19DSEVSUllWSUVXKSBpbnN0 ZWFkIHRvIGZsdXNoIGluIGNodiwgYnV0IG5vdCAKaW4gdmx2Li4uIEJ1dCB0byBtYWtlIGl0IGJ4 dC1wcm9vZiwgKCFIQVNfTExDICYmIElOVEVMX0lORk8oZGV2KS0+Z2VuID49IAo4KSBpcyBwcm9i YWJseSBiZXR0ZXIuCgo+ICsKPiArICAgICAgIGt1bm1hcF9hdG9taWModmFkZHIpOwo+ICt9Cj4g Kwo+ICtzdGF0aWMgdm9pZCBmaWxsX3BhZ2VfZG1hXzMyKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYs IHN0cnVjdCBpOTE1X3BhZ2VfZG1hICpwLAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAg Y29uc3QgdWludDMyX3QgdmFsMzIpCj4gK3sKPiArICAgICAgIHVpbnQ2NF90IHYgPSB2YWwzMjsK PiArCj4gKyAgICAgICB2ID0gdiA8PCAzMiB8IHZhbDMyOwo+ICsKPiArICAgICAgIGZpbGxfcGFn ZV9kbWEoZGV2LCBwLCB2KTsKPiArfQo+ICsKPiAgIHN0YXRpYyB2b2lkIGZyZWVfcHQoc3RydWN0 IGRybV9kZXZpY2UgKmRldiwgc3RydWN0IGk5MTVfcGFnZV90YWJsZSAqcHQpCj4gICB7Cj4gICAg ICAgICAgY2xlYW51cF9wYWdlX2RtYShkZXYsICZwdC0+YmFzZSk7Cj4gQEAgLTM0MCwxOSArMzY1 LDExIEBAIHN0YXRpYyB2b2lkIGZyZWVfcHQoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgc3RydWN0 IGk5MTVfcGFnZV90YWJsZSAqcHQpCj4gICBzdGF0aWMgdm9pZCBnZW44X2luaXRpYWxpemVfcHQo c3RydWN0IGk5MTVfYWRkcmVzc19zcGFjZSAqdm0sCj4gICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBzdHJ1Y3QgaTkxNV9wYWdlX3RhYmxlICpwdCkKPiAgIHsKPiAtICAgICAgIGdlbjhf cHRlX3QgKnB0X3ZhZGRyLCBzY3JhdGNoX3B0ZTsKPiAtICAgICAgIGludCBpOwo+IC0KPiAtICAg ICAgIHB0X3ZhZGRyID0ga21hcF9hdG9taWMocHQtPmJhc2UucGFnZSk7Cj4gLSAgICAgICBzY3Jh dGNoX3B0ZSA9IGdlbjhfcHRlX2VuY29kZSh2bS0+c2NyYXRjaC5hZGRyLAo+IC0gICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgSTkxNV9DQUNIRV9MTEMsIHRydWUpOwo+ICsgICAg ICAgZ2VuOF9wdGVfdCBzY3JhdGNoX3B0ZTsKPgo+IC0gICAgICAgZm9yIChpID0gMDsgaSA8IEdF TjhfUFRFUzsgaSsrKQo+IC0gICAgICAgICAgICAgICBwdF92YWRkcltpXSA9IHNjcmF0Y2hfcHRl Owo+ICsgICAgICAgc2NyYXRjaF9wdGUgPSBnZW44X3B0ZV9lbmNvZGUodm0tPnNjcmF0Y2guYWRk ciwgSTkxNV9DQUNIRV9MTEMsIHRydWUpOwo+Cj4gLSAgICAgICBpZiAoIUhBU19MTEModm0tPmRl dikpCj4gLSAgICAgICAgICAgICAgIGRybV9jbGZsdXNoX3ZpcnRfcmFuZ2UocHRfdmFkZHIsIFBB R0VfU0laRSk7Cj4gLSAgICAgICBrdW5tYXBfYXRvbWljKHB0X3ZhZGRyKTsKPiArICAgICAgIGZp bGxfcGFnZV9kbWEodm0tPmRldiwgJnB0LT5iYXNlLCBzY3JhdGNoX3B0ZSk7Cj4gICB9Cj4KPiAg IHN0YXRpYyBzdHJ1Y3QgaTkxNV9wYWdlX3RhYmxlICphbGxvY19wdChzdHJ1Y3QgZHJtX2Rldmlj ZSAqZGV2KQo+IEBAIC01ODUsMjAgKzYwMiwxMyBAQCBzdGF0aWMgdm9pZCBnZW44X2luaXRpYWxp emVfcGQoc3RydWN0IGk5MTVfYWRkcmVzc19zcGFjZSAqdm0sCj4gICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBzdHJ1Y3QgaTkxNV9wYWdlX2RpcmVjdG9yeSAqcGQpCj4gICB7Cj4gICAg ICAgICAgc3RydWN0IGk5MTVfaHdfcHBndHQgKnBwZ3R0ID0KPiAtICAgICAgICAgICAgICAgICAg ICAgICBjb250YWluZXJfb2Yodm0sIHN0cnVjdCBpOTE1X2h3X3BwZ3R0LCBiYXNlKTsKPiAtICAg ICAgIGdlbjhfcGRlX3QgKnBhZ2VfZGlyZWN0b3J5Owo+IC0gICAgICAgc3RydWN0IGk5MTVfcGFn ZV90YWJsZSAqcHQ7Cj4gLSAgICAgICBpbnQgaTsKPiArICAgICAgICAgICAgICAgY29udGFpbmVy X29mKHZtLCBzdHJ1Y3QgaTkxNV9od19wcGd0dCwgYmFzZSk7Cj4gKyAgICAgICBnZW44X3BkZV90 IHNjcmF0Y2hfcGRlOwo+Cj4gLSAgICAgICBwYWdlX2RpcmVjdG9yeSA9IGttYXBfYXRvbWljKHBk LT5iYXNlLnBhZ2UpOwo+IC0gICAgICAgcHQgPSBwcGd0dC0+c2NyYXRjaF9wdDsKPiAtICAgICAg IGZvciAoaSA9IDA7IGkgPCBJOTE1X1BERVM7IGkrKykKPiAtICAgICAgICAgICAgICAgLyogTWFw IHRoZSBQREUgdG8gdGhlIHBhZ2UgdGFibGUgKi8KPiAtICAgICAgICAgICAgICAgX19nZW44X2Rv X21hcF9wdChwYWdlX2RpcmVjdG9yeSArIGksIHB0LCB2bS0+ZGV2KTsKPiArICAgICAgIHNjcmF0 Y2hfcGRlID0gZ2VuOF9wZGVfZW5jb2RlKHZtLT5kZXYsIHBwZ3R0LT5zY3JhdGNoX3B0LT5iYXNl LmRhZGRyLAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgSTkxNV9DQUNI RV9MTEMpOwo+Cj4gLSAgICAgICBpZiAoIUhBU19MTEModm0tPmRldikpCj4gLSAgICAgICAgICAg ICAgIGRybV9jbGZsdXNoX3ZpcnRfcmFuZ2UocGFnZV9kaXJlY3RvcnksIFBBR0VfU0laRSk7Cj4g LSAgICAgICBrdW5tYXBfYXRvbWljKHBhZ2VfZGlyZWN0b3J5KTsKPiArICAgICAgIGZpbGxfcGFn ZV9kbWEodm0tPmRldiwgJnBkLT5iYXNlLCBzY3JhdGNoX3BkZSk7Cj4gICB9Cj4KPiAgIHN0YXRp YyB2b2lkIGdlbjhfZnJlZV9wYWdlX3RhYmxlcyhzdHJ1Y3QgaTkxNV9wYWdlX2RpcmVjdG9yeSAq cGQsIHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gQEAgLTEyOTIsMjIgKzEzMDIsMTUgQEAgc3Rh dGljIHZvaWQgZ2VuNl9wcGd0dF9pbnNlcnRfZW50cmllcyhzdHJ1Y3QgaTkxNV9hZGRyZXNzX3Nw YWNlICp2bSwKPiAgIH0KPgo+ICAgc3RhdGljIHZvaWQgZ2VuNl9pbml0aWFsaXplX3B0KHN0cnVj dCBpOTE1X2FkZHJlc3Nfc3BhY2UgKnZtLAo+IC0gICAgICAgICAgICAgICBzdHJ1Y3QgaTkxNV9w YWdlX3RhYmxlICpwdCkKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3RydWN0IGk5 MTVfcGFnZV90YWJsZSAqcHQpCj4gICB7Cj4gLSAgICAgICBnZW42X3B0ZV90ICpwdF92YWRkciwg c2NyYXRjaF9wdGU7Cj4gLSAgICAgICBpbnQgaTsKPiArICAgICAgIGdlbjZfcHRlX3Qgc2NyYXRj aF9wdGU7Cj4KPiAgICAgICAgICBXQVJOX09OKHZtLT5zY3JhdGNoLmFkZHIgPT0gMCk7Cj4KPiAt ICAgICAgIHNjcmF0Y2hfcHRlID0gdm0tPnB0ZV9lbmNvZGUodm0tPnNjcmF0Y2guYWRkciwKPiAt ICAgICAgICAgICAgICAgICAgICAgICBJOTE1X0NBQ0hFX0xMQywgdHJ1ZSwgMCk7Cj4gLQo+IC0g ICAgICAgcHRfdmFkZHIgPSBrbWFwX2F0b21pYyhwdC0+YmFzZS5wYWdlKTsKPiAtCj4gLSAgICAg ICBmb3IgKGkgPSAwOyBpIDwgR0VONl9QVEVTOyBpKyspCj4gLSAgICAgICAgICAgICAgIHB0X3Zh ZGRyW2ldID0gc2NyYXRjaF9wdGU7Cj4gKyAgICAgICBzY3JhdGNoX3B0ZSA9IHZtLT5wdGVfZW5j b2RlKHZtLT5zY3JhdGNoLmFkZHIsIEk5MTVfQ0FDSEVfTExDLCB0cnVlLCAwKTsKPgo+IC0gICAg ICAga3VubWFwX2F0b21pYyhwdF92YWRkcik7Cj4gKyAgICAgICBmaWxsX3BhZ2VfZG1hXzMyKHZt LT5kZXYsICZwdC0+YmFzZSwgc2NyYXRjaF9wdGUpOwo+ICAgfQo+Cj4gICBzdGF0aWMgaW50IGdl bjZfYWxsb2NfdmFfcmFuZ2Uoc3RydWN0IGk5MTVfYWRkcmVzc19zcGFjZSAqdm0sCj4gLS0KPiAx LjkuMQo+Cj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K PiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9y Zwo+IGh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1n ZngKPgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRl bC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=