From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michel Thierry Subject: Re: [PATCH 20/21] drm/i915/gtt: Use nonatomic bitmap ops Date: Wed, 03 Jun 2015 18:07:08 +0100 Message-ID: <556F343C.6000308@intel.com> References: <1432314314-23530-1-git-send-email-mika.kuoppala@intel.com> <1432314314-23530-21-git-send-email-mika.kuoppala@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 0AE5D6E192 for ; Wed, 3 Jun 2015 10:07:18 -0700 (PDT) In-Reply-To: <1432314314-23530-21-git-send-email-mika.kuoppala@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Mika Kuoppala , "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org T24gNS8yMi8yMDE1IDY6MDUgUE0sIE1pa2EgS3VvcHBhbGEgd3JvdGU6Cj4gVGhlcmUgaXMgbm8g bmVlZCBmb3IgYXRvbWljaXR5IGhlcmUuIENvbnZlcnQgYWxsIGJpdG1hcAo+IG9wZXJhdGlvbnMg dG8gbm9uYXRvbWljIHZhcmlhbnRzLgo+Cj4gQ2M6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3ly amFsYUBsaW51eC5pbnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogTWlrYSBLdW9wcGFsYSA8bWlr YS5rdW9wcGFsYUBpbnRlbC5jb20+ClJldmlld2VkLWJ5OiBNaWNoZWwgVGhpZXJyeSA8bWljaGVs LnRoaWVycnlAaW50ZWwuY29tPgoKPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf Z2VtX2d0dC5jIHwgMTIgKysrKysrLS0tLS0tCj4gICAxIGZpbGUgY2hhbmdlZCwgNiBpbnNlcnRp b25zKCspLCA2IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfZ2VtX2d0dC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZ3R0LmMK PiBpbmRleCBhYjExM2NlLi45NWMzOWU1IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfZ2VtX2d0dC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1f Z3R0LmMKPiBAQCAtODQyLDcgKzg0Miw3IEBAIHN0YXRpYyBpbnQgZ2VuOF9wcGd0dF9hbGxvY19w YWdldGFicyhzdHJ1Y3QgaTkxNV9od19wcGd0dCAqcHBndHQsCj4KPiAgICAgICAgICAgICAgICAg IGdlbjhfaW5pdGlhbGl6ZV9wdCgmcHBndHQtPmJhc2UsIHB0KTsKPiAgICAgICAgICAgICAgICAg IHBkLT5wYWdlX3RhYmxlW3BkZV0gPSBwdDsKPiAtICAgICAgICAgICAgICAgc2V0X2JpdChwZGUs IG5ld19wdHMpOwo+ICsgICAgICAgICAgICAgICBfX3NldF9iaXQocGRlLCBuZXdfcHRzKTsKPiAg ICAgICAgICB9Cj4KPiAgICAgICAgICByZXR1cm4gMDsKPiBAQCAtOTAwLDcgKzkwMCw3IEBAIHN0 YXRpYyBpbnQgZ2VuOF9wcGd0dF9hbGxvY19wYWdlX2RpcmVjdG9yaWVzKHN0cnVjdCBpOTE1X2h3 X3BwZ3R0ICpwcGd0dCwKPgo+ICAgICAgICAgICAgICAgICAgZ2VuOF9pbml0aWFsaXplX3BkKCZw cGd0dC0+YmFzZSwgcGQpOwo+ICAgICAgICAgICAgICAgICAgcGRwLT5wYWdlX2RpcmVjdG9yeVtw ZHBlXSA9IHBkOwo+IC0gICAgICAgICAgICAgICBzZXRfYml0KHBkcGUsIG5ld19wZHMpOwo+ICsg ICAgICAgICAgICAgICBfX3NldF9iaXQocGRwZSwgbmV3X3Bkcyk7Cj4gICAgICAgICAgfQo+Cj4g ICAgICAgICAgcmV0dXJuIDA7Cj4gQEAgLTEwNDAsNyArMTA0MCw3IEBAIHN0YXRpYyBpbnQgZ2Vu OF9hbGxvY192YV9yYW5nZShzdHJ1Y3QgaTkxNV9hZGRyZXNzX3NwYWNlICp2bSwKPiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBnZW44X3B0ZV9jb3VudChwZF9zdGFydCwgcGRf bGVuKSk7Cj4KPiAgICAgICAgICAgICAgICAgICAgICAgICAgLyogT3VyIHBkZSBpcyBub3cgcG9p bnRpbmcgdG8gdGhlIHBhZ2V0YWJsZSwgcHQgKi8KPiAtICAgICAgICAgICAgICAgICAgICAgICBz ZXRfYml0KHBkZSwgcGQtPnVzZWRfcGRlcyk7Cj4gKyAgICAgICAgICAgICAgICAgICAgICAgX19z ZXRfYml0KHBkZSwgcGQtPnVzZWRfcGRlcyk7Cj4KPiAgICAgICAgICAgICAgICAgICAgICAgICAg LyogTWFwIHRoZSBQREUgdG8gdGhlIHBhZ2UgdGFibGUgKi8KPiAgICAgICAgICAgICAgICAgICAg ICAgICAgcGFnZV9kaXJlY3RvcnlbcGRlXSA9IGdlbjhfcGRlX2VuY29kZShweF9kbWEocHQpLAo+ IEBAIC0xMDUyLDcgKzEwNTIsNyBAQCBzdGF0aWMgaW50IGdlbjhfYWxsb2NfdmFfcmFuZ2Uoc3Ry dWN0IGk5MTVfYWRkcmVzc19zcGFjZSAqdm0sCj4KPiAgICAgICAgICAgICAgICAgIGt1bm1hcF9w eChwcGd0dCwgcGFnZV9kaXJlY3RvcnkpOwo+Cj4gLSAgICAgICAgICAgICAgIHNldF9iaXQocGRw ZSwgcHBndHQtPnBkcC51c2VkX3BkcGVzKTsKPiArICAgICAgICAgICAgICAgX19zZXRfYml0KHBk cGUsIHBwZ3R0LT5wZHAudXNlZF9wZHBlcyk7Cj4gICAgICAgICAgfQo+Cj4gICAgICAgICAgZnJl ZV9nZW44X3RlbXBfYml0bWFwcyhuZXdfcGFnZV9kaXJzLCBuZXdfcGFnZV90YWJsZXMpOwo+IEBA IC0xNDk3LDcgKzE0OTcsNyBAQCBzdGF0aWMgaW50IGdlbjZfYWxsb2NfdmFfcmFuZ2Uoc3RydWN0 IGk5MTVfYWRkcmVzc19zcGFjZSAqdm0sCj4gICAgICAgICAgICAgICAgICBnZW42X2luaXRpYWxp emVfcHQodm0sIHB0KTsKPgo+ICAgICAgICAgICAgICAgICAgcHBndHQtPnBkLnBhZ2VfdGFibGVb cGRlXSA9IHB0Owo+IC0gICAgICAgICAgICAgICBzZXRfYml0KHBkZSwgbmV3X3BhZ2VfdGFibGVz KTsKPiArICAgICAgICAgICAgICAgX19zZXRfYml0KHBkZSwgbmV3X3BhZ2VfdGFibGVzKTsKPiAg ICAgICAgICAgICAgICAgIHRyYWNlX2k5MTVfcGFnZV90YWJsZV9lbnRyeV9hbGxvYyh2bSwgcGRl LCBzdGFydCwgR0VONl9QREVfU0hJRlQpOwo+ICAgICAgICAgIH0KPgo+IEBAIC0xNTExLDcgKzE1 MTEsNyBAQCBzdGF0aWMgaW50IGdlbjZfYWxsb2NfdmFfcmFuZ2Uoc3RydWN0IGk5MTVfYWRkcmVz c19zcGFjZSAqdm0sCj4gICAgICAgICAgICAgICAgICBiaXRtYXBfc2V0KHRtcF9iaXRtYXAsIGdl bjZfcHRlX2luZGV4KHN0YXJ0KSwKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZ2VuNl9w dGVfY291bnQoc3RhcnQsIGxlbmd0aCkpOwo+Cj4gLSAgICAgICAgICAgICAgIGlmICh0ZXN0X2Fu ZF9jbGVhcl9iaXQocGRlLCBuZXdfcGFnZV90YWJsZXMpKQo+ICsgICAgICAgICAgICAgICBpZiAo X190ZXN0X2FuZF9jbGVhcl9iaXQocGRlLCBuZXdfcGFnZV90YWJsZXMpKQo+ICAgICAgICAgICAg ICAgICAgICAgICAgICBnZW42X3dyaXRlX3BkZSgmcHBndHQtPnBkLCBwZGUsIHB0KTsKPgo+ICAg ICAgICAgICAgICAgICAgdHJhY2VfaTkxNV9wYWdlX3RhYmxlX2VudHJ5X21hcCh2bSwgcGRlLCBw dCwKPiAtLQo+IDEuOS4xCj4KPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCj4gaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2ludGVsLWdmeApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdm eAo=