From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michel Thierry Subject: Re: [PATCH 21/21] drm/i915/gtt: Reorder page alloc/free/init functions Date: Wed, 03 Jun 2015 18:14:25 +0100 Message-ID: <556F35F1.1080606@intel.com> References: <1432314314-23530-1-git-send-email-mika.kuoppala@intel.com> <1432314314-23530-22-git-send-email-mika.kuoppala@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 42B4C6E192 for ; Wed, 3 Jun 2015 10:14:31 -0700 (PDT) In-Reply-To: <1432314314-23530-22-git-send-email-mika.kuoppala@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Mika Kuoppala , "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org T24gNS8yMi8yMDE1IDY6MDUgUE0sIE1pa2EgS3VvcHBhbGEgd3JvdGU6Cj4gSW50cm9kdWNlIGJh c2UgcGFnZSBoYW5kbGluZyBmdW5jdGlvbnMgaW4gb3JkZXIgb2YKPiBhbGxvYywgZnJlZSwgaW5p dC4gTm8gZnVuY3Rpb25hbCBjaGFuZ2VzLgoKQ2FuIHlvdSBjaGFuZ2UgdGhpcyBzZW50ZW5jZSBs aWtlIHRoaXM/CgogICBfS2VlcC9NYWludGFpbl8gYmFzZSBwYWdlIGhhbmRsaW5nIGZ1bmN0aW9u cyBpbiBvcmRlciBvZgogICBhbGxvYywgZnJlZSBhbmQgaW5pdC4gTm8gZnVuY3Rpb25hbCBjaGFu Z2VzLgoKX0ludHJvZHVjZV8gbWFkZSBtZSB0aGluayB0aGVyZSB3YXMgc29tZXRoaW5nIG5ldyBp biB0aGlzIHBhdGNoLgoKCj4KPiBTaWduZWQtb2ZmLWJ5OiBNaWthIEt1b3BwYWxhIDxtaWthLmt1 b3BwYWxhQGludGVsLmNvbT4KClJldmlld2VkLWJ5OiBNaWNoZWwgVGhpZXJyeSA8bWljaGVsLnRo aWVycnlAaW50ZWwuY29tPgoKPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2Vt X2d0dC5jIHwgNTQgKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICAgMSBm aWxlIGNoYW5nZWQsIDI3IGluc2VydGlvbnMoKyksIDI3IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2d0dC5jIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9nZW1fZ3R0LmMKPiBpbmRleCA5NWMzOWU1Li4yNGYzMWFkIDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2d0dC5jCj4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZ3R0LmMKPiBAQCAtMzgxLDI0ICszODEsNiBAQCBzdGF0 aWMgdm9pZCBmaWxsX3BhZ2VfZG1hXzMyKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHN0cnVjdCBp OTE1X3BhZ2VfZG1hICpwLAo+ICAgICAgICAgIGZpbGxfcGFnZV9kbWEoZGV2LCBwLCB2KTsKPiAg IH0KPgo+IC1zdGF0aWMgdm9pZCBmcmVlX3B0KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHN0cnVj dCBpOTE1X3BhZ2VfdGFibGUgKnB0KQo+IC17Cj4gLSAgICAgICBjbGVhbnVwX3B4KGRldiwgcHQp Owo+IC0gICAgICAga2ZyZWUocHQtPnVzZWRfcHRlcyk7Cj4gLSAgICAgICBrZnJlZShwdCk7Cj4g LX0KPiAtCj4gLXN0YXRpYyB2b2lkIGdlbjhfaW5pdGlhbGl6ZV9wdChzdHJ1Y3QgaTkxNV9hZGRy ZXNzX3NwYWNlICp2bSwKPiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3RydWN0IGk5 MTVfcGFnZV90YWJsZSAqcHQpCj4gLXsKPiAtICAgICAgIGdlbjhfcHRlX3Qgc2NyYXRjaF9wdGU7 Cj4gLQo+IC0gICAgICAgc2NyYXRjaF9wdGUgPSBnZW44X3B0ZV9lbmNvZGUocHhfZG1hKHZtLT5z Y3JhdGNoX3BhZ2UpLAo+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgSTkx NV9DQUNIRV9MTEMsIHRydWUpOwo+IC0KPiAtICAgICAgIGZpbGxfcHgodm0tPmRldiwgcHQsIHNj cmF0Y2hfcHRlKTsKPiAtfQo+IC0KPiAgIHN0YXRpYyBzdHJ1Y3QgaTkxNV9wYWdlX3RhYmxlICph bGxvY19wdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ICAgewo+ICAgICAgICAgIHN0cnVjdCBp OTE1X3BhZ2VfdGFibGUgKnB0Owo+IEBAIC00MzAsNiArNDEyLDI0IEBAIGZhaWxfYml0bWFwOgo+ ICAgICAgICAgIHJldHVybiBFUlJfUFRSKHJldCk7Cj4gICB9Cj4KPiArc3RhdGljIHZvaWQgZnJl ZV9wdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCBzdHJ1Y3QgaTkxNV9wYWdlX3RhYmxlICpwdCkK PiArewo+ICsgICAgICAgY2xlYW51cF9weChkZXYsIHB0KTsKPiArICAgICAgIGtmcmVlKHB0LT51 c2VkX3B0ZXMpOwo+ICsgICAgICAga2ZyZWUocHQpOwo+ICt9Cj4gKwo+ICtzdGF0aWMgdm9pZCBn ZW44X2luaXRpYWxpemVfcHQoc3RydWN0IGk5MTVfYWRkcmVzc19zcGFjZSAqdm0sCj4gKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIHN0cnVjdCBpOTE1X3BhZ2VfdGFibGUgKnB0KQo+ICt7 Cj4gKyAgICAgICBnZW44X3B0ZV90IHNjcmF0Y2hfcHRlOwo+ICsKPiArICAgICAgIHNjcmF0Y2hf cHRlID0gZ2VuOF9wdGVfZW5jb2RlKHB4X2RtYSh2bS0+c2NyYXRjaF9wYWdlKSwKPiArICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIEk5MTVfQ0FDSEVfTExDLCB0cnVlKTsKPiAr Cj4gKyAgICAgICBmaWxsX3B4KHZtLT5kZXYsIHB0LCBzY3JhdGNoX3B0ZSk7Cj4gK30KPiArCj4g ICBzdGF0aWMgdm9pZCBnZW42X2luaXRpYWxpemVfcHQoc3RydWN0IGk5MTVfYWRkcmVzc19zcGFj ZSAqdm0sCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzdHJ1Y3QgaTkxNV9wYWdl X3RhYmxlICpwdCkKPiAgIHsKPiBAQCAtNDQxLDE1ICs0NDEsNiBAQCBzdGF0aWMgdm9pZCBnZW42 X2luaXRpYWxpemVfcHQoc3RydWN0IGk5MTVfYWRkcmVzc19zcGFjZSAqdm0sCj4gICAgICAgICAg ZmlsbDMyX3B4KHZtLT5kZXYsIHB0LCBzY3JhdGNoX3B0ZSk7Cj4gICB9Cj4KPiAtc3RhdGljIHZv aWQgZnJlZV9wZChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCBzdHJ1Y3QgaTkxNV9wYWdlX2RpcmVj dG9yeSAqcGQpCj4gLXsKPiAtICAgICAgIGlmIChweF9wYWdlKHBkKSkgewo+IC0gICAgICAgICAg ICAgICBjbGVhbnVwX3B4KGRldiwgcGQpOwo+IC0gICAgICAgICAgICAgICBrZnJlZShwZC0+dXNl ZF9wZGVzKTsKPiAtICAgICAgICAgICAgICAga2ZyZWUocGQpOwo+IC0gICAgICAgfQo+IC19Cj4g LQo+ICAgc3RhdGljIHN0cnVjdCBpOTE1X3BhZ2VfZGlyZWN0b3J5ICphbGxvY19wZChzdHJ1Y3Qg ZHJtX2RldmljZSAqZGV2KQo+ICAgewo+ICAgICAgICAgIHN0cnVjdCBpOTE1X3BhZ2VfZGlyZWN0 b3J5ICpwZDsKPiBAQCAtNDc4LDYgKzQ2OSwxNSBAQCBmcmVlX3BkOgo+ICAgICAgICAgIHJldHVy biBFUlJfUFRSKHJldCk7Cj4gICB9Cj4KPiArc3RhdGljIHZvaWQgZnJlZV9wZChzdHJ1Y3QgZHJt X2RldmljZSAqZGV2LCBzdHJ1Y3QgaTkxNV9wYWdlX2RpcmVjdG9yeSAqcGQpCj4gK3sKPiArICAg ICAgIGlmIChweF9wYWdlKHBkKSkgewo+ICsgICAgICAgICAgICAgICBjbGVhbnVwX3B4KGRldiwg cGQpOwo+ICsgICAgICAgICAgICAgICBrZnJlZShwZC0+dXNlZF9wZGVzKTsKPiArICAgICAgICAg ICAgICAga2ZyZWUocGQpOwo+ICsgICAgICAgfQo+ICt9Cj4gKwo+ICAgc3RhdGljIHZvaWQgZ2Vu OF9pbml0aWFsaXplX3BkKHN0cnVjdCBpOTE1X2FkZHJlc3Nfc3BhY2UgKnZtLAo+ICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgc3RydWN0IGk5MTVfcGFnZV9kaXJlY3RvcnkgKnBkKQo+ ICAgewo+IC0tCj4gMS45LjEKPgo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKPiBodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vaW50ZWwtZ2Z4Cj4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRl bC1nZngK