From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mario Kleiner Subject: Re: [PATCH 1/3] drm/nouveau: Use drm_vblank_on/off consistently Date: Fri, 05 Jun 2015 21:40:34 +0200 Message-ID: <5571FB32.50906@gmail.com> References: <1432717471-7879-1-git-send-email-daniel.vetter@ffwll.ch> <556898BE.4090108@gmail.com> <20150529171921.GT8341@phenom.ffwll.local> <5568A097.7020904@gmail.com> <20150529173521.GY8341@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20150529173521.GY8341@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: Daniel Vetter , Intel Graphics Development , Ben Skeggs , DRI Development , Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org T24gMDUvMjkvMjAxNSAwNzozNSBQTSwgRGFuaWVsIFZldHRlciB3cm90ZToKPiBPbiBGcmksIE1h eSAyOSwgMjAxNSBhdCAwNzoyMzozNVBNICswMjAwLCBNYXJpbyBLbGVpbmVyIHdyb3RlOgo+Pgo+ Pgo+PiBPbiAwNS8yOS8yMDE1IDA3OjE5IFBNLCBEYW5pZWwgVmV0dGVyIHdyb3RlOgo+Pj4gT24g RnJpLCBNYXkgMjksIDIwMTUgYXQgMDY6NTA6MDZQTSArMDIwMCwgTWFyaW8gS2xlaW5lciB3cm90 ZToKPj4+PiBPbiAwNS8yNy8yMDE1IDExOjA0IEFNLCBEYW5pZWwgVmV0dGVyIHdyb3RlOgo+Pj4+ PiBJbgo+Pj4+Pgo+Pj4+PiBjb21taXQgOWNiYTVlZmFiNWE4MTQ1YWU2YzUyZWEyNzM1NTNmMDY5 YzI5NDQ4Mgo+Pj4+PiBBdXRob3I6IE1hcmlvIEtsZWluZXIgPG1hcmlvLmtsZWluZXIuZGVAZ21h aWwuY29tPgo+Pj4+PiBEYXRlOiAgIFR1ZSBKdWwgMjkgMDI6MzY6NDQgMjAxNCArMDIwMAo+Pj4+ Pgo+Pj4+PiAgICAgIGRybS9ub3V2ZWF1OiBEaXMvRW5hYmxlIHZibGFuayBpcnFzIGR1cmluZyBz dXNwZW5kL3Jlc3VtZQo+Pj4+Pgo+Pj4+PiBkcm1fdmJsYW5rX29uL29mZiBjYWxscyB3aGVyZSBh ZGRlZCBhcm91bmQgc3VzcGVuZC9yZXN1bWUgdG8gbWFrZSBzdXJlCj4+Pj4+IHZibGFuayBzdGF5 IGRvZXNuJ3QgZ28gYm9vbSBvdmVyIHRoYXQgdHJhbnNpdGlvbi4gQnV0IG5vdXZlYXUgYWxyZWFk eQo+Pj4+PiB1c2VkIGRybV92YmxhbmtfcHJlL3Bvc3RfbW9kZXNldCBvdmVyIG1vZGVzZXRzLiBJ bnN0ZWFkIHVzZQo+Pj4+PiBkcm1fdmJsYW5rX29uL29mZiBldmVyeWh3ZXJlLiBUaGUgc2xpZ2h0 IGNoYW5nZSBoZXJlIGlzIHRoYXQgYWZ0ZXIKPj4+Pj4gX29mZiBkcm1fdmJsYW5rX2dldCB3aWxs IHJlZnVzZSB0byB3b3JrIHJpZ2h0IGF3YXksIGJ1dCBub3V2ZWF1Cj4+Pj4+IGRvZXNuJ3Qgc2Vl bSB0byBkZXBlbmQgdXBvbiB0aGF0IGFueXdoZXJlIG91dHNpZGUgb2YgdGhlIHBhZ2VmbGlwCj4+ Pj4+IHBhdGhzLgo+Pj4+Pgo+Pj4+PiBUaGUgbG9uZ2VyLXRlcm0gcGxhbiBoZXJlIGlzIHRvIHN3 aXRjaCBhbGwga21zIGRyaXZlcnMgdG8KPj4+Pj4gZHJtX3ZibGFua19vbi9vZmYgc28gdGhhdCBj b21tb24gY29kZSBsaWtlIHBlbmRpbmcgZXZlbnQgY2xlYW51cCBjYW4KPj4+Pj4gYmUgZG9uZSB0 aGVyZSwgd2hpbGUgZHJtX3ZibGFua19wcmUvcG9zdF9tb2Rlc2V0IHdpbGwgYmUgcHVyZWx5Cj4+ Pj4+IGRybSBpbnRlcm5hbCBmb3IgdGhlIG9sZCBVTVMgaW9jdGwuCj4+Pj4+Cj4+Pj4+IE5vdGUg dGhhdCB0aGUgZHJtX3ZibGFua19vZmYgc3RpbGwgc2VlbXMgcmVxdWlyZWQgaW4gdGhlIHN1c3Bl bmQgcGF0aAo+Pj4+PiBzaW5jZSBub3V2ZWF1IGRvZXNuJ3QgZXhwbGljaXRseSBkaXNhYmxlIGNy dGNzLiBCdXQgb24gdGhlIHJlc3VtZSBzaWRlCj4+Pj4+IGRybV9oZWxwZXJfcmVzdW1lX2ZvcmNl X21vZGUgc2hvdWxkIGVuZCB1cCBjYWxsaW5nIGRybV92Ymxhbmtfb24KPj4+Pj4gdGhyb3VnaCB0 aGUgbm91dmVhdSBjcnRjIGhvb2tzIGFscmVhZHkuIEhlbmNlIHJlbW92ZSB0aGUgY2FsbCBpbiB0 aGUKPj4+Pj4gcmVzdW1lIGNvZGUuCj4+Pj4+Cj4+Pj4+IENjOiBNYXJpbyBLbGVpbmVyIDxtYXJp by5rbGVpbmVyLmRlQGdtYWlsLmNvbT4KPj4+Pj4gQ2M6IEJlbiBTa2VnZ3MgPGJza2VnZ3NAcmVk aGF0LmNvbT4KPj4+Pj4gU2lnbmVkLW9mZi1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRl ckBpbnRlbC5jb20+Cj4+Pj4+IC0tLQo+Pj4+PiAgIGRyaXZlcnMvZ3B1L2RybS9ub3V2ZWF1L2Rp c3BudjA0L2NydGMuYyAgIHwgNCArKy0tCj4+Pj4+ICAgZHJpdmVycy9ncHUvZHJtL25vdXZlYXUv bm91dmVhdV9kaXNwbGF5LmMgfCA0IC0tLS0KPj4+Pj4gICAyIGZpbGVzIGNoYW5nZWQsIDIgaW5z ZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKPj4+Pj4KPj4+Pj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9ub3V2ZWF1L2Rpc3BudjA0L2NydGMuYyBiL2RyaXZlcnMvZ3B1L2RybS9ub3V2 ZWF1L2Rpc3BudjA0L2NydGMuYwo+Pj4+PiBpbmRleCAzZDk2YjQ5ZmU2NjIuLmRhYjI0MDY2ZmEy MSAxMDA2NDQKPj4+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL25vdXZlYXUvZGlzcG52MDQvY3J0 Yy5jCj4+Pj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9ub3V2ZWF1L2Rpc3BudjA0L2NydGMuYwo+ Pj4+PiBAQCAtNzA4LDcgKzcwOCw3IEBAIHN0YXRpYyB2b2lkIG52X2NydGNfcHJlcGFyZShzdHJ1 Y3QgZHJtX2NydGMgKmNydGMpCj4+Pj4+ICAgCWlmIChudl90d29faGVhZHMoZGV2KSkKPj4+Pj4g ICAJCU5WU2V0T3duZXIoZGV2LCBudl9jcnRjLT5pbmRleCk7Cj4+Pj4+Cj4+Pj4+IC0JZHJtX3Zi bGFua19wcmVfbW9kZXNldChkZXYsIG52X2NydGMtPmluZGV4KTsKPj4+Pj4gKwlkcm1fdmJsYW5r X29mZihkZXYsIG52X2NydGMtPmluZGV4KTsKPj4+Pj4gICAJZnVuY3MtPmRwbXMoY3J0YywgRFJN X01PREVfRFBNU19PRkYpOwo+Pj4+Pgo+Pj4+PiAgIAlOVkJsYW5rU2NyZWVuKGRldiwgbnZfY3J0 Yy0+aW5kZXgsIHRydWUpOwo+Pj4+PiBAQCAtNzQwLDcgKzc0MCw3IEBAIHN0YXRpYyB2b2lkIG52 X2NydGNfY29tbWl0KHN0cnVjdCBkcm1fY3J0YyAqY3J0YykKPj4+Pj4gICAjZW5kaWYKPj4+Pj4K Pj4+Pj4gICAJZnVuY3MtPmRwbXMoY3J0YywgRFJNX01PREVfRFBNU19PTik7Cj4+Pj4+IC0JZHJt X3ZibGFua19wb3N0X21vZGVzZXQoZGV2LCBudl9jcnRjLT5pbmRleCk7Cj4+Pj4+ICsJZHJtX3Zi bGFua19vbihkZXYsIG52X2NydGMtPmluZGV4KTsKPj4+Pj4gICB9Cj4+Pj4KPj4+PiBUaGUgYWJv dmUgaHVuayBpcyBwcm9iYWJseSBjb3JyZWN0LCBidXQgaSBjb3VsZG4ndCB0ZXN0IGl0IHdpdGhv dXQKPj4+PiBzdWZmaWNpZW50bHkgb2xkIHByZS1udiA1MCBoYXJkd2FyZS4KPj4+Pgo+Pj4+Pgo+ Pj4+PiAgIHN0YXRpYyB2b2lkIG52X2NydGNfZGVzdHJveShzdHJ1Y3QgZHJtX2NydGMgKmNydGMp Cj4+Pj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vbm91dmVhdS9ub3V2ZWF1X2Rpc3Bs YXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9ub3V2ZWF1L25vdXZlYXVfZGlzcGxheS5jCj4+Pj4+IGlu ZGV4IDg2NzBkOTBjZGMxMS4uZDgyNDAyM2Y5ZmM2IDEwMDY0NAo+Pj4+PiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vbm91dmVhdS9ub3V2ZWF1X2Rpc3BsYXkuYwo+Pj4+PiArKysgYi9kcml2ZXJzL2dw dS9kcm0vbm91dmVhdS9ub3V2ZWF1X2Rpc3BsYXkuYwo+Pj4+PiBAQCAtNjIwLDEwICs2MjAsNiBA QCBub3V2ZWF1X2Rpc3BsYXlfcmVzdW1lKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIGJvb2wgcnVu dGltZSkKPj4+Pj4gICAJCW52X2NydGMtPmx1dC5kZXB0aCA9IDA7Cj4+Pj4+ICAgCX0KPj4+Pj4K Pj4+Pj4gLQkvKiBNYWtlIHN1cmUgdGhhdCBkcm0gYW5kIGh3IHZibGFuayBpcnFzIGdldCByZXN1 bWVkIGlmIG5lZWRlZC4gKi8KPj4+Pj4gLQlmb3IgKGhlYWQgPSAwOyBoZWFkIDwgZGV2LT5tb2Rl X2NvbmZpZy5udW1fY3J0YzsgaGVhZCsrKQo+Pj4+PiAtCQlkcm1fdmJsYW5rX29uKGRldiwgaGVh ZCk7Cj4+Pj4+IC0KPj4+Pj4gICAJLyogVGhpcyBzaG91bGQgZW5zdXJlIHdlIGRvbid0IGhpdCBh IGxvY2tpbmcgcHJvYmxlbSB3aGVuIHNvbWVvbmUKPj4+Pj4gICAJICogd2FrZXMgdXMgdXAgdmlh IGEgY29ubmVjdG9yLiAgV2Ugc2hvdWxkIG5ldmVyIGdvIGludG8gc3VzcGVuZAo+Pj4+PiAgIAkg KiB3aGlsZSB0aGUgZGlzcGxheSBpcyBvbiBhbnl3YXlzLgo+Pj4+Pgo+Pj4+Cj4+Pj4gVGVzdGVk IHRoaXMgb25lIGFuZCB0aGlzIGh1bmsgYnJlYWtzIHN1c3BlbmQvcmVzdW1lLiBBZnRlciBhIHN1 c3BlbmQvcmVzdW1lCj4+Pj4gY3ljbGUsIGFsbCBPcGVuR0wgYXBwcyBhbmQgY29tcG9zaXRlZCBk ZXNrdG9wIGFyZSBkZWFkLCBhcyB0aGUgY29yZSBjYW4ndAo+Pj4+IGdldCBhbnkgdmJsYW5rIGly cSdzIGVuYWJsZWQgYW55bW9yZS4KPj4+Pgo+Pj4+IFNvIHRoZSBkcm1fdmJsYW5rX29uKCkgaXMg c3RpbGwgbmVlZGVkIGhlcmUuCj4+Pgo+Pj4gSG0gdGhhdCdzIHZlcnkgc3VycHJpc2luZy4gQXMg bWVudGlvbmVkIGFib3ZlIHRoZSBmb3JjZV9tb2RlX3Jlc3RvcmUKPj4+IHNob3VsZCBiZSBjYWxs aW5nIG52X2NydGNfcHJlcGFyZSBhbHJlYWR5IGFuZCBmaXggdGhpcyBhbGwgdXAgZm9yIHVzLiBJ Cj4+PiBndWVzcyBJIG5lZWQgdG8gZGlnIG91dCBteSBudiBjYXJkIGFuZCB0cmFjZSB3aGF0J3Mg cmVhbGx5IGdvaW5nIG9uIGhlcmUuCj4+Pgo+Pj4gRW5hYmxpbmcgaW50ZXJydXB0cyB3aGVuIHRo ZSBjcnRjIGlzIG9mZiBpc24ndCBhIGdvb2QgaWRlYS4KPj4+IC1EYW5pZWwKPj4+Cj4+Cj4+IEkg dGhpbmsgdGhlIG52X2NydGNfcHJlcGFyZSgpIHBhdGggbW9kaWZpZWQgaW4geW91ciBmaXJzdCBo dW5rIGlzIG9ubHkgZm9yCj4+IHRoZSBvcmlnaW5hbCBudjA0IGRpc3BsYXkgZW5naW5lIGZvciB2 ZXJ5IG9sZCBjYXJkcy4gbnY1MCsgKEdlRm9yY2UtOCBhbmQKPj4gbGF0ZXIpIHRha2UgZGlmZmVy ZW50IHBhdGhzLgo+Cj4gT2ggcmlnaHQgdG90YWxseSBtaXNzZWQgdGhlIG52NTArIGNvZGUuIEkg b25seSBncmVwcGVkIGZvcgo+IHByZS9wb3N0X21vZGVzZXQgLi4uCj4KPiBCZWxvdyB1bnRlc3Rl ZCBkaWZmIHNob3VsZCBoZWxwLiBJIGFsc28gcmVhbGl6ZWQgdGhhdCB0aGUgcHJlLW52NTAgY29k ZQo+IGxhY2tzIGRybV92Ymxhbmtfb24vb2ZmIGluIHRoZSBkcG1zIGNhbGxiYWNrLCBzbyB0aGVy ZSdzIG1vcmUgd29yayB0byBkbwo+IGFueXdheSBmb3IgdGhpcyBvbmUgaGVyZS4KPgo+IFRoYW5r cywgRGFuaWVsCj4KClRoZSBkaWZmIG9uIHRvcCBvZiB5b3VyIHBhdGNoIGlzIG5vdyB0ZXN0ZWQg YW5kIGhlbHBzLiBzdXNwZW5kLT5yZXN1bWUgCmlzIG5vdyBmaW5lIG9uIG52NTAuIEluIHlvdXIg cGF0Y2gsIG5vdXZlYXVfZGlzcGxheV9yZXN1bWUoKSB3b3VsZCBhbHNvIApuZWVkIHRvIGdldCBh IG5vdyB1bnVzZWQgImludCBoZWFkIiByZW1vdmVkIHRvIG1ha2UgdGhlIGNvbXBpbGVyIGhhcHB5 LgoKLW1hcmlvCgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vbm91dmVhdS9udjUwX2Rp c3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9ub3V2ZWF1L252NTBfZGlzcGxheS5jCj4gaW5kZXgg N2RhNzk1ODU1NmEzLi5hMTZjMzdkOGY3ZTEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L25vdXZlYXUvbnY1MF9kaXNwbGF5LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vbm91dmVhdS9u djUwX2Rpc3BsYXkuYwo+IEBAIC05OTcsNiArOTk3LDEwIEBAIG52NTBfY3J0Y19jdXJzb3Jfc2hv d19oaWRlKHN0cnVjdCBub3V2ZWF1X2NydGMgKm52X2NydGMsIGJvb2wgc2hvdywgYm9vbCB1cGRh dGUpCj4gICBzdGF0aWMgdm9pZAo+ICAgbnY1MF9jcnRjX2RwbXMoc3RydWN0IGRybV9jcnRjICpj cnRjLCBpbnQgbW9kZSkKPiAgIHsKPiArCWlmIChtb2RlID09IERSTV9NT0RFX0RQTVNfT04pCj4g KwkJZHJtX2NydGNfdmJsYW5rX29uKGNydGMpOwo+ICsJZWxzZQo+ICsJCWRybV9jcnRjX3ZibGFu a19vZmYoY3J0Yyk7Cj4gICB9Cj4KPiAgIHN0YXRpYyB2b2lkCj4gQEAgLTEwMzYsNiArMTA0MCw4 IEBAIG52NTBfY3J0Y19wcmVwYXJlKHN0cnVjdCBkcm1fY3J0YyAqY3J0YykKPiAgIAl9Cj4KPiAg IAludjUwX2NydGNfY3Vyc29yX3Nob3dfaGlkZShudl9jcnRjLCBmYWxzZSwgZmFsc2UpOwo+ICsK PiArCWRybV9jcnRjX3ZibGFua19vbihjcnRjKTsKPiAgIH0KPgo+ICAgc3RhdGljIHZvaWQKPiBA QCAtMTA0NSw2ICsxMDUxLDggQEAgbnY1MF9jcnRjX2NvbW1pdChzdHJ1Y3QgZHJtX2NydGMgKmNy dGMpCj4gICAJc3RydWN0IG52NTBfbWFzdCAqbWFzdCA9IG52NTBfbWFzdChjcnRjLT5kZXYpOwo+ ICAgCXUzMiAqcHVzaDsKPgo+ICsJZHJtX2NydGNfdmJsYW5rX29uKGNydGMpOwo+ICsKPiAgIAlw dXNoID0gZXZvX3dhaXQobWFzdCwgMzIpOwo+ICAgCWlmIChwdXNoKSB7Cj4gICAJCWlmIChudjUw X3ZlcnMobWFzdCkgPCBHODJfRElTUF9DT1JFX0NIQU5ORUxfRE1BKSB7Cj4KX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlz dApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK