Re: [PATCH v2 07/10] drm/i915: Add pipe level Gamma correction for CHV/BSW

Damien Lespiau
2015-06-09T14:15:30Z

On Thu, Jun 04, 2015 at 07:12:38PM +0530, Kausal Malladi wrote:
> From: Kausal Malladi <Kausal.Malladi@intel.com>
>
> This patch does the following:
> 1. Adds the core function to program Gamma correction values for CHV/BSW
> platform

A couple of things I forgot (they are probably others):
- This patch doesn't actually add anything for CHV despite the claim
- The properties are exposed everywhere, but return -EINVAL on
!IS_CHERRYVIEW. We only expose the properties on a platform when we
do have code that can make this property work for that platform.
This way userspace can easily know if the feature is supported or
not by querying if the property exists.

--
Damien