From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Gordon Subject: Re: [PATCH] drm/i915: Correcting the reg definitions for PORT_DFT Date: Wed, 10 Jun 2015 13:27:40 +0100 Message-ID: <55782D3C.2050901@intel.com> References: <1433509224-9502-1-git-send-email-minu.mathai@intel.com> <20150605130817.GX5176@intel.com> <5576FFC9.6080506@intel.com> <87vbew6l2k.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 3B9666E8B2 for ; Wed, 10 Jun 2015 05:27:47 -0700 (PDT) In-Reply-To: <87vbew6l2k.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula , =?UTF-8?B?VmlsbGUgU3lyasOk?= =?UTF-8?B?bMOk?= , Minu Mathai Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMTAvMDYvMTUgMDk6MDksIEphbmkgTmlrdWxhIHdyb3RlOgo+IE9uIFR1ZSwgMDkgSnVuIDIw MTUsIERhdmUgR29yZG9uIDxkYXZpZC5zLmdvcmRvbkBpbnRlbC5jb20+IHdyb3RlOgo+PiBSZWdh cmRsZXNzIG9mIHdoZXRoZXIgaXQncyB1c2VkLCB3ZSBoYXZlIGFuIGluY29uc2lzdGVuY3kgYmV0 d2VlbiB0aGUKPj4gZGVmaW5pdGlvbnMgb2YgUE9SVF9ERlRfSTlYWCBhbmQgUE9SVF9ERlQyX0c0 WCAtLSBvbmUgaW5jbHVkZXMgdGhlCj4+IG1taW9fb2Zmc2V0IGFuZCB0aGUgb3RoZXIgZG9lc24n dC4KPiAKPiBJdCdzIG5vdCBpbmNvbnNpc3RlbnQsIGl0J3MgY29uc2lzdGVudCBvbiBhbm90aGVy IGxldmVsOgo+IAo+IFdlJ3ZlIHNldHRsZWQgb24gaW5jbHVkaW5nIHRoZSBtbWlvX29mZnNldCBv bmx5IGZvciBtYWNyb3MgdGhhdCBuZWVkCj4gaXQuIElmIGEgbWFjcm8gaXMgcmVsZXZhbnQgb25s eSBvbiBwbGF0Zm9ybXMgdGhhdCBhbGwgaGF2ZSB0aGUgc2FtZSBtbWlvCj4gb2Zmc2V0LCB0aGUg b2Zmc2V0IGlzIGluY2x1ZGVkIHN0YXRpY2FsbHkgKGN1cnJlbnRseSAwIG9yCj4gVkxWX0RJU1BM QVlfQkFTRSkuIGRldl9wcml2LT5pbmZvLmRpc3BsYXlfbW1pb19vZmZzZXQgaXMgb25seSB1c2Vk IHdoZW4KPiB0aGUgbWFjcm8gaXMgcmVsZXZhbnQgb24gcGxhdGZvcm1zIHdpdGggZGlmZmVyZW50 IG1taW8gb2Zmc2V0cy4gVGhpcyB3ZQo+IHRyeSB0byBmb2xsb3cgY29uc2lzdGVudGx5LgoKU28g eW91IG9ubHkgaGF2ZSBhIHByb2JsZW0gd2hlbiBhIHByZXZpb3VzbHktc3RhdGljYWxseSBsb2Nh dGVkIGJsb2NrCnR1cm5zIGludG8gc29tZXRoaW5nIHRoYXQgY2FuIGJlIChhbmQgaXMpIG1vdmVk IGFyb3VuZCBvbiBkaWZmZXJlbnQKcGxhdGZvcm1zIC4uLiBJIHN1cHBvc2UgdGhhdCBzaG91bGRu J3QgaGFwcGVuIHRvbyBvZnRlbi4KCj4+IFBlcnNvbmFsbHkgSSB0aGluayB0aGUgI2RlZmluZSB3 aXRoIGFuIGltcGxpY2l0IGRlcGVuZGVuY3kgb24gYW4KPj4gb2JqZWN0IGNhbGxlZCAiZGV2X3By aXYiIGlzIHJlYWxseSB1Z2x5IGFuZCB3ZSBzaG91bGQgbW92ZSBhd2F5IGZyb20KPj4gdGhhdCBz dHlsZSByYXRoZXIgdGhhbiBhZGRpbmcgbW9yZSBvZiB0aGVtLCBidXQgdGhhdCdzIGEgbG90IG9m IHdvcmsuCj4gCj4gQWdyZWVkIGluIHByaW5jaXBsZSwgYnV0IEkgdGhpbmsgd2UndmUgbG9zdCB0 aGUgYmF0dGxlLiBJdCdzIHdheSB0b28KPiBtdWNoIGNodXJuLCBhbmQgbWFrZXMgYSBsb3Qgb2Yg Y29kZSByZWFsbHkgdWdseS4gQ29tcGFyZSB0aGVzZToKPiAKPiAJSTkxNV9XUklURShGT09CQVIs IEk5MTVfUkVBRChGT09CQVIpIHwgRk9PQkFSX0VOQUJMRSk7Cj4gCj4gCUk5MTVfV1JJVEUoZGV2 X3ByaXYsIEZPT0JBUihkZXZfcHJpdiksCj4gCQkgICBJOTE1X1JFQUQoZGV2X3ByaXYsIEZPT0JB UihkZXZfcHJpdikpIHwgRk9PQkFSX0VOQUJMRSk7CgpJJ2QgcmF0aGVyIHdyaXRlCgoJdWludDMy X3QgZm9vYmFyID0gSTkxNV9ESVNQX1JFR19SRUFEKGRldl9wcml2LCBGT09CQVIpOwoJSTkxNV9E SVNQX1JFR19XUklURShkZXZfcHJpdiwgZm9vYmFyIHwgRk9PQkFSX0VOQUJMRSk7CgpBbmQgaWYg dGhlcmUgd2VyZSB2ZXJ5IG1hbnkgcGxhY2VzIHdoZXJlIHRoYXQgcmVhZC1tb2RpZnktd3JpdGUg d2FzCnVzZWQsIHdlIGNvdWxkIGRlZmluZSB0aGF0IGFzCgojZGVmaW5lCUk5MTVfRElTUF9SRUdf QklUU0VUKGRldl9wcml2LCByZWcsIGJpdHMpIC4uLgoKT2YgY291cnNlIGl0IHdvdWxkIHJlcXVp cmUgcGVvcGxlIHRvIHVzZSB0aGUgcmlnaHQgbWFjcm8gYWNjb3JkaW5nIHRvCndoZXRoZXIgdGhl IHJlZ2lzdGVyIHdhcyBwYXJ0IG9mIHRoZSBkaXNwbGF5IGJsb2NrLCB0aGUgR1QgYmxvY2ssIG9y Cmhvd2V2ZXIgbWFueSBvdGhlciBhcmVhcyB0aGVyZSBhcmUgdGhhdCBtaWdodCBiZSBpbmRlcGVu ZGVudGx5IHJlbG9jYXRlZAouLi4gYnV0IGl0IG1pZ2h0IGJlIG1vcmUgZnV0dXJlIHByb29mIDop Cgo+IFdlJ2xsIHRyeSB0byBmb2N1cyBvbiBvbmx5IHJlcXVpcmluZyAiZGV2X3ByaXYiIGltcGxp Y2l0bHkgYW5kIG5vdGhpbmcKPiBlbHNlLCBhbmQgd2hlcmUgYSBwYXJhbWV0ZXIgZG9lcyBnZXQg cGFzc2VkLCB3ZSdsbCB0cnkgdG8gbWFrZSBpdAo+ICJkZXZfcHJpdiIgYXMgdGhhdCBwcmV0dHkg bXVjaCBoYXMgdG8gYmUgYXJvdW5kIGFueXdheS4KPiAKPiBCUiwKPiBKYW5pLgoKV2VsbCBJIGd1 ZXNzIHdlJ3JlIHN0dWNrIHdpdGggJ2Rldl9wcml2JyBmb3IgdGhlIGZvcmVzZWVhYmxlIGZ1dHVy ZSA6KAoKSG1tbSAuLi4gd2UgaGF2ZSBxdWl0ZSBhIGJpdCBvZiBjb2RlIHRoYXQgcGFzc2VzICdk ZXYnIGFyb3VuZCByYXRoZXIKdGhhbiBkZXZfcHJpdiwgd2hlcmUgdGhlICh1c3VhbGx5IHN0YXRp YykgY2FsbGVkIGZ1bmN0aW9uIGltbWVkaWF0ZWx5CnVzZXMgaXQgdG8gZGVyaXZlIGRldl9wcml2 LCBhbmQgd2hlcmUgdGhlIG9ubHkgb3RoZXIgdXNlcyBpbiB0aGUgY2FsbGVkCmZ1bmN0aW9uIGFy ZSBpbiBjYWxscyB0byBJTlRFTF9JTkZPKGRldikgYW5kIGl0cyBkZXJpdmF0aXZlcy4gRm9yIGV4 YW1wbGU6CgpzdGF0aWMgaW50IGdldF9jb250ZXh0X3NpemUoc3RydWN0IGRybV9kZXZpY2UgKmRl dikKewogICAgICAgIHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGRldi0+ZGV2 X3ByaXZhdGU7CiAgICAgICAgaW50IHJldDsKICAgICAgICB1MzIgcmVnOwoKICAgICAgICBzd2l0 Y2ggKElOVEVMX0lORk8oZGV2KS0+Z2VuKSB7CiAgICAgICAgY2FzZSA2OgogICAgICAgICAgICAg ICAgcmVnID0gSTkxNV9SRUFEKENYVF9TSVpFKTsKICAgICAgICAgICAgICAgIHJldCA9IEdFTjZf Q1hUX1RPVEFMX1NJWkUocmVnKSAqIDY0OwogICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAg Y2FzZSA3OgogICAgICAgICAgICAgICAgcmVnID0gSTkxNV9SRUFEKEdFTjdfQ1hUX1NJWkUpOwog ICAgICAgICAgICAgICAgaWYgKElTX0hBU1dFTEwoZGV2KSkKICAgICAgICAgICAgICAgICAgICAg ICAgcmV0ID0gSFNXX0NYVF9UT1RBTF9TSVpFOwogICAgICAgICAgICAgICAgZWxzZQogICAgICAg ICAgICAgICAgICAgICAgICByZXQgPSBHRU43X0NYVF9UT1RBTF9TSVpFKHJlZykgKiA2NDsKICAg ICAgICAgICAgICAgIGJyZWFrOwogICAgICAgIGNhc2UgODoKICAgICAgICAgICAgICAgIHJldCA9 IEdFTjhfQ1hUX1RPVEFMX1NJWkU7CiAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICBkZWZh dWx0OgogICAgICAgICAgICAgICAgQlVHKCk7CiAgICAgICAgfQoKICAgICAgICByZXR1cm4gcmV0 Owp9CgpCdXQgc2luY2UgSU5URUxfSU5GTygpIGNhbiB0YWtlICdkZXZfcHJpdicgYXMgYSBwYXJh bWV0ZXIgKGFzIGFuCmFsdGVybmF0aXZlIHRvICdkZXYnKSwgYWxsIHRoZSB1c2VzIG9mICdkZXYn IGhlcmUgY291bGQgYmUgcmVwbGFjZWQgYnkKJ2Rldl9wcml2JyBhbmQgdGhlbiB0aGUgcGFyYW1l dGVyIGNoYW5nZWQgdG8gcGFzcyB0aGF0IGRpcmVjdGx5LCB0aHVzCnBvdGVudGlhbGx5IGVsaW1p bmF0aW5nIHF1aXRlIGEgZmV3IGV4dHJhIG1lbW9yeSByZWZlcmVuY2VzLiBBcHBsaWVkCmRyaXZl ci13aWRlLCB0aGF0IG1pY3JvLW9wdGltaXNhdGlvbiBtaWdodCBhZGQgdXAgdG8gc29tZXRoaW5n IHVzZWZ1bCA6KQoKLkRhdmUuCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50 ZWwtZ2Z4Cg==