From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH v2 12/27] drm/i915: Split plane updates of crtc->atomic into a helper, v2. Date: Thu, 11 Jun 2015 05:44:26 +0200 Message-ID: <5579041A.2050309@linux.intel.com> References: <1433422077-14907-1-git-send-email-maarten.lankhorst@linux.intel.com> <1433422077-14907-13-git-send-email-maarten.lankhorst@linux.intel.com> <20150611013505.GF15024@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 50FBD6E9A5 for ; Wed, 10 Jun 2015 20:44:29 -0700 (PDT) In-Reply-To: <20150611013505.GF15024@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Matt Roper Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T3AgMTEtMDYtMTUgb20gMDM6MzUgc2NocmVlZiBNYXR0IFJvcGVyOgo+IE9uIFRodSwgSnVuIDA0 LCAyMDE1IGF0IDAyOjQ3OjQyUE0gKzAyMDAsIE1hYXJ0ZW4gTGFua2hvcnN0IHdyb3RlOgo+PiBU aGlzIG1ha2VzIGl0IGVhc2llciB0byB2ZXJpZnkgdGhhdCBubyBjaGFuZ2VzIGFyZSBkb25lIHdo ZW4KPj4gY2FsbGluZyB0aGlzIGZyb20gY3J0YyBpbnN0ZWFkLgo+Pgo+PiBDaGFuZ2VzIHNpbmNl IHYxOgo+PiAgLSBNYWtlIGludGVsX3dtX25lZWRfdXBkYXRlIHN0YXRpYyBhbmQgYWx3YXlzIGNo ZWNrIGl0Lgo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5s YW5raG9yc3RAbGludXguaW50ZWwuY29tPgo+IERvIHdlIGV2ZW4gbmVlZCBjcnRjLT5hdG9taWMg YW55bW9yZT8gIFdoZW4gSSBmaXJzdCBhZGRlZCB0aGF0LCBJCj4gZXhwZWN0ZWQgaXQgdG8ganVz dCBiZSBhIHRlbXBvcmFyeSBkdW1waW5nIGdyb3VuZCB1bnRpbCB3ZSBoYWQKPiBjcnRjX3N0YXRl J3MgdHJhY2tlZCBhbmQgc3dhcHBlZCBwcm9wZXJseSAod2hpY2ggd2UgZG8gbm93KS4gIENhbiB3 ZQo+IGp1c3QgbWlncmF0ZSB0aGVzZSBmaWVsZHMgaW50byB0aGUgc3RhdGUgc3RydWN0dXJlIGlu c3RlYWQ/ClRoaXMgaXMgdGVtcG9yYXJpbHksIEkgbmVlZCBmdWxsIGNvbnZlcnNpb24gdG8gYXRv bWljIHRvIGtpbGwgb2ZmIGNydGMtPmF0b21pYy4KCkFmdGVyIHRoYXQgSSBoYXZlIDIgdXBkYXRl IGZ1bmN0aW9ucywgcHJlX3BsYW5lX3VwZGF0ZSBhbmQgcG9zdF9wbGFuZV91cGRhdGUuCgpBbnkg cmVxdWlyZWQgY2hhbmdlcyBjb3VsZCB0aGVuIGJlIGNhbGN1bGF0ZWQgZnJvbSBwbGFuZV9zdGF0 ZS0+dmlzaWJsZSwgb2xkX3BsYW5lX3N0YXRlLT52aXNpYmxlIGFuZCBjcnRjIGVuYWJsZWQvZGlz YWJsZWQuCj4gPHNuaXA+Cj4+ICtpbnQgaW50ZWxfcGxhbmVfYXRvbWljX2NhbGNfY2hhbmdlcyhz dHJ1Y3QgZHJtX2NydGNfc3RhdGUgKmNydGNfc3RhdGUsCj4+ICsJCQkJICAgIHN0cnVjdCBkcm1f cGxhbmVfc3RhdGUgKnBsYW5lX3N0YXRlKQo+PiArewo+PiArCXN0cnVjdCBkcm1fY3J0YyAqY3J0 YyA9IGNydGNfc3RhdGUtPmNydGM7Cj4+ICsJc3RydWN0IGludGVsX2NydGMgKmludGVsX2NydGMg PSB0b19pbnRlbF9jcnRjKGNydGMpOwo+PiArCXN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lID0gcGxh bmVfc3RhdGUtPnBsYW5lOwo+PiArCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBjcnRjLT5kZXY7 Cj4+ICsJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZGV2LT5kZXZfcHJpdmF0 ZTsKPj4gKwlzdHJ1Y3QgaW50ZWxfcGxhbmVfc3RhdGUgKm9sZF9wbGFuZV9zdGF0ZSA9Cj4+ICsJ CXRvX2ludGVsX3BsYW5lX3N0YXRlKHBsYW5lLT5zdGF0ZSk7Cj4+ICsJaW50IGlkeCA9IGludGVs X2NydGMtPmJhc2UuYmFzZS5pZCwgcmV0Owo+PiArCWludCBpID0gZHJtX3BsYW5lX2luZGV4KHBs YW5lKTsKPj4gKwlib29sIG1vZGVfY2hhbmdlZCA9IG5lZWRzX21vZGVzZXQoY3J0Y19zdGF0ZSk7 Cj4+ICsJYm9vbCB3YXNfY3J0Y19lbmFibGVkID0gY3J0Yy0+c3RhdGUtPmFjdGl2ZTsKPj4gKwli b29sIGlzX2NydGNfZW5hYmxlZCA9IGNydGNfc3RhdGUtPmFjdGl2ZTsKPj4gKwo+PiArCWJvb2wg dHVybl9vZmYsIHR1cm5fb24sIHZpc2libGUsIHdhc192aXNpYmxlOwo+PiArCXN0cnVjdCBkcm1f ZnJhbWVidWZmZXIgKmZiID0gcGxhbmVfc3RhdGUtPmZiOwo+PiArCj4+ICsJaWYgKGNydGNfc3Rh dGUgJiYgSU5URUxfSU5GTyhkZXYpLT5nZW4gPj0gOSAmJgo+PiArCSAgICBwbGFuZS0+dHlwZSAh PSBEUk1fUExBTkVfVFlQRV9DVVJTT1IpIHsKPj4gKwkJcmV0ID0gc2tsX3VwZGF0ZV9zY2FsZXJf cGxhbmUoCj4+ICsJCQl0b19pbnRlbF9jcnRjX3N0YXRlKGNydGNfc3RhdGUpLAo+PiArCQkJdG9f aW50ZWxfcGxhbmVfc3RhdGUocGxhbmVfc3RhdGUpKTsKPj4gKwkJaWYgKHJldCkKPj4gKwkJCXJl dHVybiByZXQ7Cj4+ICsJfQo+PiArCj4+ICsJLyoKPj4gKwkgKiBEaXNhYmxpbmcgYSBwbGFuZSBp cyBhbHdheXMgb2theTsgd2UganVzdCBuZWVkIHRvIHVwZGF0ZQo+PiArCSAqIGZiIHRyYWNraW5n IGluIGEgc3BlY2lhbCB3YXkgc2luY2UgY2xlYW51cF9mYigpIHdvbid0Cj4+ICsJICogZ2V0IGNh bGxlZCBieSB0aGUgcGxhbmUgaGVscGVycy4KPj4gKwkgKi8KPj4gKwlpZiAob2xkX3BsYW5lX3N0 YXRlLT5iYXNlLmZiICYmICFmYikKPj4gKwkJaW50ZWxfY3J0Yy0+YXRvbWljLmRpc2FibGVkX3Bs YW5lcyB8PSAxIDw8IGk7Cj4+ICsKPj4gKwkvKiBkb24ndCBydW4gcmVzdCBkdXJpbmcgbW9kZXNl dCB5ZXQgKi8KPj4gKwlpZiAoIWludGVsX2NydGMtPmFjdGl2ZSB8fCBtb2RlX2NoYW5nZWQpCj4+ ICsJCXJldHVybiAwOwo+PiArCj4+ICsJd2FzX3Zpc2libGUgPSBvbGRfcGxhbmVfc3RhdGUtPnZp c2libGU7Cj4+ICsJdmlzaWJsZSA9IHRvX2ludGVsX3BsYW5lX3N0YXRlKHBsYW5lX3N0YXRlKS0+ dmlzaWJsZTsKPj4gKwo+PiArCWlmICghd2FzX2NydGNfZW5hYmxlZCAmJiBXQVJOX09OKHdhc192 aXNpYmxlKSkKPj4gKwkJd2FzX3Zpc2libGUgPSBmYWxzZTsKPj4gKwo+PiArCWlmICghaXNfY3J0 Y19lbmFibGVkICYmIFdBUk5fT04odmlzaWJsZSkpCj4+ICsJCXZpc2libGUgPSBmYWxzZTsKPj4g Kwo+PiArCWlmICghd2FzX3Zpc2libGUgJiYgIXZpc2libGUpCj4+ICsJCXJldHVybiAwOwo+PiAr Cj4+ICsJdHVybl9vZmYgPSB3YXNfdmlzaWJsZSAmJiAoIXZpc2libGUgfHwgbW9kZV9jaGFuZ2Vk KTsKPj4gKwl0dXJuX29uID0gdmlzaWJsZSAmJiAoIXdhc192aXNpYmxlIHx8IG1vZGVfY2hhbmdl ZCk7Cj4+ICsKPj4gKwlEUk1fREVCVUdfQVRPTUlDKCJbQ1JUQzolaV0gaGFzIFtQTEFORTolaV0g d2l0aCBmYiAlaVxuIiwgaWR4LAo+PiArCQkJIHBsYW5lLT5iYXNlLmlkLCBmYiA/IGZiLT5iYXNl LmlkIDogLTEpOwo+PiArCj4+ICsJRFJNX0RFQlVHX0FUT01JQygiW1BMQU5FOiVpXSB2aXNpYmxl ICVpIC0+ICVpLCBvZmYgJWksIG9uICVpLCBtcyAlaVxuIiwKPj4gKwkJCSBwbGFuZS0+YmFzZS5p ZCwgd2FzX3Zpc2libGUsIHZpc2libGUsCj4+ICsJCQkgdHVybl9vZmYsIHR1cm5fb24sIG1vZGVf Y2hhbmdlZCk7Cj4+ICsKPj4gKwlpZiAoaW50ZWxfd21fbmVlZF91cGRhdGUocGxhbmUsIHBsYW5l X3N0YXRlKSkKPj4gKwkJaW50ZWxfY3J0Yy0+YXRvbWljLnVwZGF0ZV93bSA9IHRydWU7Cj4gSG1t LCBJIHJlYWxpemUgdGhpcyBpcyB0aGUgd2F5IHRoZSBjb2RlIGFscmVhZHkgd29ya2VkLCBidXQg dGhpcyBpcyBvbmx5Cj4gZ29pbmcgdG8gdHJpZ2dlciB1cGRhdGVfd2F0ZXJtYXJrcyByYXRoZXIg dGhhbiB1cGRhdGVfc3ByaXRlX3dhdGVybWFya3MsCj4gd2hpY2ggb24gc29tZSBwbGF0Zm9ybXMg Y291bGQgbWFrZSB1cyB1cGRhdGUgd2F0ZXJtYXJrcyB3aXRoIHN0YWxlCj4gc3ByaXRlIHZhbHVl cy4gIEkgdGhpbmsgdGhlIG9ubHkgcmVhc29uIHdlIGdldCBhd2F5IHdpdGggdGhpcyB0b2RheSBp cwo+IGJlY2F1c2Ugd2UgYWN0dWFsbHkgcGVyZm9ybSBzcHJpdGUgd2F0ZXJtYXJrIHVwZGF0ZXMg aW4gdGhlIGxvdy1sZXZlbAo+IHBsYW5lIHVwZGF0ZSBmdW5jdGlvbnMgKHdoaWNoIGlzIGJhZCBz aW5jZSB3ZSdyZSB1bmRlciB2YmxhbmsKPiBldmFzaW9uLi4uKS4gIEkgaGFkIHNvbWUgcGF0Y2hl cyB0aGF0IGZpeGVkIHRoYXQgb3ZlcnNpZ2h0IGFzIHBhcnQgb2YgbXkKPiB3YXRlcm1hcmsgUkZD IHNlcmllcywgYnV0IHRoZXkgaGF2ZW4ndCBnb25lIGluOyBJIHByb2JhYmx5IG5lZWQgdG8KPiBl eHRyYWN0IHRoZSBmaXggZnJvbSB0aGUgcmVzdCBvZiB0aGUgUkZDLgo+Cj4gTm90IHN1cmUgaWYg eW91IHdhbnQgdG8gd29ycnkgYWJvdXQgaXQgYXMgcGFydCBvZiB5b3VyIHdvcmsgaGVyZSBvciBu b3QKPiBzaW5jZSB0aGlzIGRvZXNuJ3QgbGVhdmUgdXMgYW55IHdvcnNlIG9mZiB0aGFuIHdlIGFs cmVhZHkgYXJlIHRvZGF5Owo+IGp1c3QgZmlndXJlZCBJJ2QgbWVudGlvbiBpdCBzbyB3ZSBkb24n dCBmb3JnZXQgYWJvdXQgaXQuCj4KWWVhaCwgSSBvbmx5IHdhbnRlZCB0byBwcmVzZXJ2ZSBjdXJy ZW50IGJlaGF2aW9yIGluIHRoaXMgY29tbWl0LCBzbyBpdCBiZWNvbWVzIG1vcmUgY2xlYXIgd2h5 IGl0IGhhcHBlbnMuCgp+TWFhcnRlbgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2ludGVsLWdmeAo=