From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Gordon Subject: Re: [PATCH 2/2] drm/i915: Rework order of operations in {__intel, logical}_ring_prepare() Date: Fri, 12 Jun 2015 19:54:17 +0100 Message-ID: <557B2AD9.40105@intel.com> References: <1433789441-8295-1-git-send-email-david.s.gordon@intel.com> <1434128948-9221-1-git-send-email-david.s.gordon@intel.com> <1434128948-9221-3-git-send-email-david.s.gordon@intel.com> <20150612180542.GM28462@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id 280BE6E1BB for ; Fri, 12 Jun 2015 11:54:19 -0700 (PDT) In-Reply-To: <20150612180542.GM28462@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMTIvMDYvMTUgMTk6MDUsIENocmlzIFdpbHNvbiB3cm90ZToKPiBPbiBGcmksIEp1biAxMiwg MjAxNSBhdCAwNjowOTowOFBNICswMTAwLCBEYXZlIEdvcmRvbiB3cm90ZToKPj4gVGhlIG9yaWdp bmFsIGlkZWEgb2YgcHJlYWxsb2NhdGluZyB0aGUgT0xSIHdhcyBpbXBsZW1lbnRlZCBpbgo+Pgo+ Pj4gOWQ3NzMwOTEgZHJtL2k5MTU6IFByZWFsbG9jYXRlIG5leHQgc2Vxbm8gYmVmb3JlIHRvdWNo aW5nIHRoZSByaW5nCj4+Cj4+IGFuZCB0aGUgc2VxdWVuY2Ugb2Ygb3BlcmF0aW9ucyB3YXMgdG8g YWxsb2NhdGUgdGhlIE9MUiwgdGhlbiB3cmFwIHBhc3QKPj4gdGhlIGVuZCBvZiB0aGUgcmluZyBp ZiBuZWNlc3NhcnksIHRoZW4gd2FpdCBmb3Igc3BhY2UgaWYgbmVjZXNzYXJ5Lgo+PiBCdXQgc3Vi c2VxdWVudGx5IGludGVsX3JpbmdfYmVnaW4oKSB3YXMgcmVmYWN0b3JlZCwgaW4KPj4KPj4+IDMw NGQ2OTUgZHJtL2k5MTU6IEZsdXNoIG91dHN0YW5kaW5nIHJlcXVlc3RzIGJlZm9yZSBhbGxvY2F0 aW5nIG5ldyBzZXFubwo+Pgo+PiB0byBlbnN1cmUgdGhhdCBwZW5kaW5nIHdvcmsgdGhhdCBtaWdo dCBuZWVkIHRvIGJlIGZsdXNoZWQgdXNlZCB0aGUgb2xkCj4+IGFuZCBub3QgdGhlIG5ld2x5LWFs bG9jYXRlZCByZXF1ZXN0LiBUaGlzIGNoYW5nZWQgdGhlIHNlcXVlbmNlIHRvIHdyYXAKPj4gYW5k L29yIHdhaXQsIHRoZW4gYWxsb2NhdGUsIGFsdGhvdWdoIHRoZSBjb21tZW50IHN0aWxsIHNhaWQK Pj4gCS8qIFByZWFsbG9jYXRlIHRoZSBvbHIgYmVmb3JlIHRvdWNoaW5nIHRoZSByaW5nICovCj4+ IHdoaWNoIHdhcyBubyBsb25nZXIgdHJ1ZSBhcyBpbnRlbF93cmFwX3JpbmdfYnVmZmVyKCkgdG91 Y2hlcyB0aGUgcmluZy4KPj4KPj4gSG93ZXZlciwgd2l0aCB0aGUgaW50cm9kdWN0aW9uIG9mIGR5 bmFtaWMgcGlubmluZywgaW4KPj4KPj4+IDdiYTcxN2MgZHJtL2k5MTUvYmR3OiBQaW4gdGhlIHJp bmdidWZmZXIgYmFja2luZyBvYmplY3QgdG8gR0dUVCBvbi1kZW1hbmQKPj4KPj4gY2FtZSB0aGUg cG9zc2liaWxpdHkgdGhhdCB0aGUgcmluZ2J1ZmZlciBtaWdodCBub3QgYmUgcGlubmVkIHRvIHRo ZSBHVFQKPj4gb3IgbWFwcGVkIGludG8gQ1BVIGFkZHJlc3Mgc3BhY2Ugd2hlbiBpbnRlbF9yaW5n X2JlZ2luKCkgaXMgY2FsbGVkLiBJdAo+PiBnZXRzIHBpbm5lZCB3aGVuIHRoZSByZXF1ZXN0IGlz IGFsbG9jYXRlZCwgc28gaXQncyBub3cgaW1wb3J0YW50IHRoYXQKPj4gdGhpcyBjb21lcyAqYmVm b3JlKiBhbnl0aGluZyB0aGF0IGNhbiB3cml0ZSBpbnRvIHRoZSByaW5nYnVmZmVyLCBpbiB0aGlz Cj4+IGNhc2UgaW50ZWxfd3JhcF9yaW5nX2J1ZmZlcigpLCBhcyB0aGlzIHdpbGwgZmF1bHQgaWYg KGEpIHRoZSByaW5nYnVmZmVyCj4+IGhhcHBlbnMgbm90IHRvIGJlIG1hcHBlZCwgYW5kIChiKSB0 YWlsIGhhcHBlbnMgdG8gYmUgc3VmZmljaWVudGx5IGNsb3NlCj4+IHRvIHRoZSBlbmQgb2YgdGhl IHJpbmcgdG8gdHJpZ2dlciB3cmFwcGluZy4KPiAKPiBPbiB0aGUgb3RoZXIgaGFuZCwgdGhlIHJl cXVlc3QgYWxsb2NhdGlvbiBjYW4gaXRzZWxmIHdyaXRlIGludG8gdGhlCj4gcmluZy4gVGhpcyBp cyBub3QgdGhlIHJpZ2h0IGZpeCwgdGhhdCBpcyB0aGUgZWxpbWluYXRpb24gb2Ygb2xyIGl0c2Vs Zgo+IGFuZCBwYXNzaW5nIHRoZSByZXF1ZXN0IGludG8gaW50ZWxfcmluZ19iZWdpbi4gVGhhdCB3 YXkgd2UgY2FuIGV4cGxpY2l0Cj4gaW4gb3VyIG9yZGVyaW5nIGludG8gcmluZyBhY2Nlc3MuCj4g LUNocmlzCgpBRkFJQ1MsIHJlcXVlc3QgYWxsb2NhdGlvbiBjYW4gd3JpdGUgaW50byB0aGUgcmlu ZyBvbmx5IGlmIGl0IGFjdHVhbGx5CmhhcyB0byBmbHVzaCBzb21lICpwcmUtZXhpc3RpbmcqIE9M Ui4gW0FzaWRlOiBpdCBjYW4gYWN0dWFsbHkgdHJpZ2dlcgp3cml0aW5nIGludG8gYSBjb21wbGV0 ZWx5IGRpZmZlcmVudCByaW5nYnVmZmVyLCBidXQgbm90IHRoZSBvbmUgd2UncmUKaGFuZGxpbmcg aGVyZSFdIFRoZSB3b3JzdC1jYXNlIHNlcXVlbmNlIGlzOgoKCWk5MTVfZ2VtX3JlcXVlc3RfYWxs b2MJCWZpbmRzIHRoZXJlJ3Mgbm8gT0xSCgkgIGk5MTVfZ2VtX2dldF9zZXFubwkJICBmaW5kcyB0 aGUgc2Vxbm8gaXMgMAoJICAgIGk5MTVfZ2VtX2luaXRfc2Vxbm8JCSAgICBmb3JfZWFzaF9yaW5n IGRvIC4uLgoJICAgICAgaW50ZWxfcmluZ19pZGxlCQkgICAgICBidXQgbm8gT0xSLCBzbyBPSwoK SXQgb25seSB3b3JrcyBiZWNhdXNlIGk5MTVfZ2VtX3JlcXVlc3RfYWxsb2MoKSBhbGxvY2F0ZXMg dGhlIHJlcXVlc3QKZWFybHkgYnV0IGRvZXNuJ3Qgc3RvcmUgaXQgaW4gdGhlIE9MUiB1bnRpbCB0 aGUgZW5kLgoKT1RPSCBJIGFncmVlIHRoYXQgdGhlIGxvbmctdGVybSBhbnN3ZXIgaXMgdGhlIGVs aW1pbmF0aW9uIG9mIHRoZSBPTFI7CnRoaXMgaXMgcmVhbGx5IHNvbWV0aGluZyBvZiBhIHN0b3Bn YXAgdW50aWwgSm9obiBIJ3MgQW50aS1PTFIgcGF0Y2hzZXQKaXMgbWVyZ2VkLgoKQWx0aG91Z2gs IHRoZSBzaW1wbGlmaWNhdGlvbiBvZiB0aGUgd2FpdC13cmFwL3dhaXQtc3BhY2Ugc2VxdWVuY2Ug aXMKcHJvYmFibHkgd29ydGh3aGlsZSBpbiBpdHMgb3duIHJpZ2h0LCBzbyBpZiBBbnRpLU9MUiBn ZXRzIG1lcmdlZCBmaXJzdAp3ZSBjYW4gcHV0IHRoZSByZXN0IG9mIHRoZSBjaGFuZ2VzIG9uIHRv cCBvZiB0aGF0LiBJdCdzIG9ubHkgY29kZSBpbnNpZGUKdGhlICJpZighT0xSKSIgc2VjdGlvbiB0 aGF0IHdvdWxkIG5lZWQgdG8gYmUgcmVtb3ZlZC4KCi5EYXZlLgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVs LWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=