Re: [PATCH] Antigcc bitfield bikeshed

Jesse Barnes
2015-06-22T21:19:37Z

On 06/17/2015 08:10 AM, Daniel Vetter wrote:
> On Wed, Jun 17, 2015 at 05:28:20PM +0300, Jani Nikula wrote:
>> On Wed, 17 Jun 2015, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>>> Here's an idea I want to float to see if anyone has a better idea.
>>
>> I'll give it some thought, but it pains me that things like this make it
>> harder for source code cross referencers and even grep to find what you
>> you're looking for.
>
> The minimal thing we've tossed around on irc (and we only need minimal
> since there's just a few places that need the raw flags field) is to
> hardcode the offsets and check them at runtime ...

This one scares me a lot too; is there a thread on the memory ordering
macros somewhere I can look at? The ordering constraints on x86 are
pretty specific... if we need to annotate things in the code somehow
that could be a plus (generally every *mb() should have a fat comment
explaining the issue), but this seems like overkill at first glance.

Jesse