* [PATCH] sna: Correct misspelled cacheing->caching in comments
@ 2015-06-23 5:45 Sedat Dilek
2015-06-24 10:04 ` Chris Wilson
0 siblings, 1 reply; 4+ messages in thread
From: Sedat Dilek @ 2015-06-23 5:45 UTC (permalink / raw)
To: Chris Wilson, intel-gfx; +Cc: Sedat Dilek
I have seen this typo once and added an entry to codespell's dictionary.txt file.
$ diff -uprN /usr/share/codespell/dictionary.txt.orig /usr/share/codespell/dictionary.txt
--- /usr/share/codespell/dictionary.txt.orig 2015-06-09 20:49:25.000000000 +0200
+++ /usr/share/codespell/dictionary.txt 2015-06-23 07:37:35.893689539 +0200
@@ -625,6 +625,7 @@ burried->buried
busineses->business, businesses,
busness->business
bussiness->business
+cacheing->caching
caculater->calculator
cacuses->caucuses
cahracters->characters
There some other places where this typo occurs:
[ src/sna/kgem.c ]
298:static void assert_cacheing(struct kgem *kgem, struct kgem_bo *bo)
324:#define assert_cacheing(kgem, bo)
2455: assert_cacheing(kgem, bo);
2841: assert_cacheing(kgem, bo);
It's up to Chris what to do with this.
Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
---
src/sna/sna_dri2.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/sna/sna_dri2.c b/src/sna/sna_dri2.c
index 2cde0c6aa0dc..2a1f8475b735 100644
--- a/src/sna/sna_dri2.c
+++ b/src/sna/sna_dri2.c
@@ -228,7 +228,7 @@ sna_dri2_cache_bo(struct sna *sna,
if (!c)
goto err;
- DBG(("%s: cacheing handle=%d (name=%d, flags=%d, active_scanout=%d)\n", __FUNCTION__, bo->handle, name, flags, bo->active_scanout));
+ DBG(("%s: caching handle=%d (name=%d, flags=%d, active_scanout=%d)\n", __FUNCTION__, bo->handle, name, flags, bo->active_scanout));
c->bo = bo;
c->name = name;
@@ -333,7 +333,7 @@ sna_dri2_get_back(struct sna *sna,
c->name = back->name;
c->flags = back->flags;
list_add(&c->link, &priv->cache);
- DBG(("%s: cacheing handle=%d (name=%d, flags=%d, active_scanout=%d)\n", __FUNCTION__, c->bo->handle, c->name, c->flags, c->bo->active_scanout));
+ DBG(("%s: caching handle=%d (name=%d, flags=%d, active_scanout=%d)\n", __FUNCTION__, c->bo->handle, c->name, c->flags, c->bo->active_scanout));
}
} else {
if (&c->link != &priv->cache)
--
2.4.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] sna: Correct misspelled cacheing->caching in comments
2015-06-23 5:45 [PATCH] sna: Correct misspelled cacheing->caching in comments Sedat Dilek
@ 2015-06-24 10:04 ` Chris Wilson
2015-06-26 14:51 ` Dave Gordon
2015-07-02 7:26 ` Sedat Dilek
0 siblings, 2 replies; 4+ messages in thread
From: Chris Wilson @ 2015-06-24 10:04 UTC (permalink / raw)
To: Sedat Dilek; +Cc: intel-gfx
On Tue, Jun 23, 2015 at 07:45:42AM +0200, Sedat Dilek wrote:
> I have seen this typo once and added an entry to codespell's dictionary.txt file.
>
> $ diff -uprN /usr/share/codespell/dictionary.txt.orig /usr/share/codespell/dictionary.txt
> --- /usr/share/codespell/dictionary.txt.orig 2015-06-09 20:49:25.000000000 +0200
> +++ /usr/share/codespell/dictionary.txt 2015-06-23 07:37:35.893689539 +0200
> @@ -625,6 +625,7 @@ burried->buried
> busineses->business, businesses,
> busness->business
> bussiness->business
> +cacheing->caching
> caculater->calculator
> cacuses->caucuses
> cahracters->characters
>
> There some other places where this typo occurs:
>
> [ src/sna/kgem.c ]
>
> 298:static void assert_cacheing(struct kgem *kgem, struct kgem_bo *bo)
> 324:#define assert_cacheing(kgem, bo)
> 2455: assert_cacheing(kgem, bo);
> 2841: assert_cacheing(kgem, bo);
>
> It's up to Chris what to do with this.
I just can't get paste reading 'caching' as two hard Cs and so it feels
weird.
commit f414ed4e40292e91e9c6850fb01a26334e6b43c7
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date: Wed Jun 24 11:02:28 2015 +0100
sna: Fix misspelling of "caching"
Apply s/cacheing/caching/ because I am alone in my belief of how to
spell cacheing correctly :)
Suggested-by: Sedat Dilek <sedat.dilek@gmail.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Thanks,
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] sna: Correct misspelled cacheing->caching in comments
2015-06-24 10:04 ` Chris Wilson
@ 2015-06-26 14:51 ` Dave Gordon
2015-07-02 7:26 ` Sedat Dilek
1 sibling, 0 replies; 4+ messages in thread
From: Dave Gordon @ 2015-06-26 14:51 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
On 24/06/15 11:04, Chris Wilson wrote:
> On Tue, Jun 23, 2015 at 07:45:42AM +0200, Sedat Dilek wrote:
>> I have seen this typo once and added an entry to codespell's dictionary.txt file.
>>
>> $ diff -uprN /usr/share/codespell/dictionary.txt.orig /usr/share/codespell/dictionary.txt
>> --- /usr/share/codespell/dictionary.txt.orig 2015-06-09 20:49:25.000000000 +0200
>> +++ /usr/share/codespell/dictionary.txt 2015-06-23 07:37:35.893689539 +0200
>> @@ -625,6 +625,7 @@ burried->buried
>> busineses->business, businesses,
>> busness->business
>> bussiness->business
>> +cacheing->caching
>> caculater->calculator
>> cacuses->caucuses
>> cahracters->characters
>>
>> There some other places where this typo occurs:
>>
>> [ src/sna/kgem.c ]
>>
>> 298:static void assert_cacheing(struct kgem *kgem, struct kgem_bo *bo)
>> 324:#define assert_cacheing(kgem, bo)
>> 2455: assert_cacheing(kgem, bo);
>> 2841: assert_cacheing(kgem, bo);
>>
>> It's up to Chris what to do with this.
>
> I just can't get past reading 'caching' as two hard Cs and so it feels
> weird.
That would be Italian. Cache (and "cachet") come from French "cacher"
(to hide), so the "ch" is (almost) the same as in "chef" or "chauffeur".
We could switch to using the Esperanto spelling, "kaŝi" and the
corresponding hardware term "kaŝmemoro" :)
.Dave.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] sna: Correct misspelled cacheing->caching in comments
2015-06-24 10:04 ` Chris Wilson
2015-06-26 14:51 ` Dave Gordon
@ 2015-07-02 7:26 ` Sedat Dilek
1 sibling, 0 replies; 4+ messages in thread
From: Sedat Dilek @ 2015-07-02 7:26 UTC (permalink / raw)
To: Chris Wilson, Sedat Dilek, intel-gfx
On Wed, Jun 24, 2015 at 12:04 PM, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Tue, Jun 23, 2015 at 07:45:42AM +0200, Sedat Dilek wrote:
>> I have seen this typo once and added an entry to codespell's dictionary.txt file.
>>
>> $ diff -uprN /usr/share/codespell/dictionary.txt.orig /usr/share/codespell/dictionary.txt
>> --- /usr/share/codespell/dictionary.txt.orig 2015-06-09 20:49:25.000000000 +0200
>> +++ /usr/share/codespell/dictionary.txt 2015-06-23 07:37:35.893689539 +0200
>> @@ -625,6 +625,7 @@ burried->buried
>> busineses->business, businesses,
>> busness->business
>> bussiness->business
>> +cacheing->caching
>> caculater->calculator
>> cacuses->caucuses
>> cahracters->characters
>>
>> There some other places where this typo occurs:
>>
>> [ src/sna/kgem.c ]
>>
>> 298:static void assert_cacheing(struct kgem *kgem, struct kgem_bo *bo)
>> 324:#define assert_cacheing(kgem, bo)
>> 2455: assert_cacheing(kgem, bo);
>> 2841: assert_cacheing(kgem, bo);
>>
>> It's up to Chris what to do with this.
>
> I just can't get paste reading 'caching' as two hard Cs and so it feels
> weird.
>
> commit f414ed4e40292e91e9c6850fb01a26334e6b43c7
> Author: Chris Wilson <chris@chris-wilson.co.uk>
> Date: Wed Jun 24 11:02:28 2015 +0100
>
> sna: Fix misspelling of "caching"
>
> Apply s/cacheing/caching/ because I am alone in my belief of how to
> spell cacheing correctly :)
>
> Suggested-by: Sedat Dilek <sedat.dilek@gmail.com>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>
Thanks.
Just FYI... codespell got it, now.
commit b003c6167fdf441d2ba89534d402015723b66560
"Add misspelled cacheing->caching"
- sed@ -
[1] https://github.com/lucasdemarchi/codespell/commit/b003c6167fdf441d2ba89534d402015723b66560
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-07-02 7:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-23 5:45 [PATCH] sna: Correct misspelled cacheing->caching in comments Sedat Dilek
2015-06-24 10:04 ` Chris Wilson
2015-06-26 14:51 ` Dave Gordon
2015-07-02 7:26 ` Sedat Dilek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox