From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Gordon Subject: Re: [PATCH] drm/i915: Preallocate request before access of the ring Date: Mon, 29 Jun 2015 14:57:57 +0100 Message-ID: <55914EE5.1060300@intel.com> References: <1430323845-28906-1-git-send-email-yu.dai@intel.com> <55422611.7030902@intel.com> <20150506100603.GN30184@phenom.ffwll.local> <87pp4eyc97.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 9C6E96E8CF for ; Mon, 29 Jun 2015 06:57:59 -0700 (PDT) In-Reply-To: <87pp4eyc97.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula , Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMjkvMDYvMTUgMTI6MzksIEphbmkgTmlrdWxhIHdyb3RlOgo+IE9uIFdlZCwgMDYgTWF5IDIw MTUsIERhbmllbCBWZXR0ZXIgPGRhbmllbEBmZndsbC5jaD4gd3JvdGU6Cj4+IE9uIFRodSwgQXBy IDMwLCAyMDE1IGF0IDAxOjU0OjQxUE0gKzAxMDAsIERhdmUgR29yZG9uIHdyb3RlOgo+Pj4gT24g MjkvMDQvMTUgMTc6MTAsIHl1LmRhaUBpbnRlbC5jb20gd3JvdGU6Cj4+Pj4gRnJvbTogQWxleCBE YWkgPHl1LmRhaUBpbnRlbC5jb20+Cj4+Pj4KPj4+PiBUaGlzIGlzIHRvIGF2b2lkIGJhZCBJTyBh Y2Nlc3MgY2F1c2VkIGJ5IHdyaXRpbmcgTk9PUCB0byB3cmFwIHRoZQo+Pj4+IHJpbmcgYnVmZmVy IHdoaWxzdCByaW5nIGlzIHVucGlubmVkLgo+Pj4+Cj4+Pj4gU2lnbmVkLW9mZi1ieTogQWxleCBE YWkgPHl1LmRhaUBpbnRlbC5jb20+Cj4+Pj4gLS0tCj4+Pj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2xyYy5jIHwgNiArKystLS0KPj4+PiAgMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9u cygrKSwgMyBkZWxldGlvbnMoLSkKPj4+Pgo+Pj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9scmMuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jCj4+ Pj4gaW5kZXggNzMyZmQ2My4uM2U4ZmNmZCAxMDA2NDQKPj4+PiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9scmMuYwo+Pj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2xyYy5jCj4+Pj4gQEAgLTgwMywxMiArODAzLDEyIEBAIHN0YXRpYyBpbnQgaW50ZWxfbG9naWNh bF9yaW5nX2JlZ2luKHN0cnVjdCBpbnRlbF9yaW5nYnVmZmVyICpyaW5nYnVmLAo+Pj4+ICAJaWYg KHJldCkKPj4+PiAgCQlyZXR1cm4gcmV0Owo+Pj4+ICAKPj4+PiAtCXJldCA9IGxvZ2ljYWxfcmlu Z19wcmVwYXJlKHJpbmdidWYsIGN0eCwgbnVtX2R3b3JkcyAqIHNpemVvZih1aW50MzJfdCkpOwo+ Pj4+ICsJLyogUHJlYWxsb2NhdGUgdGhlIG9sciBiZWZvcmUgdG91Y2hpbmcgdGhlIHJpbmcgKi8K Pj4+PiArCXJldCA9IGk5MTVfZ2VtX3JlcXVlc3RfYWxsb2MocmluZywgY3R4KTsKPj4+PiAgCWlm IChyZXQpCj4+Pj4gIAkJcmV0dXJuIHJldDsKPj4+PiAgCj4+Pj4gLQkvKiBQcmVhbGxvY2F0ZSB0 aGUgb2xyIGJlZm9yZSB0b3VjaGluZyB0aGUgcmluZyAqLwo+Pj4+IC0JcmV0ID0gaTkxNV9nZW1f cmVxdWVzdF9hbGxvYyhyaW5nLCBjdHgpOwo+Pj4+ICsJcmV0ID0gbG9naWNhbF9yaW5nX3ByZXBh cmUocmluZ2J1ZiwgY3R4LCBudW1fZHdvcmRzICogc2l6ZW9mKHVpbnQzMl90KSk7Cj4+Pj4gIAlp ZiAocmV0KQo+Pj4+ICAJCXJldHVybiByZXQ7Cj4+Pgo+Pj4gUmV2aWV3ZWQtYnk6IERhdmUgR29y ZG9uIDxkYXZpZC5zLmdvcmRvbkBpbnRlbC5jb20+Cj4+PiB3aXRoIGlucHV0IGFsc28gZnJvbSBK b2huIEhhcnJpc29uIDxqb2huLmMuaGFycmlzb25AaW50ZWwuY29tPiwgd2hvCj4+PiB3b3VsZCBs aWtlIHRvIHBvaW50IG91dCB0aGF0IHRoaXMgd2lsbCBiZSBzdXBlcmNlZGVkIGJ5IHRoZSBBbnRp LU9MUgo+Pj4gcGF0Y2hlcyBhbHJlYWR5IHBvc3RlZC4gKEluIHRoYXQgbW9kZWwsIHRoZSByZXF1 ZXN0IHdpbGwgYmUgYWxsb2NhdGVkCj4+PiBtdWNoIGVhcmxpZXIsIGFuZCBwYXNzZWQgYXJvdW5k IGV4cGxpY2l0bHkgcmF0aGVyIHRoYW4gZGFuZ2xpbmcgZnJvbSB0aGUKPj4+IGNvbnRleHQpLgo+ Pgo+PiBEbyB3ZSBuZWVkIHRoaXMgZm9yIGV4ZWNsaXN0IGluIGdlbmVyYWwsIGkuZS4gY2M6IHN0 YWJsZT8gV2hlcmUncyB0aGUgYnVnCj4+IHJlcG9ydC9pZ3QgdGVzdGNhc2U/Cj4+Cj4+IEZvciBz ZXJpb3VzLWxvb2tpbmcgYnVncyBwbGVhc2UgYWRkIG1vcmUgZGV0YWlscyBsaWtlIHRoYXQgdG8g dGhlIGNvbW1pdAo+PiBtZXNzYWdlLCBvdGhlcndpc2UgbWFpbnRhaW5lcnMgaGF2ZSBubyBpZGVh IHdoZXJlIHRvIGFwcGx5IGEgcGF0Y2guCj4gCj4gQW5kIGR1ZSB0byBubyByZXBseSwgdGhlIG1h aW50YWluZXJzIGhhdmUgZm9yZ290dGVuIGFib3V0IHBhdGNoZXMgbGlrZQo+IHRoaXMuIERyb3Bw aW5nIGZyb20gbXkgZml4ZXMgcXVldWUuCj4gCj4gQlIsCj4gSmFuaS4KClRoaXMgYmVjYW1lIG9i c29sZXRlIHdpdGggdGhlIG1lcmdlIG9mIEpvaG4gSGFycmlzb24ncyBwYXRjaHNldAoJIlJlbW92 ZSB0aGUgb3V0c3RhbmRpbmdfbGF6eV9yZXF1ZXN0IgoKLkRhdmUuCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50 ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==