From: Michel Thierry <michel.thierry@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2 i-g-t v2] lib: Add 64-bit version of igt_assert_cmp
Date: Tue, 30 Jun 2015 14:56:59 +0100 [thread overview]
Message-ID: <5592A02B.7010000@intel.com> (raw)
In-Reply-To: <20150630134906.GU1381@nuc-i3427.alporthouse.com>
On 6/30/2015 2:49 PM, Chris Wilson wrote:
> On Tue, Jun 30, 2015 at 02:41:08PM +0100, Michel Thierry wrote:
>> igt_assert_cmp64 and its derivatives:
>>
>> +#define INTDECFORMAT "%d"
>> +#define UINTHEXFORMAT "%#x"
>> +#define DOUBLEDECFORMAT "%#lf"
>> +#define LONGHEXFORMAT "%#llx"
>
> Any particular reason? Passing in "%d" or %d would have worked just as
> well, right?
Not really, these defines are not needed. The format specifier can be
passed directly.
>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> -Chris
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2015-06-30 13:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-30 13:41 [PATCH 1/2 i-g-t v2] lib: Add 64-bit version of igt_assert_cmp Michel Thierry
2015-06-30 13:41 ` [PATCH 2/2 i-g-t] lib/igt.cocci: Add 64-bit and float compare functions Michel Thierry
2015-06-30 13:54 ` Chris Wilson
2015-06-30 14:08 ` Michel Thierry
2015-06-30 14:43 ` Chris Wilson
2015-06-30 14:14 ` Paulo Zanoni
2015-07-01 13:02 ` Daniel Vetter
2015-07-03 9:23 ` Dave Gordon
2015-07-03 16:52 ` Paulo Zanoni
2015-07-06 7:48 ` Daniel Vetter
2015-07-07 16:33 ` Thomas Wood
2015-06-30 14:04 ` Paulo Zanoni
2015-06-30 13:49 ` [PATCH 1/2 i-g-t v2] lib: Add 64-bit version of igt_assert_cmp Chris Wilson
2015-06-30 13:56 ` Michel Thierry [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5592A02B.7010000@intel.com \
--to=michel.thierry@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox