Re: [PATCH 3/4] drm/i915/gtt: Return struct i915_scratch_page from alloc_scratch

From: Michel Thierry <michel.thierry@intel.com>
To: Mika Kuoppala <mika.kuoppala@linux.intel.com>,
	intel-gfx@lists.freedesktop.org
Cc: miku@iki.fi
Subject: Re: [PATCH 3/4] drm/i915/gtt: Return struct i915_scratch_page from alloc_scratch
Date: Wed, 1 Jul 2015 13:02:09 +0100	[thread overview]
Message-ID: <5593D6C1.4020903@intel.com> (raw)
In-Reply-To: <1435677400-7630-3-git-send-email-mika.kuoppala@intel.com>

On 6/30/2015 4:16 PM, Mika Kuoppala wrote:
> Every other alloc_* function return the pointer to the page
> they alloc. Follow the convention with scratch page also.
>
Reviewed-by: Michel Thierry <michel.thierry@intel.com>

> Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
> ---
>   drivers/gpu/drm/i915/i915_gem_gtt.c | 78 ++++++++++++++++++-------------------
>   1 file changed, 37 insertions(+), 41 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
> index 78bfb88..402d6d3 100644
> --- a/drivers/gpu/drm/i915/i915_gem_gtt.c
> +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
> @@ -384,6 +384,35 @@ static void fill_page_dma_32(struct drm_device *dev, struct i915_page_dma *p,
>   	fill_page_dma(dev, p, v);
>   }
>

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx