Re: [PATCH 4/4] drm/i915/gtt: Per ppgtt scratch page

Daniel Vetter
2015-07-01T14:23:25Z

On Wed, Jul 01, 2015 at 03:05:44PM +0100, Michel Thierry wrote:
> On 6/30/2015 4:16 PM, Mika Kuoppala wrote:
> >Previously we have pointed the page where the individual ppgtt
> >scratch structures refer to, to be the instance which GGTT setup have
> >allocated. So it has been shared.
> >
> >To achive full isolation between ppgtts also in this regard,
> ^^^^^achieve
>
> >allocate per ppgtt scratch page.
> >
> Maybe also say that it moved scratch page/pt/pd operations together
> (genx_init/free_scratch functions).
>
> Daniel, since you requested this, should it get yours r-b?
> It looks ok to me.

Does that count as an r-b? Doing a detailed review is more work than just
acking the overall idea ;-)
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation