From: Michel Thierry <michel.thierry@intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org, miku@iki.fi,
Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH 4/4] drm/i915/gtt: Per ppgtt scratch page
Date: Wed, 1 Jul 2015 15:25:09 +0100 [thread overview]
Message-ID: <5593F845.7060600@intel.com> (raw)
In-Reply-To: <20150701142613.GU23343@phenom.ffwll.local>
On 7/1/2015 3:26 PM, Daniel Vetter wrote:
> On Wed, Jul 01, 2015 at 03:05:44PM +0100, Michel Thierry wrote:
>> On 6/30/2015 4:16 PM, Mika Kuoppala wrote:
>>> Previously we have pointed the page where the individual ppgtt
>>> scratch structures refer to, to be the instance which GGTT setup have
>>> allocated. So it has been shared.
>>>
>>> To achive full isolation between ppgtts also in this regard,
>> ^^^^^achieve
>>
>>> allocate per ppgtt scratch page.
>>>
>> Maybe also say that it moved scratch page/pt/pd operations together
>> (genx_init/free_scratch functions).
>>
>> Daniel, since you requested this, should it get yours r-b?
>> It looks ok to me.
>
> Does that count as an r-b? Doing a detailed review is more work than just
> acking the overall idea ;-)
Yes, it'd be great if you fix the typo while merging.
Reviewed-by: Michel Thierry <michel.thierry@intel.com>
> -Daniel
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-07-01 14:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-30 15:16 [PATCH 1/4] drm/i915/gtt: Reorder page alloc/free/init functions Mika Kuoppala
2015-06-30 15:16 ` [PATCH 2/4] drm/i915/gtt: Warn if the next layer scratch dma is invalid Mika Kuoppala
2015-06-30 16:59 ` Michel Thierry
2015-06-30 17:11 ` Chris Wilson
2015-07-01 10:55 ` Mika Kuoppala
2015-06-30 15:16 ` [PATCH 3/4] drm/i915/gtt: Return struct i915_scratch_page from alloc_scratch Mika Kuoppala
2015-07-01 12:02 ` Michel Thierry
2015-07-01 13:15 ` Daniel Vetter
2015-06-30 15:16 ` [PATCH 4/4] drm/i915/gtt: Per ppgtt scratch page Mika Kuoppala
2015-07-01 14:05 ` Michel Thierry
2015-07-01 14:26 ` Daniel Vetter
2015-07-01 14:25 ` Michel Thierry [this message]
2015-07-01 14:49 ` Daniel Vetter
2015-07-02 14:34 ` shuang.he
2015-06-30 16:58 ` [PATCH 1/4] drm/i915/gtt: Reorder page alloc/free/init functions Michel Thierry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5593F845.7060600@intel.com \
--to=michel.thierry@intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=miku@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox