From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH v2 13/20] drm/i915: Always reset in intel_crtc_restore_mode Date: Tue, 07 Jul 2015 12:48:36 +0200 Message-ID: <559BAE84.4030606@linux.intel.com> References: <1436252911-5703-1-git-send-email-maarten.lankhorst@linux.intel.com> <1436252911-5703-14-git-send-email-maarten.lankhorst@linux.intel.com> <20150707101744.GG7568@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id 7958C890E4 for ; Tue, 7 Jul 2015 03:48:38 -0700 (PDT) In-Reply-To: <20150707101744.GG7568@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T3AgMDctMDctMTUgb20gMTI6MTcgc2NocmVlZiBEYW5pZWwgVmV0dGVyOgo+IE9uIFR1ZSwgSnVs IDA3LCAyMDE1IGF0IDA5OjA4OjI0QU0gKzAyMDAsIE1hYXJ0ZW4gTGFua2hvcnN0IHdyb3RlOgo+ PiBBbmQgZ2V0IHJpZCBvZiB0aGluZ3MgdGhhdCBhcmUgbm8gbG9uZ2VyIHRydWUuIFRoaXMgZnVu Y3Rpb24gaXMgb25seQo+PiB1c2VkIGZvciBmb3JjaW5nIGEgbW9kZXNldCB3aGVuIGVuY29kZXIg cHJvcGVydGllcyBhcmUgY2hhbmdlZC4KPj4KPj4gQWxsIHRoZSBleGlzdGluZyBzdGF0ZSBpcyBm aW5lIGluIHRoaXMgY2FzZSwgb25seSBzZXR0aW5nIG1vZGVfY2hhbmdlZAo+PiB3aWxsIGZvcmNl IGEgZnVsbCByZWNhbGN1bGF0aW9uIGhlcmUsIGFuZCB0YWtlIGFsbCB0aGUgc3RhdGUgbmVlZGVk Lgo+Pgo+PiBUaGUgcHJldmlvdXMgY29tbWl0IHdpbGwgcHJldmVudCB1bm5lZWRlZCBtb2Rlc2V0 cyBhbnl3YXkuCj4+Cj4+IFNpZ25lZC1vZmYtYnk6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVu Lmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4+IC0tLQo+PiAgZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZGlzcGxheS5jIHwgNTggKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tCj4+ICAxIGZpbGUgY2hhbmdlZCwgMTYgaW5zZXJ0aW9ucygrKSwgNDIgZGVsZXRpb25zKC0p Cj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPj4gaW5kZXggMTYzNzMzMDlk Y2FlLi5mN2IxZmMyODE0MmMgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2Rpc3BsYXkuYwo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5 LmMKPj4gQEAgLTEzMjYwLDYzICsxMzI2MCwzNyBAQCB2b2lkIGludGVsX2NydGNfcmVzdG9yZV9t b2RlKHN0cnVjdCBkcm1fY3J0YyAqY3J0YykKPj4gIHsKPj4gIAlzdHJ1Y3QgZHJtX2RldmljZSAq ZGV2ID0gY3J0Yy0+ZGV2Owo+PiAgCXN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZTsKPj4g LQlzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlcjsKPj4gLQlzdHJ1Y3QgaW50ZWxfY29ubmVj dG9yICpjb25uZWN0b3I7Cj4+IC0Jc3RydWN0IGRybV9jb25uZWN0b3Jfc3RhdGUgKmNvbm5lY3Rv cl9zdGF0ZTsKPj4gLQlzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZTsKPj4gKwlz dHJ1Y3QgZHJtX2NydGNfc3RhdGUgKmNydGNfc3RhdGU7Cj4+ICAJaW50IHJldDsKPj4gIAo+PiAg CXN0YXRlID0gZHJtX2F0b21pY19zdGF0ZV9hbGxvYyhkZXYpOwo+PiAgCWlmICghc3RhdGUpIHsK Pj4gLQkJRFJNX0RFQlVHX0tNUygiW0NSVEM6JWRdIG1vZGUgcmVzdG9yZSBmYWlsZWQsIG91dCBv ZiBtZW1vcnkiLAo+PiArCQlEUk1fREVCVUdfS01TKCJbQ1JUQzolZF0gY3J0YyByZXN0b3JlIGZh aWxlZCwgb3V0IG9mIG1lbW9yeSIsCj4+ICAJCQkgICAgICBjcnRjLT5iYXNlLmlkKTsKPj4gIAkJ cmV0dXJuOwo+PiAgCX0KPj4gIAo+PiAtCXN0YXRlLT5hY3F1aXJlX2N0eCA9IGRldi0+bW9kZV9j b25maWcuYWNxdWlyZV9jdHg7Cj4+IC0KPj4gLQkvKiBUaGUgZm9yY2UgcmVzdG9yZSBwYXRoIGlu IHRoZSBIVyByZWFkb3V0IGNvZGUgcmVsaWVzIG9uIHRoZSBzdGFnZWQKPj4gLQkgKiBjb25maWcg c3RpbGwga2VlcGluZyB0aGUgdXNlciByZXF1ZXN0ZWQgY29uZmlnIHdoaWxlIHRoZSBhY3R1YWwK Pj4gLQkgKiBzdGF0ZSBoYXMgYmVlbiBvdmVyd3JpdHRlbiBieSB0aGUgY29uZmlndXJhdGlvbiBy ZWFkIGZyb20gSFcuIFdlCj4+IC0JICogbmVlZCB0byBjb3B5IHRoZSBzdGFnZWQgY29uZmlnIHRv IHRoZSBhdG9taWMgc3RhdGUsIG90aGVyd2lzZSB0aGUKPj4gLQkgKiBtb2RlIHNldCB3aWxsIGp1 c3QgcmVhcHBseSB0aGUgc3RhdGUgdGhlIEhXIGlzIGFscmVhZHkgaW4uICovCj4+IC0JZm9yX2Vh Y2hfaW50ZWxfZW5jb2RlcihkZXYsIGVuY29kZXIpIHsKPj4gLQkJaWYgKGVuY29kZXItPmJhc2Uu Y3J0YyAhPSBjcnRjKQo+PiAtCQkJY29udGludWU7Cj4+ICsJc3RhdGUtPmFjcXVpcmVfY3R4ID0g ZHJtX21vZGVzZXRfbGVnYWN5X2FjcXVpcmVfY3R4KGNydGMpOwo+PiAgCj4+IC0JCWZvcl9lYWNo X2ludGVsX2Nvbm5lY3RvcihkZXYsIGNvbm5lY3Rvcikgewo+PiAtCQkJaWYgKGNvbm5lY3Rvci0+ YmFzZS5zdGF0ZS0+YmVzdF9lbmNvZGVyICE9Cj4+IC0JCQkgICAgJmVuY29kZXItPmJhc2UpCj4+ IC0JCQkJY29udGludWU7Cj4+IC0KPj4gLQkJCWNvbm5lY3Rvcl9zdGF0ZSA9IGRybV9hdG9taWNf Z2V0X2Nvbm5lY3Rvcl9zdGF0ZShzdGF0ZSwgJmNvbm5lY3Rvci0+YmFzZSk7Cj4+IC0JCQlpZiAo SVNfRVJSKGNvbm5lY3Rvcl9zdGF0ZSkpIHsKPj4gLQkJCQlEUk1fREVCVUdfS01TKCJGYWlsZWQg dG8gYWRkIFtDT05ORUNUT1I6JWQ6JXNdIHRvIHN0YXRlOiAlbGRcbiIsCj4+IC0JCQkJCSAgICAg IGNvbm5lY3Rvci0+YmFzZS5iYXNlLmlkLAo+PiAtCQkJCQkgICAgICBjb25uZWN0b3ItPmJhc2Uu bmFtZSwKPj4gLQkJCQkJICAgICAgUFRSX0VSUihjb25uZWN0b3Jfc3RhdGUpKTsKPj4gLQkJCQlj b250aW51ZTsKPj4gLQkJCX0KPj4gK3JldHJ5Ogo+PiArCWNydGNfc3RhdGUgPSBkcm1fYXRvbWlj X2dldF9jcnRjX3N0YXRlKHN0YXRlLCBjcnRjKTsKPj4gKwlyZXQgPSBQVFJfRVJSX09SX1pFUk8o Y3J0Y19zdGF0ZSk7Cj4+ICsJaWYgKCFyZXQpIHsKPj4gKwkJaWYgKCFjcnRjX3N0YXRlLT5hY3Rp dmUpCj4+ICsJCQlnb3RvIG91dDsKPj4gIAo+PiAtCQkJY29ubmVjdG9yX3N0YXRlLT5jcnRjID0g Y3J0YzsKPj4gLQkJfQo+PiArCQljcnRjX3N0YXRlLT5tb2RlX2NoYW5nZWQgPSB0cnVlOwo+PiAr CQlyZXQgPSBpbnRlbF9zZXRfbW9kZShzdGF0ZSk7Cj4gSSB0aGluayBoZXJlIChpbnN0ZWFkIG9m IHRoZSBodyBzdGF0ZSByZWFkb3V0L3Jlc3RvcmUgY29kZSkgd2UgbXVzdCBkbyBhCj4gZnVsbCBj b21wdXRlIGNvbmZpZyBvZiB0aGUgcGlwZSBzdGF0ZSAtIG1vc3Qgb2YgdGhlIGNvbm5lY3RvciBw cm9wZXJ0aWVzCj4gbmVlZCB0aGF0IHRvIGdldCByZWZsZWN0ZWQuIFNob3VsZCBiZSBlYXN5IHRv IHRlc3QgYnkgY2hhbmdpbmcgdGhlIHBhbmVsCj4gdXBzY2FsaW5nIHByb3BlcnR5LiBIZW5jZSBJ IHRoaW5rIHdlIHNob3VsZCBiZSBhYmxlIHRvIHJ1biBhIGZ1bGwtYmxvd24KPiBkcm1fYXRvbWlj X2NvbW1pdCBoZXJlLgpXaGljaCBpcyB3aGF0IHRoaXMgY29kZSBkb2VzPwpUb2dldGhlciB3aXRo IHRoZSBwcmV2aW91cyBjb21taXQgYXQgbGVhc3QsIHdpdGhvdXQgaXQgaXQganVzdCBwZXJmb3Jt cyBhIGZ1bGwgbW9kZXNldCBhbmQgcmVjYWxjdWxhdGlvbi4KPj4gIAl9Cj4+ICAKPj4gLQljcnRj X3N0YXRlID0gaW50ZWxfYXRvbWljX2dldF9jcnRjX3N0YXRlKHN0YXRlLCB0b19pbnRlbF9jcnRj KGNydGMpKTsKPj4gLQlpZiAoSVNfRVJSKGNydGNfc3RhdGUpKSB7Cj4+IC0JCURSTV9ERUJVR19L TVMoIkZhaWxlZCB0byBhZGQgW0NSVEM6JWRdIHRvIHN0YXRlOiAlbGRcbiIsCj4+IC0JCQkgICAg ICBjcnRjLT5iYXNlLmlkLCBQVFJfRVJSKGNydGNfc3RhdGUpKTsKPj4gLQkJZHJtX2F0b21pY19z dGF0ZV9mcmVlKHN0YXRlKTsKPj4gLQkJcmV0dXJuOwo+PiArCWlmIChyZXQgPT0gLUVERUFETEsp IHsKPj4gKwkJZHJtX2F0b21pY19zdGF0ZV9jbGVhcihzdGF0ZSk7Cj4+ICsJCWRybV9tb2Rlc2V0 X2JhY2tvZmYoc3RhdGUtPmFjcXVpcmVfY3R4KTsKPj4gKwkJZ290byByZXRyeTsKPj4gIAl9Cj4+ ICAKPj4gLQlkcm1fbW9kZV9jb3B5KCZjcnRjX3N0YXRlLT5iYXNlLm1vZGUsICZjcnRjLT5tb2Rl KTsKPj4gLQo+PiAtCWludGVsX21vZGVzZXRfc2V0dXBfcGxhbmVfc3RhdGUoc3RhdGUsIGNydGMs ICZjcnRjLT5tb2RlLAo+PiAtCQkJCQljcnRjLT5wcmltYXJ5LT5mYiwgY3J0Yy0+eCwgY3J0Yy0+ eSk7Cj4+IC0KPj4gLQlyZXQgPSBpbnRlbF9zZXRfbW9kZShzdGF0ZSk7Cj4+ICAJaWYgKHJldCkK Pj4gK291dDoKPj4gIAkJZHJtX2F0b21pY19zdGF0ZV9mcmVlKHN0YXRlKTsKPj4gIH0KPj4gIAo+ PiAtLSAKPj4gMi4xLjAKPj4KPj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KPj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+PiBJbnRlbC1nZnhAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCj4+IGh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9pbnRlbC1nZngKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50 ZWwtZ2Z4Cg==