Re: [PATCH v2 03/20] drm/i915: Fix noatomic crtc disabling.

Daniel Vetter
2015-07-07T09:15:21Z

On Tue, Jul 07, 2015 at 09:08:14AM +0200, Maarten Lankhorst wrote:
> This should fix suspend on newer platforms.

Which patch broke this? Also what is "newer platform" and what exactly got
fixed? Please elaborate a bit more in your commit messages, they're too
terse.
-Daniel

>
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_display.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 6ddb462b4124..4d1a474e0d13 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -6179,6 +6179,8 @@ static void intel_crtc_disable_noatomic(struct drm_crtc *crtc)
> for_each_power_domain(domain, domains)
> intel_display_power_put(dev_priv, domain);
> intel_crtc->enabled_power_domains = 0;
> + intel_crtc->active = false;
> + intel_disable_shared_dpll(intel_crtc);
> }
>
> /*
> --
> 2.1.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Daniel Vetter
Software Engineer, Intel Corporation