From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH v2 02/20] drm: Don't update plane properties for atomic planes if it stays the same Date: Wed, 08 Jul 2015 18:35:47 +0200 Message-ID: <559D5163.7060204@linux.intel.com> References: <1436252911-5703-1-git-send-email-maarten.lankhorst@linux.intel.com> <1436252911-5703-3-git-send-email-maarten.lankhorst@linux.intel.com> <20150707091847.GX7568@phenom.ffwll.local> <559BA7DA.8010701@linux.intel.com> <20150707121011.GQ7568@phenom.ffwll.local> <559BEB72.1050702@linux.intel.com> <20150707164352.GZ7568@phenom.ffwll.local> <559CD896.8040301@linux.intel.com> <20150708085508.GD7568@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20150708085508.GD7568@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T3AgMDgtMDctMTUgb20gMTA6NTUgc2NocmVlZiBEYW5pZWwgVmV0dGVyOgo+IE9uIFdlZCwgSnVs IDA4LCAyMDE1IGF0IDEwOjAwOjIyQU0gKzAyMDAsIE1hYXJ0ZW4gTGFua2hvcnN0IHdyb3RlOgo+ PiBPcCAwNy0wNy0xNSBvbSAxODo0MyBzY2hyZWVmIERhbmllbCBWZXR0ZXI6Cj4+PiBPbiBUdWUs IEp1bCAwNywgMjAxNSBhdCAwNTowODozNFBNICswMjAwLCBNYWFydGVuIExhbmtob3JzdCB3cm90 ZToKPj4+PiBPcCAwNy0wNy0xNSBvbSAxNDoxMCBzY2hyZWVmIERhbmllbCBWZXR0ZXI6Cj4+Pj4+ IE9uIFR1ZSwgSnVsIDA3LCAyMDE1IGF0IDEyOjIwOjEwUE0gKzAyMDAsIE1hYXJ0ZW4gTGFua2hv cnN0IHdyb3RlOgo+Pj4+Pj4gT3AgMDctMDctMTUgb20gMTE6MTggc2NocmVlZiBEYW5pZWwgVmV0 dGVyOgo+Pj4+Pj4+IE9uIFR1ZSwgSnVsIDA3LCAyMDE1IGF0IDA5OjA4OjEzQU0gKzAyMDAsIE1h YXJ0ZW4gTGFua2hvcnN0IHdyb3RlOgo+Pj4+Pj4+PiBUaGlzIGFsbG93cyB0aGUgZmlyc3QgYXRv bWljIGNhbGwgZHVyaW5nIGh3IGluaXQgdG8gYmUgYSByZWFsIG1vZGVzZXQsCj4+Pj4+Pj4+IHdo aWNoIGlzIHVzZWZ1bCBmb3IgZm9yY2luZyBhIHJlY2FsY3VsYXRpb24uCj4+Pj4+Pj4gZmJjb24g aXMgb3B0aW9uYWwsIHlvdSBjYW4ndCByZWx5IG9uIGFueXRoaW5nIGJlaW5nIGRvbmUgaW4gYW55 IHNwZWNpZmljCj4+Pj4+Pj4gd2F5LiBXaGF0IGV4YWN0bHkgZG8geW91IG5lZWQgdGhpcyBmb3Is IHdoYXQncyB0aGUgaW1wbGljYXRpb25zPwo+Pj4+Pj4gSW4gdGhlIGh3IHJlYWRvdXQgSSBub3Rp Y2VkIHNvbWUgd2FybmluZ3Mgd2hlbiBJIHdhc24ndCBzZXR0aW5nIGFueSBtb2RlIHByb3BlcnR5 IGluIHRoZSByZWFkb3V0Lgo+Pj4+Pj4gSSB3YW50IHRoZSBmaXJzdCBmdW5jdGlvbiB0byBiZSB0 aGUgbW9kZXNldCwgc28gd2UgaGF2ZSBhIHNhbmUgYmFzZSB0byBjb21taXQgY2hhbmdlcyBvbi4K Pj4+Pj4+IElkZWFsbHkgdGhpcyB3aG9sZSBmdW5jdGlvbiB3b3VsZCBoYXZlIGEgYXRvbWljIGNv dW50ZXJwYXJ0IHdoaWNoIGRvZXMgaXQgaW4gb25lIGdvLiA6KQo+Pj4+PiBZZWFoLiBPdG9oIGFz IHNvb24gYXMgd2UgaGF2ZSBhdG9taWMgbW9kZXNldCB3b3JraW5nIHdlIGNhbiByZXBsYWNlIGFs bAo+Pj4+PiB0aGUgbGVnYWN5IGVudHJ5IHBvaW50cyB3aXRoIGF0b21pYyBoZWxwZXJzLCBhbmQg dGhlbiBldmVuIHBsYW5lX2Rpc2FibGUKPj4+Pj4gd2lsbCBiZSBhIGZ1bGwgYXRvbWljIG1vZGVz ZXQuCj4+Pj4+Cj4+Pj4+IFdoYXQgZGlkIGZhbGwgYXBhcnQgd2l0aCBqdXN0IHRvdWNoaW5nIHBy b3BlcnRpZXMvcGxhbmVzIG5vdz8KPj4+PiBBbHNvIHdoZW4gaTkxNSBpcyBmdWxseSBhdG9taWMg aXQgY2FsY3VsYXRlcyBpbiBpbnRlbF9tb2Rlc2V0X2NvbXB1dGVfY29uZmlnCj4+Pj4gaWYgYSBt b2Rlc2V0IGlzIG5lZWRlZCBhZnRlciB0aGUgZmlyc3QgYXRvbWljIGNhbGwuIFJpZ2h0IG5vdyBi ZWNhdXNlCj4+Pj4gaW50ZWxfbW9kZXNldF9jb21wdXRlX2NvbmZpZyBpcyBvbmx5IGNhbGxlZCBp biBzZXRfY29uZmlnIHNvIHRoaXMgd29ya3MgYXMgZXhwZWN0ZWQuCj4+Pj4gT3RoZXJ3aXNlIGRy bV9wbGFuZV9mb3JjZV9kaXNhYmxlIG9yIHJvdGF0ZV8wIHdpbGwgZm9yY2UgYSBtb2Rlc2V0LAo+ Pj4+IGFuZCBpZiB0aGUgZmluYWwgbW9kZSBpcyBkaWZmZXJlbnQgdGhpcyB3aWxsIGludHJvZHVj ZSBhIGRvdWJsZSBtb2Rlc2V0Lgo+Pj4gRm9yIGV4cGVuc2l2ZSBwcm9wZXJ0aWVzIChpLmUuIGEg bm8tb3AgY2hhbmdlcyBjYXVzZXMgc29tZXRoaW5nIHRoYXQgdGFrZXMKPj4+IHRpbWUgbGlrZSBt b2Rlc2V0IG9yIHZibGFuayB3YWl0KSB3ZSBuZWVkIHRvIG1ha2Ugc3VyZSB3ZSBmaWx0ZXIgdGhl bSBvdXQKPj4+IGluIGF0b21pY19jaGVjay4gWWVhaCBub3QgcXVpdGUgdGhlcmUgeWV0IHdpdGgg cHVyZSBhdG9taWMsIGJ1dCBtZWFud2hpbGUKPj4+IHRoZSBleGlzdGluZyBsZWdhY3kgc2V0X3By b3AgZnVuY3Rpb25zIHNob3VsZCBhbGwgZmlsdGVyIG91dCBuby1vcCBjaGFuZ2VzCj4+PiB0aGVt c2VsdmVzLiBJZiB3ZSBkb24ndCBkbyB0aGF0IGZvciByb3RhdGlvbiB0aGVuIHRoYXQncyBhIGJ1 Zy4KPj4+Cj4+PiBTYW1lIGZvciBkaXNhYmxpbmcgcGxhbmVzIGhhcmRlciwgdGhhdCBzaG91bGRu J3QgdGFrZSB0aW1lLiBFc3BlY2lhbGx5Cj4+PiBzaW5jZSBmYmNvbiBvbmx5IGZvcmNlLWRpc2Fi bGUgbm9uLXByaW1hcnkgcGxhbmUsIGFuZCBmb3IgZHJpdmVyIGxvYWQKPj4+IHRoYXQncyB0aGUg ZXhhY3QgdGhpbmcgd2UgYWxyZWFkeSBkbyBpbiB0aGUgZHJpdmVyIGFueXdheS4KPj4gU29tZXRo aW5nIGxpa2UgdGhpcz8KPj4gLS0tCj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJt X2F0b21pY19oZWxwZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jCj4+ IGluZGV4IGExZDRlMTNmMzkwOC4uMjk4OTIzMmY0OTk2IDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYwo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJt X2F0b21pY19oZWxwZXIuYwo+PiBAQCAtMzAsNiArMzAsNyBAQAo+PiAgI2luY2x1ZGUgPGRybS9k cm1fcGxhbmVfaGVscGVyLmg+Cj4+ICAjaW5jbHVkZSA8ZHJtL2RybV9jcnRjX2hlbHBlci5oPgo+ PiAgI2luY2x1ZGUgPGRybS9kcm1fYXRvbWljX2hlbHBlci5oPgo+PiArI2luY2x1ZGUgImRybV9j cnRjX2ludGVybmFsLmgiCj4+ICAjaW5jbHVkZSA8bGludXgvZmVuY2UuaD4KPj4gIAo+PiAgLyoq Cj4+IEBAIC0xNzE2LDcgKzE3MTcsMTIgQEAgZHJtX2F0b21pY19oZWxwZXJfY3J0Y19zZXRfcHJv cGVydHkoc3RydWN0IGRybV9jcnRjICpjcnRjLAo+PiAgewo+PiAgCXN0cnVjdCBkcm1fYXRvbWlj X3N0YXRlICpzdGF0ZTsKPj4gIAlzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKmNydGNfc3RhdGU7Cj4+ IC0JaW50IHJldCA9IDA7Cj4+ICsJdWludDY0X3QgcmV0dmFsOwo+PiArCWludCByZXQ7Cj4+ICsK Pj4gKwlyZXQgPSBkcm1fYXRvbWljX2dldF9wcm9wZXJ0eSgmY3J0Yy0+YmFzZSwgcHJvcGVydHks ICZyZXR2YWwpOwo+PiArCWlmICghcmV0ICYmIHZhbCA9PSByZXR2YWwpCj4+ICsJCXJldHVybiAw Owo+PiAgCj4+ICAJc3RhdGUgPSBkcm1fYXRvbWljX3N0YXRlX2FsbG9jKGNydGMtPmRldik7Cj4+ ICAJaWYgKCFzdGF0ZSkKPj4gQEAgLTE3NzYsNyArMTc4MiwxMiBAQCBkcm1fYXRvbWljX2hlbHBl cl9wbGFuZV9zZXRfcHJvcGVydHkoc3RydWN0IGRybV9wbGFuZSAqcGxhbmUsCj4+ICB7Cj4+ICAJ c3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlOwo+PiAgCXN0cnVjdCBkcm1fcGxhbmVfc3Rh dGUgKnBsYW5lX3N0YXRlOwo+PiAtCWludCByZXQgPSAwOwo+PiArCXVpbnQ2NF90IHJldHZhbDsK Pj4gKwlpbnQgcmV0Owo+PiArCj4+ICsJcmV0ID0gZHJtX2F0b21pY19nZXRfcHJvcGVydHkoJnBs YW5lLT5iYXNlLCBwcm9wZXJ0eSwgJnJldHZhbCk7Cj4+ICsJaWYgKCFyZXQgJiYgdmFsID09IHJl dHZhbCkKPj4gKwkJcmV0dXJuIDA7Cj4+ICAKPj4gIAlzdGF0ZSA9IGRybV9hdG9taWNfc3RhdGVf YWxsb2MocGxhbmUtPmRldik7Cj4+ICAJaWYgKCFzdGF0ZSkKPj4gQEAgLTE4MzYsNyArMTg0Nywx MiBAQCBkcm1fYXRvbWljX2hlbHBlcl9jb25uZWN0b3Jfc2V0X3Byb3BlcnR5KHN0cnVjdCBkcm1f Y29ubmVjdG9yICpjb25uZWN0b3IsCj4+ICB7Cj4+ICAJc3RydWN0IGRybV9hdG9taWNfc3RhdGUg KnN0YXRlOwo+PiAgCXN0cnVjdCBkcm1fY29ubmVjdG9yX3N0YXRlICpjb25uZWN0b3Jfc3RhdGU7 Cj4+IC0JaW50IHJldCA9IDA7Cj4+ICsJdWludDY0X3QgcmV0dmFsOwo+PiArCWludCByZXQ7Cj4+ ICsKPj4gKwlyZXQgPSBkcm1fYXRvbWljX2dldF9wcm9wZXJ0eSgmY29ubmVjdG9yLT5iYXNlLCBw cm9wZXJ0eSwgJnJldHZhbCk7Cj4+ICsJaWYgKCFyZXQgJiYgdmFsID09IHJldHZhbCkKPj4gKwkJ cmV0dXJuIDA7Cj4+ICAKPj4gIAlzdGF0ZSA9IGRybV9hdG9taWNfc3RhdGVfYWxsb2MoY29ubmVj dG9yLT5kZXYpOwo+PiAgCWlmICghc3RhdGUpCj4gVGhlIHJlYXNvbiBJIGRpZG4ndCBkbyB0aGlz IGlzIHRoYXQgYSBwcm9wIGNoYW5nZSBtaWdodCBzdGlsbCByZXN1bHQgaW4gbm8KPiBodyBzdGF0 ZSBjaGFuZ2UgKGUuZy4gaWYgeW91IGdvIGF1dG9taXRpYy0+ZXhwbGljaXQgc2V0dGluZyBtYXRj aGluZwo+IGF1dG9tYXRpYyBvbmUpLiBIZW5jZSBJIHRoaW5rIHdlIG5lZWQgdG8gc29sdmUgdGhp cyBpbiBsb3dlciBsZXZlbHMKPiBhbnl3YXksIGkuZS4gaW4gd2hlbiBjb21wdXRpbmcgdGhlIGNv bmZpZy4gQnV0IGl0IHNob3VsZG4ndCBjYXVzZSB0cm91YmxlCj4geWV0LgpJcyB0aGF0IGEgYWNr IG9yIG5hY2s/Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2NydGMuYyBiL2Ry aXZlcnMvZ3B1L2RybS9kcm1fY3J0Yy5jCj4+IGluZGV4IDQyNGM4MzMyM2FhYS4uNWJhYjdiZmY4 YTE1IDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2NydGMuYwo+PiArKysgYi9k cml2ZXJzL2dwdS9kcm0vZHJtX2NydGMuYwo+PiBAQCAtMTMyNyw3ICsxMzI3LDggQEAgdm9pZCBk cm1fcGxhbmVfZm9yY2VfZGlzYWJsZShzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSkKPj4gIHsKPj4g IAlpbnQgcmV0Owo+PiAgCj4+IC0JaWYgKCFwbGFuZS0+ZmIpCj4+ICsJaWYgKChwbGFuZS0+c3Rh dGUgJiYgIXBsYW5lLT5zdGF0ZS0+ZmIpIHx8Cj4+ICsJICAgICghcGxhbmUtPnN0YXRlICYmICFw bGFuZS0+ZmIpKQo+PiAgCQlyZXR1cm47Cj4gTmFoLCBhdG9taWMgaGVscGVycyBzaG91bGQgZmln dXJlIHRoaXMgb3V0IGltby4gU2luY2UgaWYgdXNlcnNwYWNlIGRvZXMKPiB0aGUgc2FtZSAobG9v cCBvdmVyIGFsbCBwbGFuZXMpIHRoZW4gaXQgd29uJ3QgZ28gdGhyb3VnaCBmb3JjZV9kaXNhYmxl Lgo+IC1EYW5pZWwKPgo+PiAgCj4+ICAJcGxhbmUtPm9sZF9mYiA9IHBsYW5lLT5mYjsKPj4KCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBt YWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==