From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH v2 02/20] drm: Don't update plane properties for atomic planes if it stays the same Date: Mon, 13 Jul 2015 10:59:32 +0200 Message-ID: <55A37DF4.80804@linux.intel.com> References: <20150707091847.GX7568@phenom.ffwll.local> <559BA7DA.8010701@linux.intel.com> <20150707121011.GQ7568@phenom.ffwll.local> <559BEB72.1050702@linux.intel.com> <20150707164352.GZ7568@phenom.ffwll.local> <559CD896.8040301@linux.intel.com> <20150708085508.GD7568@phenom.ffwll.local> <559D5163.7060204@linux.intel.com> <20150708175151.GA21858@phenom.ffwll.local> <559D6B03.2060804@linux.intel.com> <20150708201241.GB21858@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20150708201241.GB21858@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T3AgMDgtMDctMTUgb20gMjI6MTIgc2NocmVlZiBEYW5pZWwgVmV0dGVyOgo+IE9uIFdlZCwgSnVs IDA4LCAyMDE1IGF0IDA4OjI1OjA3UE0gKzAyMDAsIE1hYXJ0ZW4gTGFua2hvcnN0IHdyb3RlOgo+ PiBPcCAwOC0wNy0xNSBvbSAxOTo1MiBzY2hyZWVmIERhbmllbCBWZXR0ZXI6Cj4+PiBPbiBXZWQs IEp1bCAwOCwgMjAxNSBhdCAwNjozNTo0N1BNICswMjAwLCBNYWFydGVuIExhbmtob3JzdCB3cm90 ZToKPj4+PiBPcCAwOC0wNy0xNSBvbSAxMDo1NSBzY2hyZWVmIERhbmllbCBWZXR0ZXI6Cj4+Pj4+ IE9uIFdlZCwgSnVsIDA4LCAyMDE1IGF0IDEwOjAwOjIyQU0gKzAyMDAsIE1hYXJ0ZW4gTGFua2hv cnN0IHdyb3RlOgo+Pj4+Pj4gT3AgMDctMDctMTUgb20gMTg6NDMgc2NocmVlZiBEYW5pZWwgVmV0 dGVyOgo+Pj4+Pj4+IE9uIFR1ZSwgSnVsIDA3LCAyMDE1IGF0IDA1OjA4OjM0UE0gKzAyMDAsIE1h YXJ0ZW4gTGFua2hvcnN0IHdyb3RlOgo+Pj4+Pj4+PiBPcCAwNy0wNy0xNSBvbSAxNDoxMCBzY2hy ZWVmIERhbmllbCBWZXR0ZXI6Cj4+Pj4+Pj4+PiBPbiBUdWUsIEp1bCAwNywgMjAxNSBhdCAxMjoy MDoxMFBNICswMjAwLCBNYWFydGVuIExhbmtob3JzdCB3cm90ZToKPj4+Pj4+Pj4+PiBPcCAwNy0w Ny0xNSBvbSAxMToxOCBzY2hyZWVmIERhbmllbCBWZXR0ZXI6Cj4+Pj4+Pj4+Pj4+IE9uIFR1ZSwg SnVsIDA3LCAyMDE1IGF0IDA5OjA4OjEzQU0gKzAyMDAsIE1hYXJ0ZW4gTGFua2hvcnN0IHdyb3Rl Ogo+Pj4+Pj4+Pj4+Pj4gVGhpcyBhbGxvd3MgdGhlIGZpcnN0IGF0b21pYyBjYWxsIGR1cmluZyBo dyBpbml0IHRvIGJlIGEgcmVhbCBtb2Rlc2V0LAo+Pj4+Pj4+Pj4+Pj4gd2hpY2ggaXMgdXNlZnVs IGZvciBmb3JjaW5nIGEgcmVjYWxjdWxhdGlvbi4KPj4+Pj4+Pj4+Pj4gZmJjb24gaXMgb3B0aW9u YWwsIHlvdSBjYW4ndCByZWx5IG9uIGFueXRoaW5nIGJlaW5nIGRvbmUgaW4gYW55IHNwZWNpZmlj Cj4+Pj4+Pj4+Pj4+IHdheS4gV2hhdCBleGFjdGx5IGRvIHlvdSBuZWVkIHRoaXMgZm9yLCB3aGF0 J3MgdGhlIGltcGxpY2F0aW9ucz8KPj4+Pj4+Pj4+PiBJbiB0aGUgaHcgcmVhZG91dCBJIG5vdGlj ZWQgc29tZSB3YXJuaW5ncyB3aGVuIEkgd2Fzbid0IHNldHRpbmcgYW55IG1vZGUgcHJvcGVydHkg aW4gdGhlIHJlYWRvdXQuCj4+Pj4+Pj4+Pj4gSSB3YW50IHRoZSBmaXJzdCBmdW5jdGlvbiB0byBi ZSB0aGUgbW9kZXNldCwgc28gd2UgaGF2ZSBhIHNhbmUgYmFzZSB0byBjb21taXQgY2hhbmdlcyBv bi4KPj4+Pj4+Pj4+PiBJZGVhbGx5IHRoaXMgd2hvbGUgZnVuY3Rpb24gd291bGQgaGF2ZSBhIGF0 b21pYyBjb3VudGVycGFydCB3aGljaCBkb2VzIGl0IGluIG9uZSBnby4gOikKPj4+Pj4+Pj4+IFll YWguIE90b2ggYXMgc29vbiBhcyB3ZSBoYXZlIGF0b21pYyBtb2Rlc2V0IHdvcmtpbmcgd2UgY2Fu IHJlcGxhY2UgYWxsCj4+Pj4+Pj4+PiB0aGUgbGVnYWN5IGVudHJ5IHBvaW50cyB3aXRoIGF0b21p YyBoZWxwZXJzLCBhbmQgdGhlbiBldmVuIHBsYW5lX2Rpc2FibGUKPj4+Pj4+Pj4+IHdpbGwgYmUg YSBmdWxsIGF0b21pYyBtb2Rlc2V0Lgo+Pj4+Pj4+Pj4KPj4+Pj4+Pj4+IFdoYXQgZGlkIGZhbGwg YXBhcnQgd2l0aCBqdXN0IHRvdWNoaW5nIHByb3BlcnRpZXMvcGxhbmVzIG5vdz8KPj4+Pj4+Pj4g QWxzbyB3aGVuIGk5MTUgaXMgZnVsbHkgYXRvbWljIGl0IGNhbGN1bGF0ZXMgaW4gaW50ZWxfbW9k ZXNldF9jb21wdXRlX2NvbmZpZwo+Pj4+Pj4+PiBpZiBhIG1vZGVzZXQgaXMgbmVlZGVkIGFmdGVy IHRoZSBmaXJzdCBhdG9taWMgY2FsbC4gUmlnaHQgbm93IGJlY2F1c2UKPj4+Pj4+Pj4gaW50ZWxf bW9kZXNldF9jb21wdXRlX2NvbmZpZyBpcyBvbmx5IGNhbGxlZCBpbiBzZXRfY29uZmlnIHNvIHRo aXMgd29ya3MgYXMgZXhwZWN0ZWQuCj4+Pj4+Pj4+IE90aGVyd2lzZSBkcm1fcGxhbmVfZm9yY2Vf ZGlzYWJsZSBvciByb3RhdGVfMCB3aWxsIGZvcmNlIGEgbW9kZXNldCwKPj4+Pj4+Pj4gYW5kIGlm IHRoZSBmaW5hbCBtb2RlIGlzIGRpZmZlcmVudCB0aGlzIHdpbGwgaW50cm9kdWNlIGEgZG91Ymxl IG1vZGVzZXQuCj4+Pj4+Pj4gRm9yIGV4cGVuc2l2ZSBwcm9wZXJ0aWVzIChpLmUuIGEgbm8tb3Ag Y2hhbmdlcyBjYXVzZXMgc29tZXRoaW5nIHRoYXQgdGFrZXMKPj4+Pj4+PiB0aW1lIGxpa2UgbW9k ZXNldCBvciB2Ymxhbmsgd2FpdCkgd2UgbmVlZCB0byBtYWtlIHN1cmUgd2UgZmlsdGVyIHRoZW0g b3V0Cj4+Pj4+Pj4gaW4gYXRvbWljX2NoZWNrLiBZZWFoIG5vdCBxdWl0ZSB0aGVyZSB5ZXQgd2l0 aCBwdXJlIGF0b21pYywgYnV0IG1lYW53aGlsZQo+Pj4+Pj4+IHRoZSBleGlzdGluZyBsZWdhY3kg c2V0X3Byb3AgZnVuY3Rpb25zIHNob3VsZCBhbGwgZmlsdGVyIG91dCBuby1vcCBjaGFuZ2VzCj4+ Pj4+Pj4gdGhlbXNlbHZlcy4gSWYgd2UgZG9uJ3QgZG8gdGhhdCBmb3Igcm90YXRpb24gdGhlbiB0 aGF0J3MgYSBidWcuCj4+Pj4+Pj4KPj4+Pj4+PiBTYW1lIGZvciBkaXNhYmxpbmcgcGxhbmVzIGhh cmRlciwgdGhhdCBzaG91bGRuJ3QgdGFrZSB0aW1lLiBFc3BlY2lhbGx5Cj4+Pj4+Pj4gc2luY2Ug ZmJjb24gb25seSBmb3JjZS1kaXNhYmxlIG5vbi1wcmltYXJ5IHBsYW5lLCBhbmQgZm9yIGRyaXZl ciBsb2FkCj4+Pj4+Pj4gdGhhdCdzIHRoZSBleGFjdCB0aGluZyB3ZSBhbHJlYWR5IGRvIGluIHRo ZSBkcml2ZXIgYW55d2F5Lgo+Pj4+Pj4gU29tZXRoaW5nIGxpa2UgdGhpcz8KPj4+Pj4+IC0tLQo+ Pj4+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jIGIv ZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMKPj4+Pj4+IGluZGV4IGExZDRlMTNm MzkwOC4uMjk4OTIzMmY0OTk2IDEwMDY0NAo+Pj4+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2Ry bV9hdG9taWNfaGVscGVyLmMKPj4+Pj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWlj X2hlbHBlci5jCj4+Pj4+PiBAQCAtMzAsNiArMzAsNyBAQAo+Pj4+Pj4gICNpbmNsdWRlIDxkcm0v ZHJtX3BsYW5lX2hlbHBlci5oPgo+Pj4+Pj4gICNpbmNsdWRlIDxkcm0vZHJtX2NydGNfaGVscGVy Lmg+Cj4+Pj4+PiAgI2luY2x1ZGUgPGRybS9kcm1fYXRvbWljX2hlbHBlci5oPgo+Pj4+Pj4gKyNp bmNsdWRlICJkcm1fY3J0Y19pbnRlcm5hbC5oIgo+Pj4+Pj4gICNpbmNsdWRlIDxsaW51eC9mZW5j ZS5oPgo+Pj4+Pj4gIAo+Pj4+Pj4gIC8qKgo+Pj4+Pj4gQEAgLTE3MTYsNyArMTcxNywxMiBAQCBk cm1fYXRvbWljX2hlbHBlcl9jcnRjX3NldF9wcm9wZXJ0eShzdHJ1Y3QgZHJtX2NydGMgKmNydGMs Cj4+Pj4+PiAgewo+Pj4+Pj4gIAlzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGU7Cj4+Pj4+ PiAgCXN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZTsKPj4+Pj4+IC0JaW50IHJldCA9 IDA7Cj4+Pj4+PiArCXVpbnQ2NF90IHJldHZhbDsKPj4+Pj4+ICsJaW50IHJldDsKPj4+Pj4+ICsK Pj4+Pj4+ICsJcmV0ID0gZHJtX2F0b21pY19nZXRfcHJvcGVydHkoJmNydGMtPmJhc2UsIHByb3Bl cnR5LCAmcmV0dmFsKTsKPj4+Pj4+ICsJaWYgKCFyZXQgJiYgdmFsID09IHJldHZhbCkKPj4+Pj4+ ICsJCXJldHVybiAwOwo+Pj4+Pj4gIAo+Pj4+Pj4gIAlzdGF0ZSA9IGRybV9hdG9taWNfc3RhdGVf YWxsb2MoY3J0Yy0+ZGV2KTsKPj4+Pj4+ICAJaWYgKCFzdGF0ZSkKPj4+Pj4+IEBAIC0xNzc2LDcg KzE3ODIsMTIgQEAgZHJtX2F0b21pY19oZWxwZXJfcGxhbmVfc2V0X3Byb3BlcnR5KHN0cnVjdCBk cm1fcGxhbmUgKnBsYW5lLAo+Pj4+Pj4gIHsKPj4+Pj4+ICAJc3RydWN0IGRybV9hdG9taWNfc3Rh dGUgKnN0YXRlOwo+Pj4+Pj4gIAlzdHJ1Y3QgZHJtX3BsYW5lX3N0YXRlICpwbGFuZV9zdGF0ZTsK Pj4+Pj4+IC0JaW50IHJldCA9IDA7Cj4+Pj4+PiArCXVpbnQ2NF90IHJldHZhbDsKPj4+Pj4+ICsJ aW50IHJldDsKPj4+Pj4+ICsKPj4+Pj4+ICsJcmV0ID0gZHJtX2F0b21pY19nZXRfcHJvcGVydHko JnBsYW5lLT5iYXNlLCBwcm9wZXJ0eSwgJnJldHZhbCk7Cj4+Pj4+PiArCWlmICghcmV0ICYmIHZh bCA9PSByZXR2YWwpCj4+Pj4+PiArCQlyZXR1cm4gMDsKPj4+Pj4+ICAKPj4+Pj4+ICAJc3RhdGUg PSBkcm1fYXRvbWljX3N0YXRlX2FsbG9jKHBsYW5lLT5kZXYpOwo+Pj4+Pj4gIAlpZiAoIXN0YXRl KQo+Pj4+Pj4gQEAgLTE4MzYsNyArMTg0NywxMiBAQCBkcm1fYXRvbWljX2hlbHBlcl9jb25uZWN0 b3Jfc2V0X3Byb3BlcnR5KHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IsCj4+Pj4+PiAg ewo+Pj4+Pj4gIAlzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGU7Cj4+Pj4+PiAgCXN0cnVj dCBkcm1fY29ubmVjdG9yX3N0YXRlICpjb25uZWN0b3Jfc3RhdGU7Cj4+Pj4+PiAtCWludCByZXQg PSAwOwo+Pj4+Pj4gKwl1aW50NjRfdCByZXR2YWw7Cj4+Pj4+PiArCWludCByZXQ7Cj4+Pj4+PiAr Cj4+Pj4+PiArCXJldCA9IGRybV9hdG9taWNfZ2V0X3Byb3BlcnR5KCZjb25uZWN0b3ItPmJhc2Us IHByb3BlcnR5LCAmcmV0dmFsKTsKPj4+Pj4+ICsJaWYgKCFyZXQgJiYgdmFsID09IHJldHZhbCkK Pj4+Pj4+ICsJCXJldHVybiAwOwo+Pj4+Pj4gIAo+Pj4+Pj4gIAlzdGF0ZSA9IGRybV9hdG9taWNf c3RhdGVfYWxsb2MoY29ubmVjdG9yLT5kZXYpOwo+Pj4+Pj4gIAlpZiAoIXN0YXRlKQo+Pj4+PiBU aGUgcmVhc29uIEkgZGlkbid0IGRvIHRoaXMgaXMgdGhhdCBhIHByb3AgY2hhbmdlIG1pZ2h0IHN0 aWxsIHJlc3VsdCBpbiBubwo+Pj4+PiBodyBzdGF0ZSBjaGFuZ2UgKGUuZy4gaWYgeW91IGdvIGF1 dG9taXRpYy0+ZXhwbGljaXQgc2V0dGluZyBtYXRjaGluZwo+Pj4+PiBhdXRvbWF0aWMgb25lKS4g SGVuY2UgSSB0aGluayB3ZSBuZWVkIHRvIHNvbHZlIHRoaXMgaW4gbG93ZXIgbGV2ZWxzCj4+Pj4+ IGFueXdheSwgaS5lLiBpbiB3aGVuIGNvbXB1dGluZyB0aGUgY29uZmlnLiBCdXQgaXQgc2hvdWxk bid0IGNhdXNlIHRyb3VibGUKPj4+Pj4geWV0Lgo+Pj4+IElzIHRoYXQgYSBhY2sgb3IgbmFjaz8K Pj4+IEkgdGhpbmsgd2Ugc2hvdWxkbid0IG5lZWQgdGhpcyByZWFsbHkgZm9yIGk5MTUsIGFuZCBp dCBtaWdodCBjb3ZlciB1cAo+Pj4gYnVncy4gSSBwcmVmZXIgd2UganVzdCBkbyB0aGUgZXZhZGUg bW9kZXNldCBsb2dpYyB5b3UndmUgaW1wbGVtZW50ZWQgb25jZQo+Pj4gd2Ugc3dpdGNoIG92ZXIg dG8gYXRvbWljIHByb3BzLiBTaW5jZSBhdG0gd2Ugb25seSBoYXZlIGF0b21pYyBwcm9wcyB3aGlj aAo+Pj4gZ2V0IHVwZGF0ZWQgaW4gcGFnZWZsaXBzIHdlIHNob3VsZG4ndCBoYXZlIHNlcmlvdXMg cHJvYmxlbXMgaGVyZSB5ZXQgKGZvcgo+Pj4gc2V0dGluZyB0aGUgcm90YXRpb24gcHJvcCB0byAw wrAgYWdhaW4gd2hlbiBmYmRldiBzdGFydHMgdXApLgo+Pj4KPj4+IE9yIGRvIEkgbWlzcyBzb21l dGhpbmcgc3RpbGwgaGVyZT8KPj4gWWVzLCBpZiB0aGUgaGFyZHdhcmUgbW9kZSBpcyBpbmNvbXBh dGlibGUgd2l0aCBpdHMgY2FsY3VsYXRlZCBzdyBtb2RlLAo+PiBhbmQgd2Ugc2V0IGEgZGlmZmVy ZW50IG1vZGUgZnJvbSBmYmRldiB5b3UgZ2V0IDIgbW9kZXNldHMgaW5zdGVhZCBvZiAxLgo+IEhv dyBkb2VzIHRoYXQgaGFwcGVuPyBGb3Igc2V0dGluZyB0aGUgcm90YXRpb24gcHJvcGVydHkgd2Ug c2hvdWxkIGp1c3QKPiBkdXBsaWNhdGUgdGhlIGN1cnJlbnQgY3J0YyBzdGF0ZS4gU2luY2UgdGhl cmUncyBubyBtb2RlIGNoYW5naW5nICh0aGV5Cj4gc2hvdWxkIG1hdGNoIHBlcmZlY3RseSBubyBt YXR0ZXIgaG93IGJvdGNoZWQgdGhlIHJlY29uc3RydWN0aW9uIGlzKSB0aGVyZQo+IHNob3VsZG4n dCBiZSBhbnkgbmVlZCB0byByZWNvbXB1dGUgdGhlIGNvbmZpZyBjb21wbGV0ZWx5IGFuZCBkaXNj b3ZlciB0aGF0Cj4gdGhlcmUncyBhIG1pc21hdGNoLiBXaGljaCBtZWFucyB3ZSdsbCBqdXN0IGRv IHRoZSBwbGFuZSB1cGRhdGUgKHdoaWNoCj4gbWlnaHQgZG8gYSBmZXcgc2lsbHkgbW1pb3MgYnV0 IHNob3VsZG4ndCBibG9jaykgYW5kIHRoYXQncyBpdC4KPgo+IEF0IGxlYXN0IHRoYXQncyB3aGF0 IEknZCBleHBlY3QgLSB3aGVyZSBkb2VzIHRoaXMgZmFsbCBhcGFydD8KSWYgY3J0YyBpcyBhY3Rp dmUgYW5kIHByaW1hcnkgZmIgdmlzaWJsZSwgYW5kIGNvbnZlcnRlZCB0byBhdG9taWM6CgpyZXN0 b3JlX2ZiZGV2X21vZGUoKSAtPgoJZHJtX21vZGVfcGxhbmVfc2V0X29ial9wcm9wKCkgLT4KCQlk cm1fYXRvbWljX2hlbHBlcl9wbGFuZV9zZXRfcHJvcGVydHkoKSAtPgoJCQlkcm1fYXRvbWljX2dl dF9wbGFuZV9zdGF0ZSgpIC0+CgkJCQlkcm1fYXRvbWljX2dldF9jcnRjX3N0YXRlKCkKY3J0YyBz dGF0ZSBpcyBwYXJ0IG9mIHRoZSBzdGF0ZSwgaW50ZWxfbW9kZXNldF9waXBlX2NvbmZpZyBwZXJm b3Jtcwp0aGUgaW5pdGlhbCBjaGVjayBpZiBtb2Rlc2V0J3MgbmVlZGVkLiBMZXRzIGFzc3VtZSB5 ZXM6CgoJCQltb2Rlc2V0KCkKCgkJZHJtX21vZGVfc2V0X2NvbmZpZ19pbnRlcm5hbCgpIC0+CgkJ CW1vZGVzZXQoKQoKQm9vbSBkb3VibGUgbW9kZXNldC4gOigKClRoZSBhbHRlcm5hdGl2ZSBzb2x1 dGlvbiBpcyBtYWtpbmcgYSBhdG9taWMgdmVyc2lvbiBvZiByZXN0b3JlX2ZiZGV2X21vZGUsCmJ1 dCB0aGF0IHdvdWxkIGJyZWFrIGRyaXZlcnMgdGhhdCBhcmUgb25seSBwYXJ0aWFsbHkgY29udmVy dGVkIHRvIGF0b21pYywKbGlrZSBpOTE1IHdpdGggaTkxNS5udWNsZWFyX3BhZ2VmbGlwPXRydWUg YmVmb3JlIHRoZSBjb252ZXJ0IHRvIGF0b21pYyBjb21taXQuCgp+TWFhcnRlbgoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcg bGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK