Re: [PATCH v3 16/20] drm/i915: Make intel_display_suspend atomic, try 2.

From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v3 16/20] drm/i915: Make intel_display_suspend atomic, try 2.
Date: Wed, 15 Jul 2015 06:05:36 +0200	[thread overview]
Message-ID: <55A5DC10.5050400@linux.intel.com> (raw)
In-Reply-To: <20150714161448.GE3736@phenom.ffwll.local>

Hey,

Op 14-07-15 om 18:14 schreef Daniel Vetter:
> On Mon, Jul 13, 2015 at 04:30:29PM +0200, Maarten Lankhorst wrote:
>> Calculate all state using a normal transition, but afterwards fudge
>> crtc->state->active back to its old value. This should still allow
>> state restore in setup_hw_state to work properly.
>>
>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Ok merged up to this patch with the exception of patch 8. I think
> reworking that logic to use mode->private_flags to make sure we do a
> modeset when userspace changes the mode, but not earlier is a sound
> approach which will address all my concerns.
Patch 8 doesn't affect whether a modeset will happen and is safe to merge. It just fills in some more mode flags.
What you just described was done in patch 11 you just merged. ;-)

~Maarten
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx