public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: Matt Roper <matthew.d.roper@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [RFC 7/8] drm/i915: Allow final wm programming to be scheduled after next vblank (v2)
Date: Mon, 20 Jul 2015 10:10:11 +0200	[thread overview]
Message-ID: <55ACACE3.5090108@linux.intel.com> (raw)
In-Reply-To: <1435803961-30079-8-git-send-email-matthew.d.roper@intel.com>

Op 02-07-15 om 04:26 schreef Matt Roper:
> Add a simple mechanism to trigger final watermark updates in an
> asynchronous manner once the next vblank occurs.  No platform types
> actually support atomic watermark programming until a future patch, so
> there should be no functional change yet; individual platforms will be
> converted to use this mechanism one-by-one in future patches.
>
> Note that we'll probably expand this to cover other post-vblank async
> tasks (like unpinning) at some point in the future.
>
> v2: Much simpler vblank mechanism than was used in the previous series;
>     no need to allocate new heap structures.
>
Patch 1-6 are good. But 7 and 8 make my life harder.

There is more that needs to be done asynchronously, can you just commit the watermarks synchronously after drm_atomic_helper_wait_for_vblanks for now?

~Maarten
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2015-07-20  8:10 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-02  2:25 [RFC 0/8] Atomic watermark updates (v2) Matt Roper
2015-07-02  2:25 ` [RFC 1/8] drm/i915: Eliminate usage of plane_wm_parameters from ILK-style WM code Matt Roper
2015-07-02  2:25 ` [RFC 2/8] drm/i915: Eliminate usage of pipe_wm_parameters from ILK-style WM Matt Roper
2015-07-02  2:25 ` [RFC 3/8] drm/i915/ivb: Move WaCxSRDisabledForSpriteScaling w/a to atomic check Matt Roper
2015-10-02 16:03   ` Egbert Eich
2015-10-06  8:23     ` Daniel Vetter
2015-07-02  2:25 ` [RFC 4/8] drm/i915: Refactor ilk_update_wm (v3) Matt Roper
2015-07-02  2:25 ` [RFC 5/8] drm/i915: Move active watermarks into CRTC state Matt Roper
2015-07-20  9:19   ` Maarten Lankhorst
2015-07-02  2:25 ` [RFC 6/8] drm/i915: Calculate ILK-style watermarks during atomic check (v2) Matt Roper
2015-07-06  9:13   ` Daniel Vetter
2015-07-02  2:26 ` [RFC 7/8] drm/i915: Allow final wm programming to be scheduled after next vblank (v2) Matt Roper
2015-07-06  9:07   ` Daniel Vetter
2015-07-06 11:23     ` Ville Syrjälä
2015-07-20  8:10   ` Maarten Lankhorst [this message]
2015-07-02  2:26 ` [RFC 8/8] drm/i915: Add two-stage ILK-style watermark programming (v2) Matt Roper
2015-07-06  9:11   ` Daniel Vetter
2015-07-06 12:20   ` Maarten Lankhorst
2015-07-06 12:26     ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55ACACE3.5090108@linux.intel.com \
    --to=maarten.lankhorst@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=matthew.d.roper@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox