From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 5/5] drm/i915: Make wait_for_flips interruptible.
Date: Mon, 20 Jul 2015 16:52:11 +0200 [thread overview]
Message-ID: <55AD0B1B.90703@linux.intel.com> (raw)
In-Reply-To: <1437051471-15397-6-git-send-email-maarten.lankhorst@linux.intel.com>
Op 16-07-15 om 14:57 schreef Maarten Lankhorst:
> Move it from intel_crtc_atomic_commit to prepare_plane_fb.
> Waiting is done before committing, otherwise it's too late
> to undo the changes.
>
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_atomic.c | 2 -
> drivers/gpu/drm/i915/intel_display.c | 72 +++++++++++++++++-------------------
> drivers/gpu/drm/i915/intel_drv.h | 2 -
> 3 files changed, 33 insertions(+), 43 deletions(-)
>
This breaks DPMS off, because it might wait for flips before continuing.
It looks like all drivers use drmModeConnectorSetProperty correctly,
so it's safe to fix dpms to return an error.
Can I get the changes to dpms handling in intel applied first, and the first 4 patches from this series?
~Maarten
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-07-20 14:52 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-16 12:57 [PATCH 0/5] drm/i915: Make waiting interruptible Maarten Lankhorst
2015-07-16 12:57 ` [PATCH 1/5] drm/i915: Handle return value in intel_pin_and_fence_fb_obj Maarten Lankhorst
2015-07-21 11:31 ` Chris Wilson
2015-07-21 14:09 ` [PATCH v1.1 1/5] drm/i915: Handle return value in intel_pin_and_fence_fb_obj, v2 Maarten Lankhorst
2015-07-24 13:26 ` Ander Conselvan De Oliveira
2015-07-24 14:02 ` Chris Wilson
2015-07-26 7:24 ` Maarten Lankhorst
2015-07-16 12:57 ` [PATCH 2/5] drm/atomic: Make prepare_fb/cleanup_fb only take state Maarten Lankhorst
2015-07-16 14:13 ` [PATCH v1.1 2/5] drm/atomic: Make prepare_fb/cleanup_fb only take state, v2 Maarten Lankhorst
2015-07-22 13:23 ` Rob Clark
2015-07-27 7:53 ` [Intel-gfx] " Daniel Vetter
2015-07-27 11:07 ` Maarten Lankhorst
2015-07-27 11:14 ` Daniel Vetter
2015-07-27 11:55 ` [Intel-gfx] " Maarten Lankhorst
2015-07-16 12:57 ` [PATCH 3/5] drm/i915: Make prepare_plane_fb fully interruptible Maarten Lankhorst
2015-07-16 12:57 ` [PATCH 4/5] drm/i915: Remove wait_for_pending_flips from disable_noatomic Maarten Lankhorst
2015-07-21 11:35 ` Chris Wilson
2015-07-21 12:38 ` Maarten Lankhorst
2015-07-21 12:40 ` Chris Wilson
2015-07-21 12:47 ` Maarten Lankhorst
2015-07-16 12:57 ` [PATCH 5/5] drm/i915: Make wait_for_flips interruptible Maarten Lankhorst
2015-07-20 14:52 ` Maarten Lankhorst [this message]
2015-07-21 6:51 ` Daniel Vetter
2015-07-21 8:02 ` Maarten Lankhorst
2015-07-21 11:26 ` Chris Wilson
2015-07-21 12:33 ` Maarten Lankhorst
2015-07-21 13:31 ` Chris Wilson
2015-07-21 13:59 ` Maarten Lankhorst
2015-07-21 14:39 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55AD0B1B.90703@linux.intel.com \
--to=maarten.lankhorst@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox