From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sivakumar Thulasimani Subject: Re: [PATCH 1/3] drm/i915: combine i9xx_get_hpd_pins and pch_get_hpd_pins Date: Tue, 21 Jul 2015 13:50:17 +0530 Message-ID: <55AE00C1.2050402@intel.com> References: <1437428619-30160-1-git-send-email-imre.deak@intel.com> <1437428619-30160-2-git-send-email-imre.deak@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 974A06E008 for ; Tue, 21 Jul 2015 01:20:19 -0700 (PDT) In-Reply-To: <1437428619-30160-2-git-send-email-imre.deak@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Imre Deak , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org CgpPbiA3LzIxLzIwMTUgMzoxMyBBTSwgSW1yZSBEZWFrIHdyb3RlOgo+IFRoZXNlIGZ1bmN0aW9u cyBhcmUgcXVpdGUgc2ltaWxhciwgc28gY29tYmluZSB0aGVtIHdpdGggdGhlIHVzZSBvZiBhIG5l dwo+IGFyZ3VtZW50IGZvciBhIGZ1bmN0aW9uIHRoYXQgZGV0ZWN0cyBsb25nIHB1bHNlcy4gVGhp cyB3aWxsIGJlIGFsc28KPiBuZWVkZWQgYnkgYW4gdXBjb21pbmcgcGF0Y2ggYWRkaW5nIHN1cHBv cnQgZm9yIEJYVCBsb25nIHB1bHNlIGRldGVjdGlvbi4KPgo+IE5vIGZ1bmN0aW9uYWwgY2hhbmdl Lgo+Cj4gU2lnbmVkLW9mZi1ieTogSW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50ZWwuY29tPgo+IC0t LQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYyB8IDU0ICsrKysrKysrKysrKysr LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gICAxIGZpbGUgY2hhbmdlZCwgMTggaW5zZXJ0 aW9ucygrKSwgMzYgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9pcnEuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfaXJxLmMKPiBpbmRl eCBhNmZiZTY0Li4zMDZkZTc4IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfaXJxLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jCj4gQEAgLTEy NTYsOSArMTI1NiwxMCBAQCBzdGF0aWMgYm9vbCBpOXh4X3BvcnRfaG90cGx1Z19sb25nX2RldGVj dChlbnVtIHBvcnQgcG9ydCwgdTMyIHZhbCkKPiAgIH0KPiAgIAo+ICAgLyogR2V0IGEgYml0IG1h c2sgb2YgcGlucyB0aGF0IGhhdmUgdHJpZ2dlcmVkLCBhbmQgd2hpY2ggb25lcyBtYXkgYmUgbG9u Zy4gKi8KPiAtc3RhdGljIHZvaWQgcGNoX2dldF9ocGRfcGlucyh1MzIgKnBpbl9tYXNrLCB1MzIg KmxvbmdfbWFzaywKPiArc3RhdGljIHZvaWQgaW50ZWxfZ2V0X2hwZF9waW5zKHUzMiAqcGluX21h c2ssIHUzMiAqbG9uZ19tYXNrLAo+ICAgCQkJICAgICB1MzIgaG90cGx1Z190cmlnZ2VyLCB1MzIg ZGlnX2hvdHBsdWdfcmVnLAo+IC0JCQkgICAgIGNvbnN0IHUzMiBocGRbSFBEX05VTV9QSU5TXSkK PiArCQkJICAgICBjb25zdCB1MzIgaHBkW0hQRF9OVU1fUElOU10sCj4gKwkJCSAgICAgYm9vbCBs b25nX3B1bHNlX2RldGVjdChlbnVtIHBvcnQgcG9ydCwgdTMyIHZhbCkpCj4gICB7Cj4gICAJZW51 bSBwb3J0IHBvcnQ7Cj4gICAJaW50IGk7Cj4gQEAgLTEyNzYsNyArMTI3Nyw3IEBAIHN0YXRpYyB2 b2lkIHBjaF9nZXRfaHBkX3BpbnModTMyICpwaW5fbWFzaywgdTMyICpsb25nX21hc2ssCj4gICAJ CSpwaW5fbWFzayB8PSBCSVQoaSk7Cj4gICAKPiAgIAkJcG9ydCA9IGludGVsX2hwZF9waW5fdG9f cG9ydChpKTsKPiAtCQlpZiAocGNoX3BvcnRfaG90cGx1Z19sb25nX2RldGVjdChwb3J0LCBkaWdf aG90cGx1Z19yZWcpKQo+ICsJCWlmIChsb25nX3B1bHNlX2RldGVjdChwb3J0LCBkaWdfaG90cGx1 Z19yZWcpKQo+ICAgCQkJKmxvbmdfbWFzayB8PSBCSVQoaSk7Cj4gICAJfQo+ICAgCj4gQEAgLTEy ODUsMzQgKzEyODYsNiBAQCBzdGF0aWMgdm9pZCBwY2hfZ2V0X2hwZF9waW5zKHUzMiAqcGluX21h c2ssIHUzMiAqbG9uZ19tYXNrLAo+ICAgCj4gICB9Cj4gICAKPiAtLyogR2V0IGEgYml0IG1hc2sg b2YgcGlucyB0aGF0IGhhdmUgdHJpZ2dlcmVkLCBhbmQgd2hpY2ggb25lcyBtYXkgYmUgbG9uZy4g Ki8KPiAtc3RhdGljIHZvaWQgaTl4eF9nZXRfaHBkX3BpbnModTMyICpwaW5fbWFzaywgdTMyICps b25nX21hc2ssCj4gLQkJCSAgICAgIHUzMiBob3RwbHVnX3RyaWdnZXIsIGNvbnN0IHUzMiBocGRb SFBEX05VTV9QSU5TXSkKPiAtewo+IC0JZW51bSBwb3J0IHBvcnQ7Cj4gLQlpbnQgaTsKPiAtCj4g LQkqcGluX21hc2sgPSAwOwo+IC0JKmxvbmdfbWFzayA9IDA7Cj4gLQo+IC0JaWYgKCFob3RwbHVn X3RyaWdnZXIpCj4gLQkJcmV0dXJuOwo+IC0KPiAtCWZvcl9lYWNoX2hwZF9waW4oaSkgewo+IC0J CWlmICgoaHBkW2ldICYgaG90cGx1Z190cmlnZ2VyKSA9PSAwKQo+IC0JCQljb250aW51ZTsKPiAt Cj4gLQkJKnBpbl9tYXNrIHw9IEJJVChpKTsKPiAtCj4gLQkJcG9ydCA9IGludGVsX2hwZF9waW5f dG9fcG9ydChpKTsKPiAtCQlpZiAoaTl4eF9wb3J0X2hvdHBsdWdfbG9uZ19kZXRlY3QocG9ydCwg aG90cGx1Z190cmlnZ2VyKSkKPiAtCQkJKmxvbmdfbWFzayB8PSBCSVQoaSk7Cj4gLQl9Cj4gLQo+ IC0JRFJNX0RFQlVHX0RSSVZFUigiaG90cGx1ZyBldmVudCByZWNlaXZlZCwgc3RhdCAweCUwOHgs IHBpbnMgMHglMDh4XG4iLAo+IC0JCQkgaG90cGx1Z190cmlnZ2VyLCAqcGluX21hc2spOwo+IC19 Cj4gLQo+ICAgc3RhdGljIHZvaWQgZ21idXNfaXJxX2hhbmRsZXIoc3RydWN0IGRybV9kZXZpY2Ug KmRldikKPiAgIHsKPiAgIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBkZXYt PmRldl9wcml2YXRlOwo+IEBAIC0xNTUwLDcgKzE1MjMsOSBAQCBzdGF0aWMgdm9pZCBpOXh4X2hw ZF9pcnFfaGFuZGxlcihzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ICAgCWlmIChJU19HNFgoZGV2 KSB8fCBJU19WQUxMRVlWSUVXKGRldikpIHsKPiAgIAkJdTMyIGhvdHBsdWdfdHJpZ2dlciA9IGhv dHBsdWdfc3RhdHVzICYgSE9UUExVR19JTlRfU1RBVFVTX0c0WDsKPiAgIAo+IC0JCWk5eHhfZ2V0 X2hwZF9waW5zKCZwaW5fbWFzaywgJmxvbmdfbWFzaywgaG90cGx1Z190cmlnZ2VyLCBocGRfc3Rh dHVzX2c0eCk7Cj4gKwkJaW50ZWxfZ2V0X2hwZF9waW5zKCZwaW5fbWFzaywgJmxvbmdfbWFzaywg aG90cGx1Z190cmlnZ2VyLAo+ICsJCQkJICAgaG90cGx1Z190cmlnZ2VyLCBocGRfc3RhdHVzX2c0 eCwKPiArCQkJCSAgIGk5eHhfcG9ydF9ob3RwbHVnX2xvbmdfZGV0ZWN0KTsKPiAgIAkJaW50ZWxf aHBkX2lycV9oYW5kbGVyKGRldiwgcGluX21hc2ssIGxvbmdfbWFzayk7Cj4gICAKPiAgIAkJaWYg KGhvdHBsdWdfc3RhdHVzICYgRFBfQVVYX0NIQU5ORUxfTUFTS19JTlRfU1RBVFVTX0c0WCkKPiBA QCAtMTU1OCw3ICsxNTMzLDkgQEAgc3RhdGljIHZvaWQgaTl4eF9ocGRfaXJxX2hhbmRsZXIoc3Ry dWN0IGRybV9kZXZpY2UgKmRldikKPiAgIAl9IGVsc2Ugewo+ICAgCQl1MzIgaG90cGx1Z190cmln Z2VyID0gaG90cGx1Z19zdGF0dXMgJiBIT1RQTFVHX0lOVF9TVEFUVVNfSTkxNTsKPiAgIAo+IC0J CWk5eHhfZ2V0X2hwZF9waW5zKCZwaW5fbWFzaywgJmxvbmdfbWFzaywgaG90cGx1Z190cmlnZ2Vy LCBocGRfc3RhdHVzX2k5MTUpOwo+ICsJCWludGVsX2dldF9ocGRfcGlucygmcGluX21hc2ssICZs b25nX21hc2ssIGhvdHBsdWdfdHJpZ2dlciwKPiArCQkJCSAgIGhvdHBsdWdfdHJpZ2dlciwgaHBk X3N0YXR1c19nNHgsCj4gKwkJCQkgICBpOXh4X3BvcnRfaG90cGx1Z19sb25nX2RldGVjdCk7Cj4g ICAJCWludGVsX2hwZF9pcnFfaGFuZGxlcihkZXYsIHBpbl9tYXNrLCBsb25nX21hc2spOwo+ICAg CX0KPiAgIH0KPiBAQCAtMTY2NCw3ICsxNjQxLDkgQEAgc3RhdGljIHZvaWQgaWJ4X2lycV9oYW5k bGVyKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHUzMiBwY2hfaWlyKQo+ICAgCWRpZ19ob3RwbHVn X3JlZyA9IEk5MTVfUkVBRChQQ0hfUE9SVF9IT1RQTFVHKTsKPiAgIAlJOTE1X1dSSVRFKFBDSF9Q T1JUX0hPVFBMVUcsIGRpZ19ob3RwbHVnX3JlZyk7Cj4gICAKPiAtCXBjaF9nZXRfaHBkX3BpbnMo JnBpbl9tYXNrLCAmbG9uZ19tYXNrLCBob3RwbHVnX3RyaWdnZXIsIGRpZ19ob3RwbHVnX3JlZywg aHBkX2lieCk7Cj4gKwlpbnRlbF9nZXRfaHBkX3BpbnMoJnBpbl9tYXNrLCAmbG9uZ19tYXNrLCBo b3RwbHVnX3RyaWdnZXIsCj4gKwkJCSAgIGRpZ19ob3RwbHVnX3JlZywgaHBkX2lieCwKPiArCQkJ ICAgcGNoX3BvcnRfaG90cGx1Z19sb25nX2RldGVjdCk7Cj4gICAJaW50ZWxfaHBkX2lycV9oYW5k bGVyKGRldiwgcGluX21hc2ssIGxvbmdfbWFzayk7Cj4gICAKPiAgIAlpZiAocGNoX2lpciAmIFNE RV9BVURJT19QT1dFUl9NQVNLKSB7Cj4gQEAgLTE3NjMsNyArMTc0Miw5IEBAIHN0YXRpYyB2b2lk IGNwdF9pcnFfaGFuZGxlcihzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB1MzIgcGNoX2lpcikKPiAg IAlkaWdfaG90cGx1Z19yZWcgPSBJOTE1X1JFQUQoUENIX1BPUlRfSE9UUExVRyk7Cj4gICAJSTkx NV9XUklURShQQ0hfUE9SVF9IT1RQTFVHLCBkaWdfaG90cGx1Z19yZWcpOwo+ICAgCj4gLQlwY2hf Z2V0X2hwZF9waW5zKCZwaW5fbWFzaywgJmxvbmdfbWFzaywgaG90cGx1Z190cmlnZ2VyLCBkaWdf aG90cGx1Z19yZWcsIGhwZF9jcHQpOwo+ICsJaW50ZWxfZ2V0X2hwZF9waW5zKCZwaW5fbWFzaywg JmxvbmdfbWFzaywgaG90cGx1Z190cmlnZ2VyLAo+ICsJCQkgICBkaWdfaG90cGx1Z19yZWcsIGhw ZF9jcHQsCj4gKwkJCSAgIHBjaF9wb3J0X2hvdHBsdWdfbG9uZ19kZXRlY3QpOwo+ICAgCWludGVs X2hwZF9pcnFfaGFuZGxlcihkZXYsIHBpbl9tYXNrLCBsb25nX21hc2spOwo+ICAgCj4gICAJaWYg KHBjaF9paXIgJiBTREVfQVVESU9fUE9XRVJfTUFTS19DUFQpIHsKPiBAQCAtMTk3OSw3ICsxOTYw LDggQEAgc3RhdGljIHZvaWQgYnh0X2hwZF9oYW5kbGVyKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYs IHVpbnQzMl90IGlpcl9zdGF0dXMpCj4gICAJLyogQ2xlYXIgc3RpY2t5IGJpdHMgaW4gaHBkIHN0 YXR1cyAqLwo+ICAgCUk5MTVfV1JJVEUoQlhUX0hPVFBMVUdfQ1RMLCBocF9jb250cm9sKTsKPiAg IAo+IC0JcGNoX2dldF9ocGRfcGlucygmcGluX21hc2ssICZsb25nX21hc2ssIGhwX3RyaWdnZXIs IGhwX2NvbnRyb2wsIGhwZF9ieHQpOwo+ICsJaW50ZWxfZ2V0X2hwZF9waW5zKCZwaW5fbWFzaywg JmxvbmdfbWFzaywgaHBfdHJpZ2dlciwgaHBfY29udHJvbCwKPiArCQkJICAgaHBkX2J4dCwgcGNo X3BvcnRfaG90cGx1Z19sb25nX2RldGVjdCk7Cj4gICAJaW50ZWxfaHBkX2lycV9oYW5kbGVyKGRl diwgcGluX21hc2ssIGxvbmdfbWFzayk7Cj4gICB9Cj4gICAKYSB3aGF0IGlmIHF1ZXN0aW9uIDop LCBiZWZvcmUgdGhpcyBjaGFuZ2Ugb25seSBpbnRlbF9ocGRfaXJxX2hhbmRsZXIgd2FzIApwbGF0 Zm9ybSBpbmRlcGVuZGVudCBhbmQKaXQgd2FzIGluIGludGVsX2hvdHBsdWcuYyBmaWxlLiBOb3cg d2UgaGF2ZSBvbmUgbW9yZSBmdW5jdGlvbiB3aGljaCBpcyAKKGkgYW0gYXNzdW1pbmcpIHBsYXRm b3JtIGluZGVwZW5kZW50CmFuZCBpcyBhbHdheXMgY2FsbGVkIGJlZm9yZSBpbnRlbF9ocGRfaXJx X2hhbmRsZXIuCgpjYW4gd2UgbW92ZSB0aGUgaW50ZWxfZ2V0X2hwZF9waW5zIHRvIGludGVsX2hv dHBsdWcuYyBieSByZW5tYWluZyBpdCBhcyAKaW50ZWxfaHBkX2dldF9waW5zICYgY2FsbCB0aGUK aW50ZWxfaHBkX2lycV9oYW5kbGVyIGZ1bmN0aW9uIGF0IHRoZSBlbmQgb2YgdGhpcyBuZXcgZnVu Y3Rpb24gPwoKLS0gCnJlZ2FyZHMsClNpdmFrdW1hcgoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9pbnRlbC1nZngK