From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 4/5] drm/i915: Remove wait_for_pending_flips from disable_noatomic.
Date: Tue, 21 Jul 2015 14:38:14 +0200 [thread overview]
Message-ID: <55AE3D36.3090902@linux.intel.com> (raw)
In-Reply-To: <20150721113558.GG6166@nuc-i3427.alporthouse.com>
Op 21-07-15 om 13:35 schreef Chris Wilson:
> On Thu, Jul 16, 2015 at 02:57:50PM +0200, Maarten Lankhorst wrote:
>> Now that intel_display_suspend is atomic it's safe to remove
>> wait_for_pending_flips from intel_crtc_disable_noatomic. It
>> will only be used during hw load or resume, in which case there
>> will be no pending flips anyway.
> A WARN_ON(pending_flip) then? (Actually we should start doing
> DRM_ERROR_ON I guess that would make a lot of complaints go away, and
> also a lot of genuine bug reports) Or do we have warning coverage
> elsewhere along the CRTC change path?
intel_sanitize_crtc, called during hw readout, is the only caller of intel_crtc_disable_noatomic.
During hw readout no sw updates should be queued anyway..
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-07-21 12:38 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-16 12:57 [PATCH 0/5] drm/i915: Make waiting interruptible Maarten Lankhorst
2015-07-16 12:57 ` [PATCH 1/5] drm/i915: Handle return value in intel_pin_and_fence_fb_obj Maarten Lankhorst
2015-07-21 11:31 ` Chris Wilson
2015-07-21 14:09 ` [PATCH v1.1 1/5] drm/i915: Handle return value in intel_pin_and_fence_fb_obj, v2 Maarten Lankhorst
2015-07-24 13:26 ` Ander Conselvan De Oliveira
2015-07-24 14:02 ` Chris Wilson
2015-07-26 7:24 ` Maarten Lankhorst
2015-07-16 12:57 ` [PATCH 2/5] drm/atomic: Make prepare_fb/cleanup_fb only take state Maarten Lankhorst
2015-07-16 14:13 ` [PATCH v1.1 2/5] drm/atomic: Make prepare_fb/cleanup_fb only take state, v2 Maarten Lankhorst
2015-07-22 13:23 ` Rob Clark
2015-07-27 7:53 ` [Intel-gfx] " Daniel Vetter
2015-07-27 11:07 ` Maarten Lankhorst
2015-07-27 11:14 ` Daniel Vetter
2015-07-27 11:55 ` [Intel-gfx] " Maarten Lankhorst
2015-07-16 12:57 ` [PATCH 3/5] drm/i915: Make prepare_plane_fb fully interruptible Maarten Lankhorst
2015-07-16 12:57 ` [PATCH 4/5] drm/i915: Remove wait_for_pending_flips from disable_noatomic Maarten Lankhorst
2015-07-21 11:35 ` Chris Wilson
2015-07-21 12:38 ` Maarten Lankhorst [this message]
2015-07-21 12:40 ` Chris Wilson
2015-07-21 12:47 ` Maarten Lankhorst
2015-07-16 12:57 ` [PATCH 5/5] drm/i915: Make wait_for_flips interruptible Maarten Lankhorst
2015-07-20 14:52 ` Maarten Lankhorst
2015-07-21 6:51 ` Daniel Vetter
2015-07-21 8:02 ` Maarten Lankhorst
2015-07-21 11:26 ` Chris Wilson
2015-07-21 12:33 ` Maarten Lankhorst
2015-07-21 13:31 ` Chris Wilson
2015-07-21 13:59 ` Maarten Lankhorst
2015-07-21 14:39 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55AE3D36.3090902@linux.intel.com \
--to=maarten.lankhorst@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox