From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH 5/6] drm/i915: Make updating pipe without modeset atomic. Date: Tue, 21 Jul 2015 16:32:26 +0200 Message-ID: <55AE57FA.3000402@linux.intel.com> References: <1437478142-416-1-git-send-email-maarten.lankhorst@linux.intel.com> <1437478142-416-6-git-send-email-maarten.lankhorst@linux.intel.com> <20150721141422.GP16722@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 86D996E7F9 for ; Tue, 21 Jul 2015 07:32:28 -0700 (PDT) In-Reply-To: <20150721141422.GP16722@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T3AgMjEtMDctMTUgb20gMTY6MTQgc2NocmVlZiBEYW5pZWwgVmV0dGVyOgo+IE9uIFR1ZSwgSnVs IDIxLCAyMDE1IGF0IDAxOjI5OjAxUE0gKzAyMDAsIE1hYXJ0ZW4gTGFua2hvcnN0IHdyb3RlOgo+ PiBJbnN0ZWFkIG9mIGRvaW5nIGEgaGFjayBkdXJpbmcgcHJpbWFyeSBwbGFuZSBjb21taXQgdGhl IHN0YXRlCj4+IGlzIHVwZGF0ZWQgZHVyaW5nIGF0b21pYyBldmFzaW9uLiBJdCBoYW5kbGVzIGRp ZmZlcmVuY2VzIGluCj4+IHBpcGUgc2l6ZSBhbmQgdGhlIHBhbmVsIGZpdHRlci4KPj4KPj4gVGhp cyBpcyBjb250aW51aW5nIG9uIHRvcCBvZiBEYW5pZWwncyB3b3JrIHRvIG1ha2UgZmFzdGVyCj4+ IG1vZGVzZXRzIGF0b21pYywgYW5kIG5vdCB5ZXQgZW5hYmxlZCBieSBkZWZhdWx0Lgo+Pgo+PiBT aWduZWQtb2ZmLWJ5OiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXgu aW50ZWwuY29tPgo+PiAtLS0KPj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2F0b21pYy5j ICB8ICAyICstCj4+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCA5MyAr KysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0KPj4gIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2Rydi5oICAgICB8ICAyICsKPj4gIDMgZmlsZXMgY2hhbmdlZCwgNTUgaW5zZXJ0 aW9ucygrKSwgNDIgZGVsZXRpb25zKC0pCj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9hdG9taWMuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2F0b21p Yy5jCj4+IGluZGV4IDA5YTBhZDYxMTAwMi4uNThkNjJmYmU5NjFiIDEwMDY0NAo+PiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9hdG9taWMuYwo+PiArKysgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9hdG9taWMuYwo+PiBAQCAtOTgsOCArOTgsOCBAQCBpbnRlbF9jcnRjX2R1 cGxpY2F0ZV9zdGF0ZShzdHJ1Y3QgZHJtX2NydGMgKmNydGMpCj4+ICAJCXJldHVybiBOVUxMOwo+ PiAgCj4+ICAJX19kcm1fYXRvbWljX2hlbHBlcl9jcnRjX2R1cGxpY2F0ZV9zdGF0ZShjcnRjLCAm Y3J0Y19zdGF0ZS0+YmFzZSk7Cj4+IC0KPj4gIAljcnRjX3N0YXRlLT5iYXNlLmNydGMgPSBjcnRj Owo+PiArCWNydGNfc3RhdGUtPnVwZGF0ZV9waXBlID0gZmFsc2U7Cj4+ICAKPj4gIAlyZXR1cm4g JmNydGNfc3RhdGUtPmJhc2U7Cj4+ICB9Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5 LmMKPj4gaW5kZXggNDQzMzI4MDMzOTgxLi40ODBiMjMzNmM3YmEgMTAwNjQ0Cj4+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+PiArKysgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPj4gQEAgLTEwOCw2ICsxMDgsOSBAQCBzdGF0aWMgdm9p ZCBza2xfaW5pdF9zY2FsZXJzKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHN0cnVjdCBpbnRlbF9j cnRjICppbnRlbF9jcgo+PiAgCXN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlKTsK Pj4gIHN0YXRpYyBpbnQgaTl4eF9nZXRfcmVmY2xrKGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0 YXRlICpjcnRjX3N0YXRlLAo+PiAgCQkJICAgaW50IG51bV9jb25uZWN0b3JzKTsKPj4gK3N0YXRp YyB2b2lkIHNreWxha2VfcGZpdF9lbmFibGUoc3RydWN0IGludGVsX2NydGMgKmNydGMpOwo+PiAr c3RhdGljIHZvaWQgaXJvbmxha2VfcGZpdF9kaXNhYmxlKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRj LCBib29sIGZvcmNlKTsKPj4gK3N0YXRpYyB2b2lkIGlyb25sYWtlX3BmaXRfZW5hYmxlKHN0cnVj dCBpbnRlbF9jcnRjICpjcnRjKTsKPj4gIHN0YXRpYyB2b2lkIGludGVsX21vZGVzZXRfc2V0dXBf aHdfc3RhdGUoc3RydWN0IGRybV9kZXZpY2UgKmRldik7Cj4+ICAKPj4gIHR5cGVkZWYgc3RydWN0 IHsKPj4gQEAgLTMyNjgsMTQgKzMyNzEsMTcgQEAgc3RhdGljIGJvb2wgaW50ZWxfY3J0Y19oYXNf cGVuZGluZ19mbGlwKHN0cnVjdCBkcm1fY3J0YyAqY3J0YykKPj4gIAlyZXR1cm4gcGVuZGluZzsK Pj4gIH0KPj4gIAo+PiAtc3RhdGljIHZvaWQgaW50ZWxfdXBkYXRlX3BpcGVfc2l6ZShzdHJ1Y3Qg aW50ZWxfY3J0YyAqY3J0YykKPj4gK3N0YXRpYyB2b2lkIGludGVsX3VwZGF0ZV9waXBlX2NvbmZp ZyhzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YywKPj4gKwkJCQkgICAgIHN0cnVjdCBpbnRlbF9jcnRj X3N0YXRlICpvbGRfY3J0Y19zdGF0ZSkKPiB1cGF0ZV9waXBlX2NvbmZpZyBzb3VuZHMgbGlrZSBp dCdzIGp1c3QgdXBkYXRpbmcgdGhlIGh3IHN0YXRlLiBNYXliZSBjYWxsCj4gaXQgaW50ZWxfZmFz dHNldF9jcnRjIG9yIGludGVsX2ZpeHVwX2NydGMgb3IganVzdCBpbnRlbF91cGRhdGVfY3J0Yz8g VGhlCj4gb3RoZXIgZnVuY3Rpb25zIGFyZSBhbHNvIGNhbGxlZCBjcnRjX2VuYWJsZS9kaXNhYmxl LCBzbyBnb2luZyB3aXRoIGNydGMKPiBzZWVtcyBtb3JlIGNvbnNpc3RlbnQuCmludGVsX2NydGNf dXBkYXRlX3BpcGUgPwoKPj4gIHsKPj4gIAlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gY3J0Yy0+ YmFzZS5kZXY7Cj4+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZGV2LT5k ZXZfcHJpdmF0ZTsKPj4gLQljb25zdCBzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqYWRqdXN0ZWRf bW9kZTsKPj4gKwlzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqcGlwZV9jb25maWcgPQo+PiArCQl0 b19pbnRlbF9jcnRjX3N0YXRlKGNydGMtPmJhc2Uuc3RhdGUpOwo+PiAgCj4+IC0JaWYgKCFpOTE1 LmZhc3Rib290KQo+PiAtCQlyZXR1cm47Cj4+ICsJRFJNX0RFQlVHX0tNUygiVXBkYXRpbmcgcGlw ZSBzaXplICVpeCVpIC0+ICVpeCVpXG4iLAo+PiArCQkgICAgICBvbGRfY3J0Y19zdGF0ZS0+cGlw ZV9zcmNfdywgb2xkX2NydGNfc3RhdGUtPnBpcGVfc3JjX2gsCj4+ICsJCSAgICAgIHBpcGVfY29u ZmlnLT5waXBlX3NyY193LCBwaXBlX2NvbmZpZy0+cGlwZV9zcmNfaCk7Cj4+ICAKPj4gIAlpZiAo SEFTX0RESShkZXYpKQo+PiAgCQlpbnRlbF9zZXRfcGlwZV9jc2MoJmNydGMtPmJhc2UpOwo+PiBA QCAtMzI4NywyNyArMzI5MywyNiBAQCBzdGF0aWMgdm9pZCBpbnRlbF91cGRhdGVfcGlwZV9zaXpl KHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjKQo+PiAgCSAqIGZhc3Rib290IGNhc2UsIHdlJ2xsIGZs aXAsIGJ1dCBpZiB3ZSBkb24ndCB1cGRhdGUgdGhlIHBpcGVzcmMgYW5kCj4+ICAJICogcGZpdCBz dGF0ZSwgd2UnbGwgZW5kIHVwIHdpdGggYSBiaWcgZmIgc2Nhbm5lZCBvdXQgaW50byB0aGUgd3Jv bmcKPj4gIAkgKiBzaXplZCBzdXJmYWNlLgo+PiAtCSAqCj4+IC0JICogVG8gZml4IHRoaXMgcHJv cGVybHksIHdlIG5lZWQgdG8gaG9pc3QgdGhlIGNoZWNrcyB1cCBpbnRvCj4+IC0JICogY29tcHV0 ZV9tb2RlX2NoYW5nZXMgKG9yIGFib3ZlKSwgY2hlY2sgdGhlIGFjdHVhbCBwZml0IHN0YXRlIGFu ZAo+PiAtCSAqIHdoZXRoZXIgdGhlIHBsYXRmb3JtIGFsbG93cyBwZml0IGRpc2FibGUgd2l0aCBw aXBlIGFjdGl2ZSwgYW5kIG9ubHkKPj4gLQkgKiB0aGVuIHVwZGF0ZSB0aGUgcGlwZXNyYyBhbmQg cGZpdCBzdGF0ZSwgZXZlbiBvbiB0aGUgZmxpcCBwYXRoLgo+PiAgCSAqLwo+PiAgCj4+IC0JYWRq dXN0ZWRfbW9kZSA9ICZjcnRjLT5jb25maWctPmJhc2UuYWRqdXN0ZWRfbW9kZTsKPj4gLQo+PiAg CUk5MTVfV1JJVEUoUElQRVNSQyhjcnRjLT5waXBlKSwKPj4gLQkJICAgKChhZGp1c3RlZF9tb2Rl LT5jcnRjX2hkaXNwbGF5IC0gMSkgPDwgMTYpIHwKPj4gLQkJICAgKGFkanVzdGVkX21vZGUtPmNy dGNfdmRpc3BsYXkgLSAxKSk7Cj4+IC0JaWYgKCFjcnRjLT5jb25maWctPnBjaF9wZml0LmVuYWJs ZWQgJiYKPj4gLQkgICAgKGludGVsX3BpcGVfaGFzX3R5cGUoY3J0YywgSU5URUxfT1VUUFVUX0xW RFMpIHx8Cj4+IC0JICAgICBpbnRlbF9waXBlX2hhc190eXBlKGNydGMsIElOVEVMX09VVFBVVF9F RFApKSkgewo+PiAtCQlJOTE1X1dSSVRFKFBGX0NUTChjcnRjLT5waXBlKSwgMCk7Cj4+IC0JCUk5 MTVfV1JJVEUoUEZfV0lOX1BPUyhjcnRjLT5waXBlKSwgMCk7Cj4+IC0JCUk5MTVfV1JJVEUoUEZf V0lOX1NaKGNydGMtPnBpcGUpLCAwKTsKPj4gKwkJICAgKChwaXBlX2NvbmZpZy0+cGlwZV9zcmNf dyAtIDEpIDw8IDE2KSB8Cj4+ICsJCSAgIChwaXBlX2NvbmZpZy0+cGlwZV9zcmNfaCAtIDEpKTsK Pj4gKwo+PiArCS8qIG9uIHNreWxha2UgdGhpcyBpcyBkb25lIGJ5IGRldGFjaGluZyBzY2FsZXJz ICovCj4+ICsJaWYgKElOVEVMX0lORk8oZGV2KS0+Z2VuID09IDkpIHsKPj4gKwkJc2tsX2RldGFj aF9zY2FsZXJzKGNydGMpOwo+PiArCj4+ICsJCWlmIChwaXBlX2NvbmZpZy0+cGNoX3BmaXQuZW5h YmxlZCkKPj4gKwkJCXNreWxha2VfcGZpdF9lbmFibGUoY3J0Yyk7Cj4+ICsJfQo+PiArCWVsc2Ug aWYgKElOVEVMX0lORk8oZGV2KS0+Z2VuIDwgOSAmJgo+PiArCSAgICAgICAgIEhBU19QQ0hfU1BM SVQoZGV2KSkgewo+PiArCQlpZiAocGlwZV9jb25maWctPnBjaF9wZml0LmVuYWJsZWQpCj4+ICsJ CQlpcm9ubGFrZV9wZml0X2VuYWJsZShjcnRjKTsKPj4gKwkJZWxzZSBpZiAob2xkX2NydGNfc3Rh dGUtPnBjaF9wZml0LmVuYWJsZWQpCj4+ICsJCQlpcm9ubGFrZV9wZml0X2Rpc2FibGUoY3J0Yywg dHJ1ZSk7Cj4gSWlyYyBKZXNzZSdzIGV4cGVyaW1lbnRzIHNob3dlZCB0aGF0IHlvdSBjb3VsZCBv bmx5IGRpc2FibGUgdGhlIHBmaXQKPiB3aXRob3V0IGEgbW9kZXNldCwgYnV0IG5vdCBlbmFibGUg aXQgd2l0aG91dCBhIG1vZGVzZXQuIE5vdCBzdXJlIGhvdyB0aGF0Cj4gd29ya3Mgb24gc2tsLCBi dXQgdGhhdCdzIHdoYXQgSSByZW1lbWJlciBmb3IgZWFsaWVyIHBsYXRmb3JtcyBhdCBsZWFzdC4K SXMgdGhhdCByZWFsbHkgdGhlIGNhc2UsIG9yIGJlY2F1c2Ugb2YgdGhlIHBvd2VyIGRvbWFpbiB1 cGRhdGVzPyBXaGljaCwgY29tZSB0byB0aGluayBvZiBpdCwgSSBkb24ndApoYW5kbGUgY29ycmVj dGx5IGluIHRoaXMgcGF0Y2guIDovCgppbnRlbF9kZGlfZW5hYmxlX3RyYW5zY29kZXJfZnVuYyBz ZWVtcyB0byBoYXZlIGEgc3BlY2lhbCBjYXNlIGZvciBoYXN3ZWxsIG9uIGVEUCB3aXRoIHBhbmVs IGZpdHRlciBvbi9vZmYuClNvIHBlcmhhcHMgZGlzYWxsb3cgb2ZmIC0+IG9uIHdpdGggaGFzd2Vs bC4KCkJyb2Fkd2VsbCBtaWdodCBub3QgYmUgYWJsZSB0byBjaGFuZ2UgcGFuZWwgZml0dGVyIGZy b20gb24gdG8gb2ZmLCBiZWNhdXNlIG9mIGNkY2xrIGNhbGN1bGF0aW9uczoKYnJvYWR3ZWxsX21v ZGVzZXRfY2FsY19jZGNsayAtPiBpbGtfbWF4X3BpeGVsX3JhdGUgLT4gaWxrX3BpcGVfcGl4ZWxf cmF0ZQoKVGhvc2UgcmVhc29ucyBtaWdodCBiZSBjb250cmlidXRpbmcgdG8gZmFpbHVyZXMuCgo+ IEFsc28gaXQgc2hvdWxkIHdvcmsgdGhlIHNhbWUgZm9yIGdtY2ggcGxhdGZvcm1zIHJlYWxseS4K UHJvYmFibHksIGJ1dCBJIHdhc24ndCBhYmxlIHRvIHRlc3QgaXQgYW5kIGN1cnJlbnQgY29kZSBk aWRuJ3Qgc2VlbSB0byBoYW5kbGUgaXQuCgo+IEFsc28gYmlnIHRoaW5nIHN0aWxsIG1pc3Npbmcg aXMgdGhlIHNwZWNpYWwgdGVzdGNhc2Ugd2hpY2ggZG9lcyBkaXJlY3QKPiBtb2Rlc2V0cyB0cnlp bmcgdG8gZm9yY2UgZmFzdHNldCBwZml0IGNoYW5nZXMgb24gZWRwL2RzaS9sdmRzLgpJbmRlZWQh IFdoYXQgc2hvdWxkIEkgZXhwZWN0IG9uIGZhaWx1cmUsIGFuZCBob3cgZG8gSSBkZWZpbmUgc3Vj Y2Vzcz8KCn5NYWFydGVuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVs LWdmeAo=