From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sivakumar Thulasimani Subject: Re: [PATCH 1/3] drm/i915: combine i9xx_get_hpd_pins and pch_get_hpd_pins Date: Wed, 22 Jul 2015 13:43:49 +0530 Message-ID: <55AF50BD.9000107@intel.com> References: <1437428619-30160-1-git-send-email-imre.deak@intel.com> <1437428619-30160-2-git-send-email-imre.deak@intel.com> <55AE00C1.2050402@intel.com> <1437501523.3787.7.camel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTP id 3B4666E30B for ; Wed, 22 Jul 2015 01:13:52 -0700 (PDT) In-Reply-To: <1437501523.3787.7.camel@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: imre.deak@intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org CgpPbiA3LzIxLzIwMTUgMTE6MjggUE0sIEltcmUgRGVhayB3cm90ZToKPiBPbiBUdWUsIDIwMTUt MDctMjEgYXQgMTM6NTAgKzA1MzAsIFNpdmFrdW1hciBUaHVsYXNpbWFuaSB3cm90ZToKPj4gT24g Ny8yMS8yMDE1IDM6MTMgQU0sIEltcmUgRGVhayB3cm90ZToKPj4+IFRoZXNlIGZ1bmN0aW9ucyBh cmUgcXVpdGUgc2ltaWxhciwgc28gY29tYmluZSB0aGVtIHdpdGggdGhlIHVzZSBvZiBhIG5ldwo+ Pj4gYXJndW1lbnQgZm9yIGEgZnVuY3Rpb24gdGhhdCBkZXRlY3RzIGxvbmcgcHVsc2VzLiBUaGlz IHdpbGwgYmUgYWxzbwo+Pj4gbmVlZGVkIGJ5IGFuIHVwY29taW5nIHBhdGNoIGFkZGluZyBzdXBw b3J0IGZvciBCWFQgbG9uZyBwdWxzZSBkZXRlY3Rpb24uCj4+Pgo+Pj4gTm8gZnVuY3Rpb25hbCBj aGFuZ2UuCj4+Pgo+Pj4gU2lnbmVkLW9mZi1ieTogSW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50ZWwu Y29tPgo+Pj4gLS0tCj4+PiAgICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jIHwgNTQg KysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPj4+ICAgIDEgZmlsZSBj aGFuZ2VkLCAxOCBpbnNlcnRpb25zKCspLCAzNiBkZWxldGlvbnMoLSkKPj4+Cj4+PiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfaXJxLmMKPj4+IGluZGV4IGE2ZmJlNjQuLjMwNmRlNzggMTAwNjQ0Cj4+PiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jCj4+PiArKysgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2lycS5jCj4+PiBAQCAtMTI1Niw5ICsxMjU2LDEwIEBAIHN0YXRpYyBib29s IGk5eHhfcG9ydF9ob3RwbHVnX2xvbmdfZGV0ZWN0KGVudW0gcG9ydCBwb3J0LCB1MzIgdmFsKQo+ Pj4gICAgfQo+Pj4gICAgCj4+PiAgICAvKiBHZXQgYSBiaXQgbWFzayBvZiBwaW5zIHRoYXQgaGF2 ZSB0cmlnZ2VyZWQsIGFuZCB3aGljaCBvbmVzIG1heSBiZSBsb25nLiAqLwo+Pj4gLXN0YXRpYyB2 b2lkIHBjaF9nZXRfaHBkX3BpbnModTMyICpwaW5fbWFzaywgdTMyICpsb25nX21hc2ssCj4+PiAr c3RhdGljIHZvaWQgaW50ZWxfZ2V0X2hwZF9waW5zKHUzMiAqcGluX21hc2ssIHUzMiAqbG9uZ19t YXNrLAo+Pj4gICAgCQkJICAgICB1MzIgaG90cGx1Z190cmlnZ2VyLCB1MzIgZGlnX2hvdHBsdWdf cmVnLAo+Pj4gLQkJCSAgICAgY29uc3QgdTMyIGhwZFtIUERfTlVNX1BJTlNdKQo+Pj4gKwkJCSAg ICAgY29uc3QgdTMyIGhwZFtIUERfTlVNX1BJTlNdLAo+Pj4gKwkJCSAgICAgYm9vbCBsb25nX3B1 bHNlX2RldGVjdChlbnVtIHBvcnQgcG9ydCwgdTMyIHZhbCkpCj4+PiAgICB7Cj4+PiAgICAJZW51 bSBwb3J0IHBvcnQ7Cj4+PiAgICAJaW50IGk7Cj4+PiBAQCAtMTI3Niw3ICsxMjc3LDcgQEAgc3Rh dGljIHZvaWQgcGNoX2dldF9ocGRfcGlucyh1MzIgKnBpbl9tYXNrLCB1MzIgKmxvbmdfbWFzaywK Pj4+ICAgIAkJKnBpbl9tYXNrIHw9IEJJVChpKTsKPj4+ICAgIAo+Pj4gICAgCQlwb3J0ID0gaW50 ZWxfaHBkX3Bpbl90b19wb3J0KGkpOwo+Pj4gLQkJaWYgKHBjaF9wb3J0X2hvdHBsdWdfbG9uZ19k ZXRlY3QocG9ydCwgZGlnX2hvdHBsdWdfcmVnKSkKPj4+ICsJCWlmIChsb25nX3B1bHNlX2RldGVj dChwb3J0LCBkaWdfaG90cGx1Z19yZWcpKQo+Pj4gICAgCQkJKmxvbmdfbWFzayB8PSBCSVQoaSk7 Cj4+PiAgICAJfQo+Pj4gICAgCj4+PiBAQCAtMTI4NSwzNCArMTI4Niw2IEBAIHN0YXRpYyB2b2lk IHBjaF9nZXRfaHBkX3BpbnModTMyICpwaW5fbWFzaywgdTMyICpsb25nX21hc2ssCj4+PiAgICAK Pj4+ICAgIH0KPj4+ICAgIAo+Pj4gLS8qIEdldCBhIGJpdCBtYXNrIG9mIHBpbnMgdGhhdCBoYXZl IHRyaWdnZXJlZCwgYW5kIHdoaWNoIG9uZXMgbWF5IGJlIGxvbmcuICovCj4+PiAtc3RhdGljIHZv aWQgaTl4eF9nZXRfaHBkX3BpbnModTMyICpwaW5fbWFzaywgdTMyICpsb25nX21hc2ssCj4+PiAt CQkJICAgICAgdTMyIGhvdHBsdWdfdHJpZ2dlciwgY29uc3QgdTMyIGhwZFtIUERfTlVNX1BJTlNd KQo+Pj4gLXsKPj4+IC0JZW51bSBwb3J0IHBvcnQ7Cj4+PiAtCWludCBpOwo+Pj4gLQo+Pj4gLQkq cGluX21hc2sgPSAwOwo+Pj4gLQkqbG9uZ19tYXNrID0gMDsKPj4+IC0KPj4+IC0JaWYgKCFob3Rw bHVnX3RyaWdnZXIpCj4+PiAtCQlyZXR1cm47Cj4+PiAtCj4+PiAtCWZvcl9lYWNoX2hwZF9waW4o aSkgewo+Pj4gLQkJaWYgKChocGRbaV0gJiBob3RwbHVnX3RyaWdnZXIpID09IDApCj4+PiAtCQkJ Y29udGludWU7Cj4+PiAtCj4+PiAtCQkqcGluX21hc2sgfD0gQklUKGkpOwo+Pj4gLQo+Pj4gLQkJ cG9ydCA9IGludGVsX2hwZF9waW5fdG9fcG9ydChpKTsKPj4+IC0JCWlmIChpOXh4X3BvcnRfaG90 cGx1Z19sb25nX2RldGVjdChwb3J0LCBob3RwbHVnX3RyaWdnZXIpKQo+Pj4gLQkJCSpsb25nX21h c2sgfD0gQklUKGkpOwo+Pj4gLQl9Cj4+PiAtCj4+PiAtCURSTV9ERUJVR19EUklWRVIoImhvdHBs dWcgZXZlbnQgcmVjZWl2ZWQsIHN0YXQgMHglMDh4LCBwaW5zIDB4JTA4eFxuIiwKPj4+IC0JCQkg aG90cGx1Z190cmlnZ2VyLCAqcGluX21hc2spOwo+Pj4gLX0KPj4+IC0KPj4+ICAgIHN0YXRpYyB2 b2lkIGdtYnVzX2lycV9oYW5kbGVyKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4+PiAgICB7Cj4+ PiAgICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZGV2LT5kZXZfcHJpdmF0 ZTsKPj4+IEBAIC0xNTUwLDcgKzE1MjMsOSBAQCBzdGF0aWMgdm9pZCBpOXh4X2hwZF9pcnFfaGFu ZGxlcihzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+Pj4gICAgCWlmIChJU19HNFgoZGV2KSB8fCBJ U19WQUxMRVlWSUVXKGRldikpIHsKPj4+ICAgIAkJdTMyIGhvdHBsdWdfdHJpZ2dlciA9IGhvdHBs dWdfc3RhdHVzICYgSE9UUExVR19JTlRfU1RBVFVTX0c0WDsKPj4+ICAgIAo+Pj4gLQkJaTl4eF9n ZXRfaHBkX3BpbnMoJnBpbl9tYXNrLCAmbG9uZ19tYXNrLCBob3RwbHVnX3RyaWdnZXIsIGhwZF9z dGF0dXNfZzR4KTsKPj4+ICsJCWludGVsX2dldF9ocGRfcGlucygmcGluX21hc2ssICZsb25nX21h c2ssIGhvdHBsdWdfdHJpZ2dlciwKPj4+ICsJCQkJICAgaG90cGx1Z190cmlnZ2VyLCBocGRfc3Rh dHVzX2c0eCwKPj4+ICsJCQkJICAgaTl4eF9wb3J0X2hvdHBsdWdfbG9uZ19kZXRlY3QpOwo+Pj4g ICAgCQlpbnRlbF9ocGRfaXJxX2hhbmRsZXIoZGV2LCBwaW5fbWFzaywgbG9uZ19tYXNrKTsKPj4+ ICAgIAo+Pj4gICAgCQlpZiAoaG90cGx1Z19zdGF0dXMgJiBEUF9BVVhfQ0hBTk5FTF9NQVNLX0lO VF9TVEFUVVNfRzRYKQo+Pj4gQEAgLTE1NTgsNyArMTUzMyw5IEBAIHN0YXRpYyB2b2lkIGk5eHhf aHBkX2lycV9oYW5kbGVyKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4+PiAgICAJfSBlbHNlIHsK Pj4+ICAgIAkJdTMyIGhvdHBsdWdfdHJpZ2dlciA9IGhvdHBsdWdfc3RhdHVzICYgSE9UUExVR19J TlRfU1RBVFVTX0k5MTU7Cj4+PiAgICAKPj4+IC0JCWk5eHhfZ2V0X2hwZF9waW5zKCZwaW5fbWFz aywgJmxvbmdfbWFzaywgaG90cGx1Z190cmlnZ2VyLCBocGRfc3RhdHVzX2k5MTUpOwo+Pj4gKwkJ aW50ZWxfZ2V0X2hwZF9waW5zKCZwaW5fbWFzaywgJmxvbmdfbWFzaywgaG90cGx1Z190cmlnZ2Vy LAo+Pj4gKwkJCQkgICBob3RwbHVnX3RyaWdnZXIsIGhwZF9zdGF0dXNfZzR4LAo+Pj4gKwkJCQkg ICBpOXh4X3BvcnRfaG90cGx1Z19sb25nX2RldGVjdCk7Cj4+PiAgICAJCWludGVsX2hwZF9pcnFf aGFuZGxlcihkZXYsIHBpbl9tYXNrLCBsb25nX21hc2spOwo+Pj4gICAgCX0KPj4+ICAgIH0KPj4+ IEBAIC0xNjY0LDcgKzE2NDEsOSBAQCBzdGF0aWMgdm9pZCBpYnhfaXJxX2hhbmRsZXIoc3RydWN0 IGRybV9kZXZpY2UgKmRldiwgdTMyIHBjaF9paXIpCj4+PiAgICAJZGlnX2hvdHBsdWdfcmVnID0g STkxNV9SRUFEKFBDSF9QT1JUX0hPVFBMVUcpOwo+Pj4gICAgCUk5MTVfV1JJVEUoUENIX1BPUlRf SE9UUExVRywgZGlnX2hvdHBsdWdfcmVnKTsKPj4+ICAgIAo+Pj4gLQlwY2hfZ2V0X2hwZF9waW5z KCZwaW5fbWFzaywgJmxvbmdfbWFzaywgaG90cGx1Z190cmlnZ2VyLCBkaWdfaG90cGx1Z19yZWcs IGhwZF9pYngpOwo+Pj4gKwlpbnRlbF9nZXRfaHBkX3BpbnMoJnBpbl9tYXNrLCAmbG9uZ19tYXNr LCBob3RwbHVnX3RyaWdnZXIsCj4+PiArCQkJICAgZGlnX2hvdHBsdWdfcmVnLCBocGRfaWJ4LAo+ Pj4gKwkJCSAgIHBjaF9wb3J0X2hvdHBsdWdfbG9uZ19kZXRlY3QpOwo+Pj4gICAgCWludGVsX2hw ZF9pcnFfaGFuZGxlcihkZXYsIHBpbl9tYXNrLCBsb25nX21hc2spOwo+Pj4gICAgCj4+PiAgICAJ aWYgKHBjaF9paXIgJiBTREVfQVVESU9fUE9XRVJfTUFTSykgewo+Pj4gQEAgLTE3NjMsNyArMTc0 Miw5IEBAIHN0YXRpYyB2b2lkIGNwdF9pcnFfaGFuZGxlcihzdHJ1Y3QgZHJtX2RldmljZSAqZGV2 LCB1MzIgcGNoX2lpcikKPj4+ICAgIAlkaWdfaG90cGx1Z19yZWcgPSBJOTE1X1JFQUQoUENIX1BP UlRfSE9UUExVRyk7Cj4+PiAgICAJSTkxNV9XUklURShQQ0hfUE9SVF9IT1RQTFVHLCBkaWdfaG90 cGx1Z19yZWcpOwo+Pj4gICAgCj4+PiAtCXBjaF9nZXRfaHBkX3BpbnMoJnBpbl9tYXNrLCAmbG9u Z19tYXNrLCBob3RwbHVnX3RyaWdnZXIsIGRpZ19ob3RwbHVnX3JlZywgaHBkX2NwdCk7Cj4+PiAr CWludGVsX2dldF9ocGRfcGlucygmcGluX21hc2ssICZsb25nX21hc2ssIGhvdHBsdWdfdHJpZ2dl ciwKPj4+ICsJCQkgICBkaWdfaG90cGx1Z19yZWcsIGhwZF9jcHQsCj4+PiArCQkJICAgcGNoX3Bv cnRfaG90cGx1Z19sb25nX2RldGVjdCk7Cj4+PiAgICAJaW50ZWxfaHBkX2lycV9oYW5kbGVyKGRl diwgcGluX21hc2ssIGxvbmdfbWFzayk7Cj4+PiAgICAKPj4+ICAgIAlpZiAocGNoX2lpciAmIFNE RV9BVURJT19QT1dFUl9NQVNLX0NQVCkgewo+Pj4gQEAgLTE5NzksNyArMTk2MCw4IEBAIHN0YXRp YyB2b2lkIGJ4dF9ocGRfaGFuZGxlcihzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB1aW50MzJfdCBp aXJfc3RhdHVzKQo+Pj4gICAgCS8qIENsZWFyIHN0aWNreSBiaXRzIGluIGhwZCBzdGF0dXMgKi8K Pj4+ICAgIAlJOTE1X1dSSVRFKEJYVF9IT1RQTFVHX0NUTCwgaHBfY29udHJvbCk7Cj4+PiAgICAK Pj4+IC0JcGNoX2dldF9ocGRfcGlucygmcGluX21hc2ssICZsb25nX21hc2ssIGhwX3RyaWdnZXIs IGhwX2NvbnRyb2wsIGhwZF9ieHQpOwo+Pj4gKwlpbnRlbF9nZXRfaHBkX3BpbnMoJnBpbl9tYXNr LCAmbG9uZ19tYXNrLCBocF90cmlnZ2VyLCBocF9jb250cm9sLAo+Pj4gKwkJCSAgIGhwZF9ieHQs IHBjaF9wb3J0X2hvdHBsdWdfbG9uZ19kZXRlY3QpOwo+Pj4gICAgCWludGVsX2hwZF9pcnFfaGFu ZGxlcihkZXYsIHBpbl9tYXNrLCBsb25nX21hc2spOwo+Pj4gICAgfQo+Pj4gICAgCj4+IGEgd2hh dCBpZiBxdWVzdGlvbiA6KSwgYmVmb3JlIHRoaXMgY2hhbmdlIG9ubHkgaW50ZWxfaHBkX2lycV9o YW5kbGVyIHdhcwo+PiBwbGF0Zm9ybSBpbmRlcGVuZGVudCBhbmQKPj4gaXQgd2FzIGluIGludGVs X2hvdHBsdWcuYyBmaWxlLiBOb3cgd2UgaGF2ZSBvbmUgbW9yZSBmdW5jdGlvbiB3aGljaCBpcwo+ PiAoaSBhbSBhc3N1bWluZykgcGxhdGZvcm0gaW5kZXBlbmRlbnQKPj4gYW5kIGlzIGFsd2F5cyBj YWxsZWQgYmVmb3JlIGludGVsX2hwZF9pcnFfaGFuZGxlci4KPj4KPj4gY2FuIHdlIG1vdmUgdGhl IGludGVsX2dldF9ocGRfcGlucyB0byBpbnRlbF9ob3RwbHVnLmMgYnkgcmVubWFpbmcgaXQgYXMK Pj4gaW50ZWxfaHBkX2dldF9waW5zICYgY2FsbCB0aGUKPj4gaW50ZWxfaHBkX2lycV9oYW5kbGVy IGZ1bmN0aW9uIGF0IHRoZSBlbmQgb2YgdGhpcyBuZXcgZnVuY3Rpb24gPwo+IFllcywgZmFjdG9y aW5nIG91dCBpbnRlbF9nZXRfaHBkX3BpbnMoKSBhbmQgaW50ZWxfaHBkX2lycV9oYW5kbGVyKCkg aW50bwo+IGEgbmV3IGZ1bmN0aW9uIGlzIGEgZ29vZCBpZGVhLiBJIHRoaW5rIGl0J3MgYmVzdCBk b25lIGFzIGZvbGxvdy11cAo+IHRob3VnaCwgc28gbWF5YmUgeW91IGNvdWxkIGRvIHRoaXMgYWZ0 ZXIgdGhpcyBwYXRjaHNldCBpcyBtZXJnZWQ/Cj4KPiAtLUltcmUKPgpTdXJlIDopIGknbGwgdGFr ZSBpdCB1cCBwb3N0IHRoaXMgZ2V0cyBtZXJnZWQuCgotLSAKcmVnYXJkcywKU2l2YWt1bWFyCgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZngg bWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=