From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: ankitprasad.r.sharma@intel.com, intel-gfx@lists.freedesktop.org
Cc: akash.goel@intel.com, shashidhar.hiremath@intel.com
Subject: Re: [PATCH 1/4] drm/i915: Clearing buffer objects via CPU/GTT
Date: Wed, 22 Jul 2015 16:01:33 +0100 [thread overview]
Message-ID: <55AFB04D.2040909@linux.intel.com> (raw)
In-Reply-To: <1437573109-19211-2-git-send-email-ankitprasad.r.sharma@intel.com>
Hi,
On 07/22/2015 02:51 PM, ankitprasad.r.sharma@intel.com wrote:
> From: Ankitprasad Sharma <ankitprasad.r.sharma@intel.com>
>
> This patch adds support for clearing buffer objects via CPU/GTT. This
> is particularly useful for clearing out the non shmem backed objects.
> Currently intend to use this only for buffers allocated from stolen
> region.
>
> Testcase: igt/gem_stolen
>
> Signed-off-by: Ankitprasad Sharma <ankitprasad.r.sharma@intel.com>
> ---
> drivers/gpu/drm/i915/i915_drv.h | 1 +
> drivers/gpu/drm/i915/i915_gem.c | 34 ++++++++++++++++++++++++++++++++++
> 2 files changed, 35 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index ea9caf2..f6af9c0 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -2764,6 +2764,7 @@ int i915_gem_obj_prepare_shmem_read(struct drm_i915_gem_object *obj,
> int *needs_clflush);
>
> int __must_check i915_gem_object_get_pages(struct drm_i915_gem_object *obj);
> +int i915_gem_clear_object(struct drm_i915_gem_object *obj);
>
> static inline int __sg_page_count(struct scatterlist *sg)
> {
> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
> index a2a4a27..fc434ae 100644
> --- a/drivers/gpu/drm/i915/i915_gem.c
> +++ b/drivers/gpu/drm/i915/i915_gem.c
> @@ -5469,3 +5469,37 @@ bool i915_gem_obj_is_pinned(struct drm_i915_gem_object *obj)
> return false;
> }
>
> +int i915_gem_clear_object(struct drm_i915_gem_object *obj)
Please add kernel doc for the function.
> +{
> + int ret = 0;
No need to set to zero.
> + char __iomem *base;
> + int size = obj->base.size;
I think obj->base.size is a size_t at the moment so this could cause
compiler to warn?
> + struct drm_i915_private *dev_priv = obj->base.dev->dev_private;
Again compiler should warn here due implicit pointer casting? I think
correct is "dev_priv = to_i915(obj->base.dev)".
> + unsigned alignment = 0;
Don't even need this as variable since it is used only once.
> +
> + ret = i915_gem_obj_ggtt_pin(obj, alignment, PIN_MAPPABLE);
> + if (ret) {
> + DRM_ERROR("Mapping of gem object to GTT failed\n");
Maybe end the sentence with "!" ?
> + return ret;
> + }
> +
> + ret = i915_gem_object_put_fence(obj);
> + if (ret)
> + goto unpin;
This I don't understand. Why it is OK to release a fence and never
re-establish it? Could that surprise some callers?
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-07-22 15:01 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-22 13:51 [PATCH v5 0/4] Support for creating/using Stolen memory backed objects ankitprasad.r.sharma
2015-07-22 13:51 ` [PATCH 1/4] drm/i915: Clearing buffer objects via CPU/GTT ankitprasad.r.sharma
2015-07-22 15:01 ` Tvrtko Ursulin [this message]
2015-07-22 15:05 ` Chris Wilson
2015-07-22 15:06 ` Chris Wilson
2015-07-22 15:16 ` Tvrtko Ursulin
2015-07-22 15:23 ` Chris Wilson
2015-07-22 13:51 ` [PATCH 2/4] drm/i915: Support for creating Stolen memory backed objects ankitprasad.r.sharma
2015-07-22 15:14 ` Tvrtko Ursulin
2015-07-22 15:27 ` Chris Wilson
2015-07-22 13:51 ` [PATCH 3/4] drm/i915: Add support for stealing purgable stolen pages ankitprasad.r.sharma
2015-07-22 15:10 ` Chris Wilson
2015-07-27 9:38 ` Daniel Vetter
2015-07-29 12:04 ` Chris Wilson
2015-07-31 14:42 ` Goel, Akash
2015-07-31 15:06 ` Chris Wilson
2015-07-31 16:34 ` Goel, Akash
2015-07-31 14:24 ` Goel, Akash
2015-07-22 13:51 ` [PATCH 4/4] drm/i915: Support for pread/pwrite from/to non shmem backed objects ankitprasad.r.sharma
2015-07-22 14:39 ` Chris Wilson
2015-07-31 13:16 ` Goel, Akash
2015-09-10 17:50 ` Ankitprasad Sharma
2015-09-15 9:58 ` Chris Wilson
2015-07-22 15:46 ` Tvrtko Ursulin
2015-07-22 16:05 ` Daniel Vetter
2015-07-22 16:17 ` Tvrtko Ursulin
-- strict thread matches above, loose matches on Subject: below --
2015-09-15 8:33 [PATCH v6 0/4] Support for creating/using Stolen memory " ankitprasad.r.sharma
2015-09-15 8:33 ` [PATCH 1/4] drm/i915: Clearing buffer objects via CPU/GTT ankitprasad.r.sharma
2015-09-15 14:00 ` Tvrtko Ursulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55AFB04D.2040909@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=akash.goel@intel.com \
--cc=ankitprasad.r.sharma@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=shashidhar.hiremath@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).