Re: [PATCH 3/3] igt/gem_create: Test to validate parameters for GEM_CREATE ioctl

Tvrtko Ursulin
2015-07-23T09:46:10Z

Hi,

On 07/22/2015 02:45 PM, ankitprasad.r.sharma@intel.com wrote:
> From: Ankitprasad Sharma <ankitprasad.r.sharma@intel.com>
>
> This test validates the two parameters (size and flags) GEM_CREATE ioctl.
>
> v2: Added IGT_TEST_DESCRIPTION (Thomas Wood)
>
> v3: Removed use of hard coded values, updated comments (Tvrtko)
>
> Signed-off-by: Ankitprasad Sharma <ankitprasad.r.sharma at intel.com>
> ---
> tests/Makefile.sources | 1 +
> tests/gem_create.c | 170 +++++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 171 insertions(+)
> create mode 100644 tests/gem_create.c
>
> diff --git a/tests/Makefile.sources b/tests/Makefile.sources
> index 324cbb5..f5790df 100644
> --- a/tests/Makefile.sources
> +++ b/tests/Makefile.sources
> @@ -15,6 +15,7 @@ TESTS_progs_M = \
> gem_close_race \
> gem_concurrent_blit \
> gem_concurrent_all \
> + gem_create \
> gem_cs_tlb \
> gem_ctx_param_basic \
> gem_ctx_bad_exec \
> diff --git a/tests/gem_create.c b/tests/gem_create.c
> new file mode 100644
> index 0000000..d2c1189
> --- /dev/null
> +++ b/tests/gem_create.c
> @@ -0,0 +1,170 @@
> +/*
> + * Copyright © 2015 Intel Corporation
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining a
> + * copy of this software and associated documentation files (the "Software"),
> + * to deal in the Software without restriction, including without limitation
> + * the rights to use, copy, modify, merge, publish, distribute, sublicense,
> + * and/or sell copies of the Software, and to permit persons to whom the
> + * Software is furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice (including the next
> + * paragraph) shall be included in all copies or substantial portions of the
> + * Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
> + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
> + * IN THE SOFTWARE.
> + *
> + * Authors:
> + * Ankitprasad Sharma <ankitprasad.r.sharma at intel.com>
> + *
> + */
> +
> +/** @file gem_create.c
> + *
> + * This is a test for the extended and old gem_create ioctl, that
> + * includes allocation of object from stolen memory and shmem.
> + *
> + * The goal is to simply ensure that basics work and invalid input
> + * combinations are rejected.
> + */
> +
> +#include <stdlib.h>
> +#include <sys/ioctl.h>
> +#include <stdio.h>
> +#include <string.h>
> +#include <fcntl.h>
> +#include <inttypes.h>
> +#include <errno.h>
> +#include <sys/stat.h>
> +#include <sys/time.h>
> +#include <getopt.h>
> +
> +#include <drm.h>
> +
> +#include "ioctl_wrappers.h"
> +#include "intel_bufmgr.h"
> +#include "intel_batchbuffer.h"
> +#include "intel_io.h"
> +#include "intel_chipset.h"
> +#include "igt_aux.h"
> +#include "drmtest.h"
> +#include "drm.h"
> +#include "i915_drm.h"
> +
> +IGT_TEST_DESCRIPTION("This is a test for the extended & old gem_create ioctl,"
> + " that includes allocation of object from stolen memory"
> + " and shmem");
> +
> +#define CLEAR(s) memset(&s, 0, sizeof(s))
> +#define UNALIGNED_SIZE (PAGE_SIZE - (2*1024))
> +#define VALID_OFFSET (PAGE_SIZE - 1024)
> +#define INVALID_OFFSET (PAGE_SIZE + 1024)
> +#define LENGTH 256
> +#define DWORD_SIZE 4
> +
> +struct local_i915_gem_create_v2 {
> + uint64_t size;
> + uint32_t handle;
> + uint32_t pad;
> +#define I915_CREATE_PLACEMENT_STOLEN (1<<0)
> + uint32_t flags;
> +} create;
> +
> +#define LOCAL_IOCTL_I915_GEM_CREATE DRM_IOWR(DRM_COMMAND_BASE + DRM_I915_GEM_CREATE, struct local_i915_gem_create_v2)
> +
> +static void invalid_flag_test(int fd)
> +{
> + int ret;
> +
> + gem_require_stolen_support(fd);
> +
> + create.handle = 0;
> + create.size = PAGE_SIZE;
> + create.flags = ~I915_CREATE_PLACEMENT_STOLEN;
> + ret = drmIoctl(fd, LOCAL_IOCTL_I915_GEM_CREATE, &create);
> +
> + igt_assert(ret <= 0);
> +
> + create.flags = ~0;
> + ret = drmIoctl(fd, LOCAL_IOCTL_I915_GEM_CREATE, &create);
> +
> + igt_assert(ret <= 0);
> +}
> +
> +static void invalid_size_test(int fd)
> +{
> + int handle;
> +
> + handle = __gem_create(fd, 0);
> + igt_assert(handle == 0);
> +}
> +
> +/*
> + * Creating an object with non-aligned size and trying to access it with an
> + * offset, which is greater than the requested size but smaller than the
> + * object's last page boundary. pwrite here must be successful.
> + */
> +static void valid_nonaligned_size(int fd)
> +{
> + int handle, i;
> + uint32_t buf[PAGE_SIZE/DWORD_SIZE];

char buf[PAGE_SIZE] and then don't need DWORD_SIZE?

> +
> + handle = gem_create(fd, UNALIGNED_SIZE);
> + igt_assert(handle != 0);
>
> + gem_write(fd, handle, VALID_OFFSET, buf, LENGTH);

In general this is a bit unreadable since you a lot of macros and reader
must jump up and down to figure out what is happening.

Would something simpler just as below be as good and much more readable?

static void ...
{
char buf[PAGE_SIZE];

handle = gem_create(fd, PAGE_SIZE / 2);
igt_assert(handle);

gem_write(fd, handle, 0, buf, PAGE_SIZE);
// or
gem_write(fd, handle, PAGE_SIZE / 2, buf, PAGE_SIZE / 2);
// or even both

gem_close(handle);
}

> + gem_close(fd, handle);
> +}
> +
> +/*
> + * Creating an object with non-aligned size and trying to access it with an
> + * offset, which is greater than the requested size and larger than the
> + * object's last page boundary. pwrite here must fail.
> + */
> +static void invalid_nonaligned_size(int fd)
> +{
> + int handle, i;
> + uint32_t buf[PAGE_SIZE/DWORD_SIZE];
> + struct drm_i915_gem_pwrite gem_pwrite;
> +
> + handle = gem_create(fd, UNALIGNED_SIZE);
> +
> + CLEAR(gem_pwrite);
> + gem_pwrite.handle = handle;
> + gem_pwrite.offset = INVALID_OFFSET;
> + gem_pwrite.size = LENGTH;
> + gem_pwrite.data_ptr = (uintptr_t)buf;
> + igt_assert(drmIoctl(fd, DRM_IOCTL_I915_GEM_PWRITE, &gem_pwrite) != 0);

Not sure if you should check for a specific errno here. Wouldn't harm I
suppose. Plus again (just in principle, not exact code):

static void ...
{
char buf[PAGE_SIZE];

handle = gem_create(fd, PAGE_SIZE / 2);
igt_assert(handle);

// assert all fails
gem_write(fd, handle, PAGE_SIZE, buf, 1);
gem_write(fd, handle, PAGE_SIZE / 2, buf, PAGE_SIZE / 2 + 1);

gem_close(handle);
}

Regards,

Tvrtko