From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [RFC 6/9] drm/i915: Delay the freeing of requests until retire time Date: Thu, 23 Jul 2015 15:25:14 +0100 Message-ID: <55B0F94A.10901@linux.intel.com> References: <1437143483-6234-1-git-send-email-John.C.Harrison@Intel.com> <1437143483-6234-7-git-send-email-John.C.Harrison@Intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTP id 39A216ECA0 for ; Thu, 23 Jul 2015 07:25:16 -0700 (PDT) In-Reply-To: <1437143483-6234-7-git-send-email-John.C.Harrison@Intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: John.C.Harrison@Intel.com, Intel-GFX@Lists.FreeDesktop.Org List-Id: intel-gfx@lists.freedesktop.org CkhpLAoKT24gMDcvMTcvMjAxNSAwMzozMSBQTSwgSm9obi5DLkhhcnJpc29uQEludGVsLmNvbSB3 cm90ZToKPiBGcm9tOiBKb2huIEhhcnJpc29uIDxKb2huLkMuSGFycmlzb25ASW50ZWwuY29tPgo+ Cj4gVGhlIHJlcXVlc3Qgc3RydWN0dXJlIGlzIHJlZmVyZW5jZSBjb3VudGVkLiBXaGVuIHRoZSBj b3VudCByZWFjaGVkCj4gemVybywgdGhlIHJlcXVlc3Qgd2FzIGltbWVkaWF0ZWx5IGZyZWVkIGFu ZCBhbGwgYXNzb2NpYXRlZCBvYmplY3RzCj4gd2VyZSB1bnJlZmVyZWNlZC91bmFsbG9jYXRlZC4g VGhpcyBtZWFudCB0aGF0IHRoZSBkcml2ZXIgbXV0ZXggbG9jawo+IG11c3QgYmUgaGVsZCBhdCB0 aGUgcG9pbnQgd2hlcmUgdGhlIGNvdW50IHJlYWNoZXMgemVyby4gVGhpcyB3YXMgZmluZQo+IHdo aWxlIGFsbCByZWZlcmVuY2VzIHdlcmUgaGVsZCBpbnRlcm5hbGx5IHRvIHRoZSBkcml2ZXIuIEhv d2V2ZXIsIHRoZQo+IHBsYW4gaXMgdG8gYWxsb3cgdGhlIHVuZGVybHlpbmcgZmVuY2Ugb2JqZWN0 IChhbmQgaGVuY2UgdGhlIHJlcXVlc3QKPiBpdHNlbGYpIHRvIGJlIHJldHVybmVkIHRvIG90aGVy IGRyaXZlcnMgYW5kIHRvIHVzZXJsYW5kLiBFeHRlcm5hbAo+IHVzZXJzIGNhbm5vdCBiZSBleHBl Y3RlZCB0byBhY3F1aXJlIGEgZHJpdmVyIHByaXZhdGUgbXV0ZXggbG9jay4KPgo+IFJhdGhlciB0 aGFuIGF0dGVtcHQgdG8gZGlzZW50YW5nbGUgdGhlIHJlcXVlc3Qgc3RydWN0dXJlIGZyb20gdGhl Cj4gZHJpdmVyIG11dGV4IGxvY2ssIHRoZSBkZWNzaW9uIHdhcyB0byBkZWZlciB0aGUgZnJlZSBj b2RlIHVudGlsIGEKPiBsYXRlciAoc2FmZXIpIHBvaW50LiBIZW5jZSB0aGlzIHBhdGNoIGNoYW5n ZXMgdGhlIHVucmVmZXJlbmNlIGNhbGxiYWNrCj4gdG8gbWVyZWx5IG1vdmUgdGhlIHJlcXVlc3Qg b250byBhIGRlbGF5ZWQgZnJlZSBsaXN0LiBUaGUgZHJpdmVyJ3MKPiByZXRpcmUgd29ya2VyIHRo cmVhZCB3aWxsIHRoZW4gcHJvY2VzcyB0aGUgbGlzdCBhbmQgYWN0dWFsbHkgY2FsbCB0aGUKPiBm cmVlIGZ1bmN0aW9uIG9uIHRoZSByZXF1ZXN0cy4KPgo+IFtuZXcgcGF0Y2ggaW4gc2VyaWVzXQo+ Cj4gRm9yOiBWSVotNTE5MAo+IFNpZ25lZC1vZmYtYnk6IEpvaG4gSGFycmlzb24gPEpvaG4uQy5I YXJyaXNvbkBJbnRlbC5jb20+Cj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Ry di5oICAgICAgICAgfCAyMiArKystLS0tLS0tLS0tLS0tLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfZ2VtLmMgICAgICAgICB8IDQxICsrKysrKysrKysrKysrKysrKysrKysrKysrKysr LS0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jICAgIHwgIDIgKy0K PiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jICAgICAgICB8ICAyICsrCj4gICBk cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jICAgICAgICAgfCAgMiArLQo+ICAgZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5jIHwgIDIgKysKPiAgIGRyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuaCB8ICA0ICsrKysKPiAgIDcgZmlsZXMgY2hhbmdl ZCwgNTAgaW5zZXJ0aW9ucygrKSwgMjUgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf ZHJ2LmgKPiBpbmRleCA4OGE0NzQ2Li42MWMzZGIyIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Ry di5oCj4gQEAgLTIxNjEsMTQgKzIxNjEsOSBAQCB2b2lkIGk5MTVfZ2VtX3RyYWNrX2ZiKHN0cnVj dCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvbGQsCj4gICAgKiBpbml0aWFsIHJlZmVyZW5jZSB0YWtl biB1c2luZyBrcmVmX2luaXQKPiAgICAqLwo+ICAgc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0 IHsKPiAtCS8qKgo+IC0JICogVW5kZXJseWluZyBvYmplY3QgZm9yIGltcGxlbWVudGluZyB0aGUg c2lnbmFsL3dhaXQgc3R1ZmYuCj4gLQkgKiBOQjogTmV2ZXIgcmV0dXJuIHRoaXMgZmVuY2Ugb2Jq ZWN0IHRvIHVzZXIgbGFuZCEgSXQgaXMgdW5zYWZlIHRvCj4gLQkgKiBsZXQgYW55dGhpbmcgb3V0 c2lkZSBvZiB0aGUgaTkxNSBkcml2ZXIgZ2V0IGhvbGQgb2YgdGhlIGZlbmNlCj4gLQkgKiBvYmpl Y3QgYXMgdGhlIGNsZWFuIHVwIHdoZW4gZGVjcmVtZW50aW5nIHRoZSByZWZlcmVuY2UgY291bnQK PiAtCSAqIHJlcXVpcmVzIGhvbGRpbmcgdGhlIGRyaXZlciBtdXRleCBsb2NrLgo+IC0JICovCj4g KwkvKiogVW5kZXJseWluZyBvYmplY3QgZm9yIGltcGxlbWVudGluZyB0aGUgc2lnbmFsL3dhaXQg c3R1ZmYuICovCj4gICAJc3RydWN0IGZlbmNlIGZlbmNlOwo+ICsJc3RydWN0IGxpc3RfaGVhZCBk ZWxheV9mcmVlX2xpc3Q7CgpNYXliZSBjYWxsIHRoaXMgZGVsYXlfZnJlZV9saW5rIHRvIGNvbnRp bnVlIHRoZSBlc3RhYmxpc2hlZCBjb252ZW50aW9uLgoKPgo+ICAgCS8qKiBPbiBXaGljaCByaW5n IHRoaXMgcmVxdWVzdCB3YXMgZ2VuZXJhdGVkICovCj4gICAJc3RydWN0IGRybV9pOTE1X3ByaXZh dGUgKmk5MTU7Cj4gQEAgLTIyODEsMjEgKzIyNzYsMTAgQEAgaTkxNV9nZW1fcmVxdWVzdF9yZWZl cmVuY2Uoc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpyZXEpCj4gICBzdGF0aWMgaW5saW5l IHZvaWQKPiAgIGk5MTVfZ2VtX3JlcXVlc3RfdW5yZWZlcmVuY2Uoc3RydWN0IGRybV9pOTE1X2dl bV9yZXF1ZXN0ICpyZXEpCj4gICB7Cj4gLQlXQVJOX09OKCFtdXRleF9pc19sb2NrZWQoJnJlcS0+ cmluZy0+ZGV2LT5zdHJ1Y3RfbXV0ZXgpKTsKPiAtCWZlbmNlX3B1dCgmcmVxLT5mZW5jZSk7Cj4g LX0KPiAtCj4gLXN0YXRpYyBpbmxpbmUgdm9pZAo+IC1pOTE1X2dlbV9yZXF1ZXN0X3VucmVmZXJl bmNlX191bmxvY2tlZChzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJlcSkKPiAtewo+IC0J c3RydWN0IGRybV9kZXZpY2UgKmRldjsKPiAtCj4gICAJaWYgKCFyZXEpCj4gICAJCXJldHVybjsK Pgo+IC0JZGV2ID0gcmVxLT5yaW5nLT5kZXY7Cj4gLQlpZiAoa3JlZl9wdXRfbXV0ZXgoJnJlcS0+ ZmVuY2UucmVmY291bnQsIGZlbmNlX3JlbGVhc2UsICZkZXYtPnN0cnVjdF9tdXRleCkpCj4gLQkJ bXV0ZXhfdW5sb2NrKCZkZXYtPnN0cnVjdF9tdXRleCk7Cj4gKwlmZW5jZV9wdXQoJnJlcS0+ZmVu Y2UpOwo+ICAgfQo+Cj4gICBzdGF0aWMgaW5saW5lIHZvaWQgaTkxNV9nZW1fcmVxdWVzdF9hc3Np Z24oc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICoqcGRzdCwKPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf Z2VtLmMKPiBpbmRleCBhZjc5NzE2Li40ODI4MzVhIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfZ2VtLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dl bS5jCj4gQEAgLTI2MTYsMTAgKzI2MTYsMjcgQEAgc3RhdGljIHZvaWQgaTkxNV9zZXRfcmVzZXRf c3RhdHVzKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgIAl9Cj4gICB9Cj4K PiAtc3RhdGljIHZvaWQgaTkxNV9nZW1fcmVxdWVzdF9mcmVlKHN0cnVjdCBmZW5jZSAqcmVxX2Zl bmNlKQo+ICtzdGF0aWMgdm9pZCBpOTE1X2dlbV9yZXF1ZXN0X3JlbGVhc2Uoc3RydWN0IGZlbmNl ICpyZXFfZmVuY2UpCj4gICB7Cj4gICAJc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpyZXEg PSBjb250YWluZXJfb2YocmVxX2ZlbmNlLAo+ICAgCQkJCQkJIHR5cGVvZigqcmVxKSwgZmVuY2Up Owo+ICsJc3RydWN0IGludGVsX2VuZ2luZV9jcyAqcmluZyA9IHJlcS0+cmluZzsKPiArCXN0cnVj dCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUocmluZy0+ZGV2KTsKPiArCXVu c2lnbmVkIGxvbmcgZmxhZ3M7Cj4gKwo+ICsJLyoKPiArCSAqIE5lZWQgdG8gYWRkIHRoZSByZXF1 ZXN0IHRvIGEgZGVmZXJyZWQgZGVyZWZlcmVuY2UgbGlzdCB0byBiZQo+ICsJICogcHJvY2Vzc2Vk IGF0IGEgbXV0ZXggbG9jayBzYWZlIHRpbWUuCj4gKwkgKi8KPiArCXNwaW5fbG9ja19pcnFzYXZl KCZyaW5nLT5kZWxheWVkX2ZyZWVfbG9jaywgZmxhZ3MpOwoKQXQgdGhlIG1vbWVudCB0aGVyZSBp cyBubyByZXF1ZXN0IHVucmVmZXJlbmNpbmcgZnJvbSBpcnEgaGFuZGxlcnMgcmlnaHQ/IApVbmxl c3MgKG9yIHVudGlsKSB5b3UgcGxhbiB0byBhZGQgdGhhdCB5b3UgY291bGQgdXNlIHNpbXBsZSBz cGluX2xvY2sgCmhlcmUuIChBbmQgaW4gdGhlIGk5MTVfZ2VtX3JldGlyZV9yZXF1ZXN0c19yaW5n LikKCj4gKwlsaXN0X2FkZF90YWlsKCZyZXEtPmRlbGF5X2ZyZWVfbGlzdCwgJnJpbmctPmRlbGF5 ZWRfZnJlZV9saXN0KTsKPiArCXNwaW5fdW5sb2NrX2lycXJlc3RvcmUoJnJpbmctPmRlbGF5ZWRf ZnJlZV9sb2NrLCBmbGFncyk7Cj4gKwo+ICsJcXVldWVfZGVsYXllZF93b3JrKGRldl9wcml2LT53 cSwgJmRldl9wcml2LT5tbS5yZXRpcmVfd29yaywgMCk7CgpIYXZlIHlvdSBkZWNpZGVkIHRvIHJl LXVzZSB0aGUgcmV0aXJlIHdvcmtlciBqdXN0IGZvciBjb252ZW5pZW5jZSBvZiBmb3IgCnNvbWUg b3RoZXIgcmVhc29uIGFzIHdlbGw/CgpJIGZvdW5kIGl0IGEgYml0IHVuZXhwZWN0ZWQgYW5kIHRo b3VnaCBkZWRpY2F0ZWQgcmVxdWVzdCBmcmVlIHdvcmtlciAKd291bGQgYmUgY2xlYW5lciwgYnV0 IEkgZG9uJ3Qga25vdywgbm90IGEgc3Ryb25nIG9waW5pb24uCgo+ICt9Cj4gKwo+ICtzdGF0aWMg dm9pZCBpOTE1X2dlbV9yZXF1ZXN0X2ZyZWUoc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpy ZXEpCj4gK3sKPiAgIAlzdHJ1Y3QgaW50ZWxfY29udGV4dCAqY3R4ID0gcmVxLT5jdHg7Cj4KPiAg IAlCVUdfT04oIW11dGV4X2lzX2xvY2tlZCgmcmVxLT5yaW5nLT5kZXYtPnN0cnVjdF9tdXRleCkp Owo+IEBAIC0yNjk2LDcgKzI3MTMsNyBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IGZlbmNlX29wcyBp OTE1X2dlbV9yZXF1ZXN0X2ZvcHMgPSB7Cj4gICAJLmVuYWJsZV9zaWduYWxpbmcJPSBpOTE1X2dl bV9yZXF1ZXN0X2VuYWJsZV9zaWduYWxpbmcsCj4gICAJLnNpZ25hbGVkCQk9IGk5MTVfZ2VtX3Jl cXVlc3RfaXNfY29tcGxldGVkLAo+ICAgCS53YWl0CQkJPSBmZW5jZV9kZWZhdWx0X3dhaXQsCj4g LQkucmVsZWFzZQkJPSBpOTE1X2dlbV9yZXF1ZXN0X2ZyZWUsCj4gKwkucmVsZWFzZQkJPSBpOTE1 X2dlbV9yZXF1ZXN0X3JlbGVhc2UsCj4gICAJLmZlbmNlX3ZhbHVlX3N0cgk9IGk5MTVfZmVuY2Vf dmFsdWVfc3RyLAo+ICAgCS50aW1lbGluZV92YWx1ZV9zdHIJPSBpOTE1X2ZlbmNlX3RpbWVsaW5l X3ZhbHVlX3N0ciwKPiAgIH07Cj4gQEAgLTI5OTIsNiArMzAwOSwyMSBAQCBpOTE1X2dlbV9yZXRp cmVfcmVxdWVzdHNfcmluZyhzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICpyaW5nKQo+ICAgCQlpOTE1 X2dlbV9yZXF1ZXN0X2Fzc2lnbigmcmluZy0+dHJhY2VfaXJxX3JlcSwgTlVMTCk7Cj4gICAJfQo+ Cj4gKwl3aGlsZSAoIWxpc3RfZW1wdHkoJnJpbmctPmRlbGF5ZWRfZnJlZV9saXN0KSkgewo+ICsJ CXN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxdWVzdDsKPiArCQl1bnNpZ25lZCBsb25n IGZsYWdzOwo+ICsKPiArCQlyZXF1ZXN0ID0gbGlzdF9maXJzdF9lbnRyeSgmcmluZy0+ZGVsYXll ZF9mcmVlX2xpc3QsCj4gKwkJCQkJICAgc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0LAo+ICsJ CQkJCSAgIGRlbGF5X2ZyZWVfbGlzdCk7CgpOZWVkIGEgc3BpbmxvY2sgdG8gc2FtcGxlIGxpc3Qg aGVhZCBoZXJlLiBUaGVuIG1heWJlIG1vdmUgaXQgb24gYSAKdGVtcG9yYXJ5IGxpc3QgYW5kIGRv IHRoZSBmcmVlaW5nIGFmdGVyd2FyZHMuCgpSZWdhcmRzLAoKVHZydGtvCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QK SW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==