From: Sivakumar Thulasimani <sivakumar.thulasimani@intel.com>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>, intel-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 1/7] drm: Fix DP_TEST_COUNT_MASK
Date: Fri, 24 Jul 2015 06:21:32 +0530 [thread overview]
Message-ID: <55B18C14.7050501@intel.com> (raw)
In-Reply-To: <1437694498-5517-1-git-send-email-rodrigo.vivi@intel.com>
Reviewed-by: Sivakumar Thulasimani <sivakumar.thulasimani@intel.com>
On 7/24/2015 5:04 AM, Rodrigo Vivi wrote:
> By Vesa's DP 1.2 Spec this counter has 4 bits [3:0].
>
> This mask is wrong since when the counter was introduced by myself
> on commit ad9dc91b6e21266bfc6f466db4b95e10211f31ee
> Author: Rodrigo Vivi <rodrigo.vivi@gmail.com>
> Date: Tue Sep 16 19:18:12 2014 -0400
>
> drm/i915: Fix Sink CRC
>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> include/drm/drm_dp_helper.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> index 2e86f64..94898f6 100644
> --- a/include/drm/drm_dp_helper.h
> +++ b/include/drm/drm_dp_helper.h
> @@ -420,7 +420,7 @@
>
> #define DP_TEST_SINK_MISC 0x246
> # define DP_TEST_CRC_SUPPORTED (1 << 5)
> -# define DP_TEST_COUNT_MASK 0x7
> +# define DP_TEST_COUNT_MASK 0xf
>
> #define DP_TEST_RESPONSE 0x260
> # define DP_TEST_ACK (1 << 0)
--
regards,
Sivakumar
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-07-24 0:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-23 23:34 [PATCH 1/7] drm: Fix DP_TEST_COUNT_MASK Rodrigo Vivi
2015-07-24 0:51 ` Sivakumar Thulasimani [this message]
2015-07-27 11:23 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B18C14.7050501@intel.com \
--to=sivakumar.thulasimani@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox