Re: [Intel-gfx] [PATCH v1.1 2/5] drm/atomic: Make prepare_fb/cleanup_fb only take state, v2.

[Maarten Lankhorst <maarten.lankhorst@linux.intel.com>]

Hey,

Op 27-07-15 om 13:14 schreef Daniel Vetter:
> On Mon, Jul 27, 2015 at 01:07:37PM +0200, Maarten Lankhorst wrote:
>> Op 27-07-15 om 09:53 schreef Daniel Vetter:
>>> On Wed, Jul 22, 2015 at 09:23:27AM -0400, Rob Clark wrote:
>>>> On Thu, Jul 16, 2015 at 10:13 AM, Maarten Lankhorst
>>>> <maarten.lankhorst@linux.intel.com> wrote:
>>>>> This removes the need to separately track fb changes i915.
>>>>>
>>>>> Changes since v1:
>>>>> - Add dri-devel to cc.
>>>>> - Fix a check in intel's prepare and cleanup fb to take rotation
>>>>>   into account.
>>>>>
>>>>> Cc: dri-devel@lists.freedesktop.org
>>>>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>>>> Reviewed-by: Rob Clark <robdclark@gmail.com>
>>> Applied to drm-misc, thanks.
>>> -Daniel
>> This one needs i915 converted to atomic first, or dpms will fail. :(
> Yeah I dropped it again, since it also does some shuffling in i915 code.
> That should be done in a split-out patch so that this one here really only
> removes the fb parameter.
> -Daniel
The code shuffling is a consequence of removing the fb parameter and allowing NULL.

If you want to separate it that's possible, but means returning early in prepare_plane_fb while a followup patch copes with a nil fb.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel