Re: [PATCH v5 17/19] drm/i915: Wa32bitGeneralStateOffset & Wa32bitInstructionBaseOffset

Michel Thierry
2015-07-28T11:12:13Z

On 7/27/2015 10:11 PM, Chris Wilson wrote:
> On Thu, Jul 16, 2015 at 10:33:29AM +0100, Michel Thierry wrote:
>> + if (!(entry->flags & EXEC_OBJECT_SUPPORTS_48B_ADDRESS) &&
>> + (vma->node.start + vma->node.size) >= (1ULL << 32))
>> + return true;
>
> gcc completely screwed this up here and used 0 for 1ULL<<32.
>
> Note that we can allow state + size == 4G (since the end is exclusive),
> so I went with
>
> if ((entry->flags & EXEC_OBJECT_SUPPORTS_48B_ADDRESS) == 0 &&
> (vma->node.start + vma->node.size - 1) >> 32)
> return true;
>
> instead.
> -Chris
>

Thanks, I'll include this change in the next patch version.