From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michel Thierry Subject: Re: [PATCH v5 06/19] drm/i915/gen8: implement alloc/free for 4lvl Date: Wed, 29 Jul 2015 15:34:59 +0100 Message-ID: <55B8E493.3040402@intel.com> References: <1437039211-2507-1-git-send-email-michel.thierry@intel.com> <1437039211-2507-7-git-send-email-michel.thierry@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTP id 3E8F56EA0C for ; Wed, 29 Jul 2015 07:35:01 -0700 (PDT) In-Reply-To: <1437039211-2507-7-git-send-email-michel.thierry@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "intel-gfx@lists.freedesktop.org" Cc: "Goel, Akash" List-Id: intel-gfx@lists.freedesktop.org T24gNy8xNi8yMDE1IDEwOjMzIEFNLCBNaWNoZWwgVGhpZXJyeSB3cm90ZToKPiBQTUw0IGhhcyBu byBzcGVjaWFsIGF0dHJpYnV0ZXMsIGFuZCB0aGVyZSB3aWxsIGFsd2F5cyBiZSBhIFBNTDQuCj4g U28gc2ltcGx5IGluaXRpYWxpemUgaXQgYXQgY3JlYXRpb24sIGFuZCBkZXN0cm95IGl0IGF0IHRo ZSBlbmQuCj4KPiBUaGUgY29kZSBmb3IgNGx2bCBpcyBhYmxlIHRvIGNhbGwgaW50byB0aGUgZXhp c3RpbmcgM2x2bCBwYWdlIHRhYmxlIGNvZGUKPiB0byBoYW5kbGUgYWxsIG9mIHRoZSBsb3dlciBs ZXZlbHMuCj4KPiB2MjogUmV0dXJuIHNvbWV0aGluZyBhdCB0aGUgZW5kIG9mIGdlbjhfYWxsb2Nf dmFfcmFuZ2VfNGx2bCB0byBrZWVwIHRoZQo+IGNvbXBpbGVyIGhhcHB5LiBBbmQgZGVmaW5lIHJl dCBvbmx5IGluIG9uZSBwbGFjZS4KPiBVcGRhdGVkIGdlbjhfcHBndHRfdW5tYXBfcGFnZXMgYW5k IGdlbjhfcHBndHRfZnJlZSB0byBoYW5kbGUgNGx2bC4KPiB2MzogVXNlIGk5MTVfZG1hX3VubWFw X3NpbmdsZSBpbnN0ZWFkIG9mIHBjaSBBUEkuIEZpeCBhCj4gY291cGxlIG9mIGluY29ycmVjdCBj aGVja3Mgd2hlbiB1bm1hcHBpbmcgcGRwIGFuZCBwZCBwYWdlcyAoQWthc2gpLgo+IHY0OiBDYWxs IF9fcGRwX2ZpbmkgYWxzbyBmb3IgMzJiIFBQR1RULiBDbGVhbiB1cCBhbGxvY19wZHAgcGFyYW0g bGlzdC4KPiB2NTogUHJldmVudCAoaGFybWxlc3MpIG91dCBvZiByYW5nZSBhY2Nlc3MgaW4gZ2Vu OF9mb3JfZWFjaF9wbWw0ZS4KPiB2NjogU2ltcGxpZnkgYWxsb2Nfdm1hX3JhbmdlXzRsdmwgYW5k IGdlbjhfcHBndHRfaW5pdF9jb21tb24gZXJyb3IKPiBwYXRocy4gKEFrYXNoKQo+IHY3OiBSZWJh c2UsIHMvZ2VuOF9wcGd0dF9mcmVlXyovZ2VuOF9wcGd0dF9jbGVhbnVwXyovLgo+IHY4OiBDaGFu Z2UgbG9jYXRpb24gb2YgcG1sNF9pbml0L2ZpbmkuIEl0IHdpbGwgbWFrZSBuZXh0IHBhdGNoZXMK PiBjbGVhbmVyLgo+IHY5OiBSZWJhc2UgYWZ0ZXIgTWlrYSdzIHBwZ3R0IGNsZWFudXAgLyBzY3Jh dGNoIG1lcmdlIHBhdGNoIHNlcmllcywgd2hpbGUKPiB0cnlpbmcgdG8gcmV1c2UgYXMgbXVjaCBh cyBwb3NzaWJsZSBmb3IgcGRwIGFsbG9jLiBwbWw0X2luaXQvZmluaQo+IHJlcGxhY2VkIGJ5IHNl dHVwL2NsZWFudXBfcHggbWFjcm9zLgo+IHYxMDogUmViYXNlIGFmdGVyIE1pa2EncyBtZXJnZWQg cHBndHQgY2xlYW51cCBwYXRjaCBzZXJpZXMuCj4gdjExOiBSZWJhc2UgYWZ0ZXIgZmluYWwgbWVy Z2VkIHZlcnNpb24gb2YgTWlrYSdzIHBwZ3R0L3NjcmF0Y2gKPiBwYXRjaGVzLgo+IHYxMjogRml4 IHBkcGUgc3RhcnQgdmFsdWUgaW4gdHJhY2UgKEFrYXNoKQo+IHYxMzogRGVmaW5lIGFsbCA0bHZs IGZ1bmN0aW9ucyBpbiB0aGlzIHBhdGNoIGRpcmVjdGx5LCBpbnN0ZWFkIG9mCj4gcHJldmlvdXMg cGF0Y2hlcywgYWRkIGk5MTVfcGFnZV9kaXJlY3RvcnlfcG9pbnRlcl9lbnRyeV9hbGxvYyBoZXJl LAo+IHVzZSB0ZXN0X2JpdCB0byBkZXRlY3Qgd2hlbiBwZHAgaXMgYWxyZWFkeSBhbGxvY2F0ZWQg KEFrYXNoKS4KPgo+IENjOiBBa2FzaCBHb2VsIDxha2FzaC5nb2VsQGludGVsLmNvbT4KPiBTaWdu ZWQtb2ZmLWJ5OiBCZW4gV2lkYXdza3kgPGJlbkBid2lkYXdzay5uZXQ+Cj4gU2lnbmVkLW9mZi1i eTogTWljaGVsIFRoaWVycnkgPG1pY2hlbC50aGllcnJ5QGludGVsLmNvbT4gKHYyKykKPiAtLS0K PiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2d0dC5jIHwgMTYzICsrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrLS0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9n ZW1fZ3R0LmggfCAgMTMgKystCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3RyYWNlLmgg ICB8ICAgOCArKwo+ICAgMyBmaWxlcyBjaGFuZ2VkLCAxNjcgaW5zZXJ0aW9ucygrKSwgMTcgZGVs ZXRpb25zKC0pCj4KPiBAQCAtMTA2NSw2ICsxMTIwLDc5IEBAIGVycl9vdXQ6Cj4gICAgICAgICAg cmV0dXJuIHJldDsKPiAgIH0KPgo+ICtzdGF0aWMgaW50IGdlbjhfYWxsb2NfdmFfcmFuZ2VfNGx2 bChzdHJ1Y3QgaTkxNV9hZGRyZXNzX3NwYWNlICp2bSwKPiArICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBzdHJ1Y3QgaTkxNV9wbWw0ICpwbWw0LAo+ICsgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIHVpbnQ2NF90IHN0YXJ0LAo+ICsgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHVpbnQ2NF90IGxlbmd0aCkKPiArewo+ICsgICAgICAgREVDTEFSRV9C SVRNQVAobmV3X3BkcHMsIEdFTjhfUE1MNEVTX1BFUl9QTUw0KTsKPiArICAgICAgIHN0cnVjdCBp OTE1X3BhZ2VfZGlyZWN0b3J5X3BvaW50ZXIgKnBkcDsKPiArICAgICAgIGNvbnN0IHVpbnQ2NF90 IG9yaWdfc3RhcnQgPSBzdGFydDsKPiArICAgICAgIGNvbnN0IHVpbnQ2NF90IG9yaWdfbGVuZ3Ro ID0gbGVuZ3RoOwo+ICsgICAgICAgdWludDY0X3QgdGVtcCwgcG1sNGU7Cj4gKyAgICAgICBpbnQg cmV0ID0gMDsKPiArCj4gKyAgICAgICAvKiBEbyB0aGUgcG1sNCBhbGxvY2F0aW9ucyBmaXJzdCwg c28gd2UgZG9uJ3QgbmVlZCB0byB0cmFjayB0aGUgbmV3bHkKPiArICAgICAgICAqIGFsbG9jYXRl ZCB0YWJsZXMgYmVsb3cgdGhlIHBkcCAqLwo+ICsgICAgICAgYml0bWFwX3plcm8obmV3X3BkcHMs IEdFTjhfUE1MNEVTX1BFUl9QTUw0KTsKPiArCj4gKyAgICAgICAvKiBUaGUgcGFnZWRpcmVjdG9y eSBhbmQgcGFnZXRhYmxlIGFsbG9jYXRpb25zIGFyZSBkb25lIGluIHRoZSBzaGFyZWQgMwo+ICsg ICAgICAgICogYW5kIDQgbGV2ZWwgY29kZS4gSnVzdCBhbGxvY2F0ZSB0aGUgcGRwcy4KPiArICAg ICAgICAqLwo+ICsgICAgICAgZ2VuOF9mb3JfZWFjaF9wbWw0ZShwZHAsIHBtbDQsIHN0YXJ0LCBs ZW5ndGgsIHRlbXAsIHBtbDRlKSB7Cj4gKyAgICAgICAgICAgICAgIGlmICghdGVzdF9iaXQocG1s NGUsIHBtbDQtPnVzZWRfcG1sNGVzKSkgewo+ICsgICAgICAgICAgICAgICAgICAgICAgIHBkcCA9 IGFsbG9jX3BkcCh2bS0+ZGV2KTsKPiArICAgICAgICAgICAgICAgICAgICAgICBpZiAoSVNfRVJS KHBkcCkpCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBnb3RvIGVycl9vdXQ7Cj4g Kwo+ICsgICAgICAgICAgICAgICAgICAgICAgIHBtbDQtPnBkcHNbcG1sNGVdID0gcGRwOwo+ICsg ICAgICAgICAgICAgICAgICAgICAgIF9fc2V0X2JpdChwbWw0ZSwgbmV3X3BkcHMpOwo+ICsgICAg ICAgICAgICAgICAgICAgICAgIHRyYWNlX2k5MTVfcGFnZV9kaXJlY3RvcnlfcG9pbnRlcl9lbnRy eV9hbGxvYyh2bSwKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgcG1sNGUsCj4gKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0YXJ0LAo+ ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBHRU44X1BNTDRFX1NISUZUKTsKPiArICAgICAgICAgICAgICAgfQo+ICsg ICAgICAgfQo+ICsKClBEUCBhbGxvY2F0aW9uIHNob3VsZCBiZSBtb3ZlZCB0byBhIG5ldyAKZ2Vu OF9wcGd0dF9hbGxvY19wYWdlX2RpcnBvaW50ZXJzIGZ1bmN0aW9uIChhcyB3ZSBkbyBmb3IgcGRz IGFuZCBwdHMpOyAKaXQgc2hvdWxkIGFsc28gaGF2ZSB0aGUgcGQgYW5kIHBkcCBzZXR1cCBmdW5j dGlvbnMgd2hpY2ggYXJlIG1pc3Rha2VubHkgCmFkZGVkIHVudGlsIGEgbGF0ZXIgcGF0Y2ggKCJk cm0vaTkxNS9nZW44OiBBZGQgNCBsZXZlbCBzd2l0Y2hpbmcgCmluZnJhc3RydWN0dXJlIGFuZCBs cmMgc3VwcG9ydCIpLgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1n ZngK