From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [RFC 3/9] drm/i915: Convert requests to use struct fence Date: Mon, 03 Aug 2015 10:17:40 +0100 Message-ID: <55BF31B4.2030003@linux.intel.com> References: <1437143483-6234-1-git-send-email-John.C.Harrison@Intel.com> <1437143483-6234-4-git-send-email-John.C.Harrison@Intel.com> <55AFA806.6010502@linux.intel.com> <55B7550D.6080001@Intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id F18E46E217 for ; Mon, 3 Aug 2015 02:17:58 -0700 (PDT) In-Reply-To: <55B7550D.6080001@Intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: John Harrison , Intel-GFX@Lists.FreeDesktop.Org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDA3LzI4LzIwMTUgMTE6MTAgQU0sIEpvaG4gSGFycmlzb24gd3JvdGU6CltzbmlwXQo+Pj4g ICBzdGF0aWMgaW5saW5lIHZvaWQKPj4+IEBAIC0yMjY3LDcgKzIyODQsNyBAQCBpOTE1X2dlbV9y ZXF1ZXN0X3VucmVmZXJlbmNlX191bmxvY2tlZChzdHJ1Y3QKPj4+IGRybV9pOTE1X2dlbV9yZXF1 ZXN0ICpyZXEpCj4+PiAgICAgICAgICAgcmV0dXJuOwo+Pj4KPj4+ICAgICAgIGRldiA9IHJlcS0+ cmluZy0+ZGV2Owo+Pj4gLSAgICBpZiAoa3JlZl9wdXRfbXV0ZXgoJnJlcS0+cmVmLCBpOTE1X2dl bV9yZXF1ZXN0X2ZyZWUsCj4+PiAmZGV2LT5zdHJ1Y3RfbXV0ZXgpKQo+Pj4gKyAgICBpZiAoa3Jl Zl9wdXRfbXV0ZXgoJnJlcS0+ZmVuY2UucmVmY291bnQsIGZlbmNlX3JlbGVhc2UsCj4+PiAmZGV2 LT5zdHJ1Y3RfbXV0ZXgpKQo+Pj4gICAgICAgICAgIG11dGV4X3VubG9jaygmZGV2LT5zdHJ1Y3Rf bXV0ZXgpOwo+Pgo+PiBXb3VsZCBpdCBiZSBuaWNlciB0byBhZGQgZmVuY2VfcHV0X211dGV4KHN0 cnVjdCBmZW5jZSAqLCBzdHJ1Y3QgbXV0ZXgKPj4gKikgZm9yIHRoaXM/IEl0IHdvdWxkIGF2b2lk IHRoZSBsYXllcmluZyB2aW9sYXRpb24gb2YgcmVxdWVzdHMgcGVla2luZwo+PiBpbnRvIGZlbmNl IGltcGxlbWVudGF0aW9uIGRldGFpbHMuCj4KPiBNYWFydGVuIHBvaW50ZWQgb3V0IHRoYXQgYWRk aW5nICdmZW5jZV9wdXRfbXV0ZXgoKScgaXMgYnJlYWtpbmcgdGhlCj4gZmVuY2UgQUJJIGl0c2Vs Zi4gSXQgcmVxdWlyZXMgdXNlcnMgb2YgYW55IHJhbmRvbSBmZW5jZSB0byBrbm93IGFuZAo+IHdv cnJ5IGFib3V0IHdoYXQgbXV0ZXggb2JqZWN0cyB0aGF0IGZlbmNlJ3MgaW50ZXJuYWwgaW1wbGVt ZW50YXRpb24KPiBtaWdodCByZXF1aXJlLgoKSSBkb24ndCBzZWUgd2hhdCBpdCBoYXMgdG8gZG8g d2l0aCB0aGUgQUJJPyBJIGRpc2xpa2UgYm90aCBhcHByb2FjaGVzIAphY3R1YWxseSBhbmQgZG9u J3QgbGlrZSB0aGUgcXVlc3Rpb24gb2Ygd2hhdCBpcyB0aGUgbGVzc2VyIGV2aWwuIDopCgo+IFRo aXMgaXMgYSBiaXQgbW9yZSBoYWNreSBmcm9tIG91ciBwb2ludCBvZiB2aWV3IGJ1dCBpdCBpcyBv bmx5IGEKPiB0ZW1wb3JhcnkgbWVhc3VyZSB1bnRpbCB0aGUgbXV0ZXggbG9jayBpcyBub3QgcmVx dWlyZWQgZm9yCj4gZGVyZWZlcmVuY2luZy4gQXQgdGhhdCBwb2ludCBhbGwgdGhlIG5hc3R5IHN0 dWZmIGRpc2FwcGVhcnMgY29tcGxldGVseS4KClllcyBzYXcgdGhhdCBpbiBsYXRlciBwYXRjaGVz LiBObyB3b3JyaWVzIHRoZW4sIGp1c3QgYSBjb25zZXF1ZW5jZSBvZiAKZ29pbmcgcGF0Y2ggYnkg cGF0Y2guCgo+Pj4gKwo+Pj4gICAgICAgaWYgKHJlcS0+ZmlsZV9wcml2KQo+Pj4gICAgICAgICAg IGk5MTVfZ2VtX3JlcXVlc3RfcmVtb3ZlX2Zyb21fY2xpZW50KHJlcSk7Cj4+Pgo+Pj4gQEAgLTI2 MzcsNiArMjYzOSw0NyBAQCB2b2lkIGk5MTVfZ2VtX3JlcXVlc3RfZnJlZShzdHJ1Y3Qga3JlZiAq cmVxX3JlZikKPj4+ICAgICAgIGttZW1fY2FjaGVfZnJlZShyZXEtPmk5MTUtPnJlcXVlc3RzLCBy ZXEpOwo+Pj4gICB9Cj4+Pgo+Pj4gK3N0YXRpYyBjb25zdCBjaGFyICppOTE1X2dlbV9yZXF1ZXN0 X2dldF9kcml2ZXJfbmFtZShzdHJ1Y3QgZmVuY2UKPj4+ICpyZXFfZmVuY2UpCj4+PiArewo+Pj4g KyAgICByZXR1cm4gImk5MTVfcmVxdWVzdCI7Cj4+PiArfQo+Pgo+PiBJIHRoaW5rIHRoaXMgYmVj b21lcyBraW5kIG9mIEFCSSBvbmNlIGFkZGVkIHNvIHdlIG5lZWQgdG8gbWFrZSBzdXJlCj4+IHRo ZSBiZXN0IG5hbWUgaXMgY2hvc2VuIHRvIHN0YXJ0IHdpdGguIEkgY291bGRuJ3QgaW1tZWRpYXRl bHkgZmlndXJlCj4+IG91dCB3aHkgbm90IGp1c3QgImk5MTUiPwo+Cj4gVGhlIHRob3VnaHQgd2Fz IHRoYXQgd2UgbWlnaHQgc3RhcnQgdXNpbmcgZmVuY2VzIGZvciBvdGhlciBwdXJwb3NlcyBhdAo+ IHNvbWUgcG9pbnQgaW4gdGhlIGZ1dHVyZS4gQXQgd2hpY2ggcG9pbnQgaXQgaXMgaGVscGZ1bCB0 byBkaWZmZXJlbnRpYXRlCj4gdGhlbS4gSWYgbm90aGluZyBlbHNlLCBhIHByZXZpb3VzIGl0ZXJh dGlvbiBvZiB0aGUgbmF0aXZlIHN5bmMKPiBpbXBsZW1lbnRhdGlvbiB3YXMgdXNpbmcgZGlmZmVy ZW50IGZlbmNlIG9iamVjdHMgZHVlIHRvIHdvcnJpZXMgYWJvdXQKPiBhbGxvd2luZyB1c2VyIGxh bmQgdG8gZ2V0IGl0cyBncnViYnkgbWl0dHMgb24gaW1wb3J0YW50IGRyaXZlciBpbnRlcm5hbAo+ IHN0cnVjdHVyZXMuCgpJIGRvbid0IGZvbGxvdyBvbiB0aGUgY29ubmVjdGlvbiBiZXR3ZWVuIHRo ZXNlIG5hbWVzIGFuZCB0aGUgbGFzdCAKY29uY2Vybj8gSWYgSSBkaWQsIHdvdWxkIGl0IGV4cGxh aW4gd2h5IGRyaXZlciBuYW1lICJpOTE1IiBhbmQgCmRpZmZlcmVudGlhdGlvbiBieSB0aW1lbGlu ZSBuYW1lcyB3b3VsZCBiZSBwcm9ibGVtYXRpYz8gTG9va3MgbXVjaCAKY2xlYW5lciB0byBtZS4K Cj4+PiArCj4+PiArc3RhdGljIGNvbnN0IGNoYXIgKmk5MTVfZ2VtX3JlcXVlc3RfZ2V0X3RpbWVs aW5lX25hbWUoc3RydWN0IGZlbmNlCj4+PiAqcmVxX2ZlbmNlKQo+Pj4gK3sKPj4+ICsgICAgc3Ry dWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpyZXEgPSBjb250YWluZXJfb2YocmVxX2ZlbmNlLAo+ Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgICB0eXBlb2YoKnJlcSksIGZlbmNlKTsKPj4+ICsg ICAgcmV0dXJuIHJlcS0+cmluZy0+bmFtZTsKPj4+ICt9Cj4+PiArCj4+PiArc3RhdGljIGJvb2wg aTkxNV9nZW1fcmVxdWVzdF9lbmFibGVfc2lnbmFsaW5nKHN0cnVjdCBmZW5jZSAqcmVxX2ZlbmNl KQo+Pj4gK3sKPj4+ICsgICAgLyogSW50ZXJydXB0IGRyaXZlbiBmZW5jZXMgYXJlIG5vdCBpbXBs ZW1lbnRlZCB5ZXQuKi8KPj4+ICsgICAgV0FSTih0cnVlLCAiVGhpcyBzaG91bGQgbm90IGJlIGNh bGxlZCEiKTsKPj4+ICsgICAgcmV0dXJuIHRydWU7Cj4+Cj4+IEkgc3VwcG9zZSBXQVJOIGlzIG5v dCByZWFsbHkgbmVlZGVkIGluIHRoZSBpbnRlcmltIHBhdGNoLiBXb3VsZCByZXR1cm4KPj4gZmFs c2Ugd29yaz8KPgo+IFRoZSBwb2ludCBpcyB0byBrZWVwIHRoZSBkcml2ZXIgJ3NhZmUnIGlmIHRo YXQgcGF0Y2ggaXMgdmlld2VkIGFzIHN0YW5kCj4gYWxvbmUuIEkuZS4sIGlmIHRoZSBpbnRlcnJ1 cHQgZm9sbG93IHVwIGRvZXMgbm90IGdldCBtZXJnZWQgaW1tZWRpYXRlbHkKPiBhZnRlciAob3Ig bm90IGF0IGFsbCkgdGhlbiB0aGlzIHByZXZlbnRzIHBlb3BsZSBhY2NpZGVudGFsbHkgdHJ5aW5n IHRvCj4gdXNlIGFuIHVuc3VwcG9ydGVkIGludGVyZmFjZSB3aXRob3V0IGZpcnN0IGltcGxlbWVu dGluZyBpdC4KCkkgYXNzdW1lZCB0cnVlIG1lYW5zICJzaWduYWxpbmcgZW5hYmxlZCBzdWNjZXNz ZnVsbHkiIGJ1dCAiZmFsc2UiIAphY3R1YWxseSBtZWFucyAiZmVuY2UgYWxyZWFkeSBwYXNzZWQi IHNvIHlvdSBhcmUgcmlnaHQuIEkgYmxhbWUgdGhlIAp1bi1pbnR1aXRpdmUgQVBJLiA6KQoKPj4+ ICsgICAgZmVuY2VfYmFzZSA9IGZlbmNlX2NvbnRleHRfYWxsb2MoSTkxNV9OVU1fUklOR1MpOwo+ Pj4gKwo+Pj4gICAgICAgLyogTm93IGl0IGlzIHNhZmUgdG8gZ28gYmFjayByb3VuZCBhbmQgZG8g ZXZlcnl0aGluZyBlbHNlOiAqLwo+Pj4gICAgICAgZm9yX2VhY2hfcmluZyhyaW5nLCBkZXZfcHJp diwgaSkgewo+Pj4gICAgICAgICAgIHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxOwo+ Pj4KPj4+ICAgICAgICAgICBXQVJOX09OKCFyaW5nLT5kZWZhdWx0X2NvbnRleHQpOwo+Pj4KPj4+ ICsgICAgICAgIHJpbmctPmZlbmNlX2NvbnRleHQgPSBmZW5jZV9iYXNlICsgaTsKPj4KPj4gQ291 bGQgeW91IHN0b3JlIGZlbmNlX2Jhc2UgaW4gZGV2X3ByaXYgYW5kIHRoZW4gcmluZy0+aW5pdF9o dyBjb3VsZAo+PiBzZXQgdXAgdGhlIGZlbmNlX2NvbnRleHQgb24gaXRzIG93bj8KPgo+IFByb2Jh Ymx5LiBJdCBzZWVtZWQgdG8gbWFrZSBtb3JlIHNlbnNlIHRvIG1lIHRvIGtlZXAgdGhlIGZlbmNl Cj4gYWxsb2NhdGlvbiBhbGwgaW4gb25lIHBsYWNlIHJhdGhlciB0aGFuIHNwbGl0dGluZyBpdCBp biBoYWxmIGFuZAo+IGRpc3RyaWJ1dGluZyBpdC4gSXQgZ2V0cyByZW1vdmVkIGFnYWluIHdpdGgg dGhlIHBlciBjb250ZXh0IHBlciByaW5nCj4gdGltZWxpbmVzIGFueXdheS4KClllcyBzYXcgdGhh dCBsYXRlciwgbmV2ZXIgbWluZCB0aGVuLgoKVHZydGtvCgoKCgoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRl bC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK