Re: [PATCH] drm/atomic: Call ww_acquire_done after check phase is complete

From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>,
	DRI Development <dri-devel@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
	Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/atomic: Call ww_acquire_done after check phase is complete
Date: Wed, 5 Aug 2015 16:57:24 +0200	[thread overview]
Message-ID: <55C22454.3090304@linux.intel.com> (raw)
In-Reply-To: <1438780119-30493-1-git-send-email-daniel.vetter@ffwll.ch>

Hey,

Op 05-08-15 om 15:08 schreef Daniel Vetter:
> We want to make sure that no one tries to acquire more locks and
> states, and ww mutexes provide debug facilities for that. So use them.
>
> Cc: Rob Clark <robdclark@gmail.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
>  drivers/gpu/drm/drm_atomic.c | 2 ++
>  1 file changed, 2 insertions(+)
I like the idea, played with the thought myself, but I think it might need to be slightly less strict for transitional drivers.

~Maarten
> diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c
> index 422183e7ee7d..5ea609f270ea 100644
> --- a/drivers/gpu/drm/drm_atomic.c
> +++ b/drivers/gpu/drm/drm_atomic.c
> @@ -1268,6 +1268,8 @@ int drm_atomic_check_only(struct drm_atomic_state *state)
>  		}
>  	}
>  
> +	ww_acquire_done(&state->acquire_ctx->ww_ctx);
> +
>  	return ret;
>  }
>  EXPORT_SYMBOL(drm_atomic_check_only);

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel