From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Siluvery, Arun" Subject: Re: [PATCH v2 2/2] drm/i915:gen9: Add disable gather at set shader w/a Date: Wed, 5 Aug 2015 16:18:44 +0100 Message-ID: <55C22954.3040100@linux.intel.com> References: <1438629897-2993-3-git-send-email-arun.siluvery@linux.intel.com> <1438683713-5464-1-git-send-email-arun.siluvery@linux.intel.com> <874mkdyetk.fsf@gaia.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTP id D5B956E5EA for ; Wed, 5 Aug 2015 08:18:46 -0700 (PDT) In-Reply-To: <874mkdyetk.fsf@gaia.fi.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Mika Kuoppala , intel-gfx@lists.freedesktop.org Cc: Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org T24gMDUvMDgvMjAxNSAxNTo0NSwgTWlrYSBLdW9wcGFsYSB3cm90ZToKPiBBcnVuIFNpbHV2ZXJ5 IDxhcnVuLnNpbHV2ZXJ5QGxpbnV4LmludGVsLmNvbT4gd3JpdGVzOgo+Cj4+IFRoaXMgV0EgaXMg aW1wbGVtZW50ZWQgaW4gaW5pdF9jb250ZXh0IGFzIHdlbGwgYXMgV0EgYmF0Y2ggaW5pdC4KPj4g VGhlcmUgYXJlIGFsc28gc29tZSBkZXBlbmRlbnQgYml0cyBuZWVkIHRvIGJlIHNldCBpbiBvdGhl ciByZWdpc3RlcnMKPj4gZm9yIHRoaXMgdG8gYmUgY29tcGxldGUuCj4+Cj4+IHYyOiBiZWhhdmlv dXIgb2YgZGlzYWJsZSBnYXRoZXIgYXQgc2V0IHNoYWRlciBiaXQgY2FuIGJlIHNwZWNpZmllZCBi eQo+PiB0d28gZGlmZmVyZW50IHJlZ2lzdGVycywgdXNlIGEgYmV0dGVyIG9wdGlvbiAoQmVuKS4K Pj4KPgo+IEZvciBtZSBpdCBsb29rcyBsaWtlIHRoZXJlIGFyZSAyIG9ydGhvZ29uYWwgZ29hbHMg Zm9yIHRoaXMgcGF0Y2guCj4KPiBJIHRoaW5rIHRoZSBhY3R1YWwgd29ya2Fyb3VuZCBzaG91bGQg YmUgb25lIHBhdGNoLCB0aGUgcmVzZXR0aW5nCj4gb2YgdGhlIHNldCBzaGFkZXIgYml0IGFuZCB0 aGUgcGF0Y2ggbmFtZWQgYWNjb3JkaW5nbHkuCj4KPiBUaGVuIHRoZSBzZXQgc2hhZGVyIGluaXRp YWxpemF0aW9uIGluIGEgZGlmZmVyZW50IHBhdGNoLAo+IGlmIHRoZXJlIGlzIGp1c3RpZmljYXRp b24gZm9yIGl0ICh0aGF0IEkgaGF2ZSBub3QgbWFuYWdlZCB5ZXQKPiB0byBmaW5kKS4KCkkgYWdy ZWUgaXQgbmVlZHMgdG8gYmUgc3BsaXQgaW50byB0d28gcGF0Y2hlcy4KCj4KPiBCdXQgbGV0cyBj b25jZW50cmF0ZSBvbiB0aGUgd29ya2Fyb3VuZCBpdHNlbGYuLi4KPgo+PiBDYzogQmVuIFdpZGF3 c2t5IDxiZW5qYW1pbi53aWRhd3NreUBpbnRlbC5jb20+Cj4+IENjOiBKb29uYXMgTGFodGluZW4g PGpvb25hcy5sYWh0aW5lbkBsaW51eC5pbnRlbC5jb20+Cj4+IFNpZ25lZC1vZmYtYnk6IEFydW4g U2lsdXZlcnkgPGFydW4uc2lsdXZlcnlAbGludXguaW50ZWwuY29tPgo+PiAtLS0KPj4gICBkcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oICAgICAgICAgfCAgNSArKysrKwo+PiAgIGRyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jICAgICAgICB8ICA4ICsrKysrKysrCj4+ICAgZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5jIHwgMTggKysrKysrKysrKysrKysr KysrCj4+ICAgMyBmaWxlcyBjaGFuZ2VkLCAzMSBpbnNlcnRpb25zKCspCj4+Cj4+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9yZWcuaAo+PiBpbmRleCA4OTkxY2Q1Li44NzE5YTVhIDEwMDY0NAo+PiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfcmVnLmgKPj4gQEAgLTE3MjEsNiArMTcyMSwxMCBAQCBlbnVtIHNrbF9kaXNwX3Bv d2VyX3dlbGxzIHsKPj4gICAjZGVmaW5lICAgTUVNX0RJU1BMQVlfVFJJQ0tMRV9GRUVEX0RJU0FC TEUgKDE8PDIpIC8qIDg1eCBvbmx5ICovCj4+ICAgI2RlZmluZSBGV19CTEMJCTB4MDIwZDgKPj4g ICAjZGVmaW5lIEZXX0JMQzIJCTB4MDIwZGMKPj4gKyNkZWZpbmUgR0VON19SU19DSElDS0VOICAw eDIwREMKPj4gKyNkZWZpbmUgICBHRU45X1JTX0NISUNLRU5fRElTQUJMRV9HQVRIRVJfQVRfU0hB REVSICgxPDwyKQo+PiArI2RlZmluZSBHRU43X0ZGX1NMSUNFX0NISUNLRU4xICAgIDB4MjBFMAo+ PiArI2RlZmluZSAgIEdFTjlfUEVSX0NUWF9ESVNBQkxFX0dBVEhFUl9DT05UUk9MICAoMTw8MTUp Cj4+ICAgI2RlZmluZSBGV19CTENfU0VMRgkweDAyMGUwIC8qIDkxNSsgb25seSAqLwo+PiAgICNk ZWZpbmUgICBGV19CTENfU0VMRl9FTl9NQVNLICAgICAgKDE8PDMxKQo+PiAgICNkZWZpbmUgICBG V19CTENfU0VMRl9GSUZPX01BU0sgICAgKDE8PDE2KSAvKiA5NDUgb25seSAqLwo+PiBAQCAtNTgz Niw2ICs1ODQwLDcgQEAgZW51bSBza2xfZGlzcF9wb3dlcl93ZWxscyB7Cj4+ICAgIyBkZWZpbmUg R0VON19DU0MxX1JIV09fT1BUX0RJU0FCTEVfSU5fUkNDCSgoMTw8MTApIHwgKDE8PDI2KSkKPj4g ICAjIGRlZmluZSBHRU45X1JIV09fT1BUSU1JWkFUSU9OX0RJU0FCTEUJCSgxPDwxNCkKPj4gICAj ZGVmaW5lIENPTU1PTl9TTElDRV9DSElDS0VOMgkJCTB4NzAxNAo+PiArI2RlZmluZSAgR0VOOV9E SVNBQkxFX0dBVEhFUl9TRVRfU0hBREVSX1NMSUNFICAgKDE8PDEyKQo+PiAgICMgZGVmaW5lIEdF TjhfQ1NDMl9TQkVfVlVFX0NBQ0hFX0NPTlNFUlZBVElWRQkoMTw8MCkKPj4KPj4gICAjZGVmaW5l IEhJWl9DSElDS0VOCQkJCQkweDcwMTgKPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2xyYy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMKPj4gaW5k ZXggOWZhYWQ4Mi4uZDNhMDNmMyAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfbHJjLmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMKPj4g QEAgLTEyOTIsNiArMTI5MiwxNCBAQCBzdGF0aWMgaW50IGdlbjlfaW5pdF9wZXJjdHhfYmIoc3Ry dWN0IGludGVsX2VuZ2luZV9jcyAqcmluZywKPj4gICAJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9 IHJpbmctPmRldjsKPj4gICAJdWludDMyX3QgaW5kZXggPSB3YV9jdHhfc3RhcnQod2FfY3R4LCAq b2Zmc2V0LCBDQUNIRUxJTkVfRFdPUkRTKTsKPj4KPj4gKwkvKiBXQSB0byByZXNldCAiZGlzYWJs ZSBnYXRoZXIgYXQgc2V0IHNoYWRlciBzbGljZSIgYml0ICovCj4KPiBJIGFtIHRoaW5raW5nIGhv dyB3ZSBjb3VsZCBhbHNvIGFsZXJ0IHRoZSByZWFkZXIgdGhhdCB0aGlzIHdvcmthcm91bmQKPiBu ZWVkcyB0byBiZSByZXZpc2l0ZWQgd2hlbiBpdCBoYXMgYmVlbiBnaXZlbiBhIG5hbWUuCj4gQnkg YWRkaW5nIFdhTm9OYW1lOnNrbCxieHQgYWxvbmcgd2l0aCB0aGUgY29tbWVudCBhYm92ZT8KPgo+ PiArCWlmIChJU19TS1lMQUtFKGRldikpIHsKPgo+IEFzIEJlbiBub3RlZCwgZG9jdW1lbnRhdGlv biBpcyByYXRoZXIgc3BhcnNlLiBCdXQgdGhlIHJlZmVyZW5jZQo+IHRvIHByZXZpb3VzIHByb2Js ZW1zIHdpdGggdGhpcyBiaXQgYmVpbmcgc2F2ZS9yZXN0b3JlZCBpbiB3cm9uZyBvcmRlciwKPiB3 ZSBjYW4gY29uY2x1ZGUgdGhhdCB0aGlzIHNob3VsZCBiZSBmb3IgQlhUIGFsc28uCj4KPj4gKwkJ d2FfY3R4X2VtaXQoYmF0Y2gsIGluZGV4LCBNSV9MT0FEX1JFR0lTVEVSX0lNTSgxKSk7Cj4+ICsJ CXdhX2N0eF9lbWl0KGJhdGNoLCBpbmRleCwgQ09NTU9OX1NMSUNFX0NISUNLRU4yKTsKPj4gKwkJ d2FfY3R4X2VtaXQoYmF0Y2gsIGluZGV4LAo+PiArCQkJICAgIF9NQVNLRURfQklUX0RJU0FCTEUo R0VOOV9ESVNBQkxFX0dBVEhFUl9TRVRfU0hBREVSX1NMSUNFKSk7Cj4+ICsJfQo+PiArCj4KPiBU aGUgYWN0dWFsIHZhbHVlIG9mICdkaXNhYmxlIHNldCBzaGFkZXInIGlzIG9ydGhvZ29uYWwgYW5k IGJleW9uZCBzY29wZQo+IG9mIHRoaXMgV29ya2Fyb3VuZCBzbyB0aGUgcmVzdCBzaG91bGQgYmUg c3RyaXAgb3V0IHRvIGRpZmZlcmVudCBwYXRjaC4KPgpBcyB5b3UgbWVudGlvbmVkIG9uIGlyYyB3 ZSBmaXJzdCBuZWVkIHRvIGtub3cgd2hldGhlciB3ZSBuZWVkIHRvIGRpc2FibGUgCnRoZSBzZXQg c2hhZGVyIG9yIG5vdCAoc2V0IG94NzAxNFsxMjoxMl0gdG8gMSksIGJlY2F1c2UgdGhlIFdBIG9u bHkgCnRhbGtzIGFib3V0IHJlc2V0dGluZyB0aGlzIGJpdCBpbiBwZXIgY3R4IGJhdGNoLgpUaGUg Zm9sbG93aW5nIGJpdHMgY2FuIGJlIGlnbm9yZSBpZiB0aGVyZSBpcyBub3QgbmVlZCB0byBzZXQg dGhhdCBiaXQgaW4gCnRoZSBmaXJzdCBwbGFjZS4KCndpdGggcmVmZXJlbmNlIHRvIGdlbV9yaW5n ZmlsbCwgb24gbXkgc3lzdGVtIGl0IG9ubHkgY29tcGxldGVzIHdpdGhvdXQgCmFueSBoYW5nIGlm IEkgYWRkIHRoaXMgcGF0Y2ggY29tcGxldGVseSBidXQgb24gc29tZSBzeXN0ZW0gdGhpcyBwYXRj aCAKZG9lc24ndCBzZWVtIHRvIGJlIG5lY2Vzc2FyeS4KCnJlZ2FyZHMKQXJ1bgoKPiAtTWlrYQo+ Cj4+ICAgCS8qIFdhU2V0RGlzYWJsZVBpeE1hc2tDYW1taW5nQW5kUmh3b0luQ29tbW9uU2xpY2VD aGlja2VuOnNrbCxieHQgKi8KPj4gICAJaWYgKChJU19TS1lMQUtFKGRldikgJiYgKElOVEVMX1JF VklEKGRldikgPD0gU0tMX1JFVklEX0IwKSkgfHwKPj4gICAJICAgIChJU19CUk9YVE9OKGRldikg JiYgKElOVEVMX1JFVklEKGRldikgPT0gQlhUX1JFVklEX0EwKSkpIHsKPj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuYyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX3JpbmdidWZmZXIuYwo+PiBpbmRleCBkY2QxYjhmLi41ZThlNWY5IDEwMDY0 NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmMKPj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5jCj4+IEBAIC05ODUsNiAr OTg1LDE3IEBAIHN0YXRpYyBpbnQgZ2VuOV9pbml0X3dvcmthcm91bmRzKHN0cnVjdCBpbnRlbF9l bmdpbmVfY3MgKnJpbmcpCj4+ICAgCQl0bXAgfD0gSERDX0ZPUkNFX0NTUl9OT05fQ09IRVJFTlRf T1ZSX0RJU0FCTEU7Cj4+ICAgCVdBX1NFVF9CSVRfTUFTS0VEKEhEQ19DSElDS0VOMCwgdG1wKTsK Pj4KPj4gKwkvKiBXQSB0byBnYXRoZXIgYXQgc2V0IHNoYWRlciAtIHNrbCxieHQKPj4gKwkgKiBU aGVzZSBhcmUgZGVwZW5kZW50IGJpdHMgbmVlZCB0byBiZSBzZXQgZm9yIHRoZSBXQS4KPj4gKwkg Ki8KPj4gKwlpZiAoKElTX1NLWUxBS0UoZGV2KSAmJiBJTlRFTF9SRVZJRChkZXYpID4gU0tMX1JF VklEX0QwKSB8fAo+PiArCSAgICAoSVNfQlJPWFRPTihkZXYpICYmIElOVEVMX1JFVklEKGRldikg PiBCWFRfUkVWSURfQTApKSB7Cj4+ICsJCVdBX1NFVF9CSVRfTUFTS0VEKEdFTjdfRkZfU0xJQ0Vf Q0hJQ0tFTjEsCj4+ICsJCQkJICBHRU45X1BFUl9DVFhfRElTQUJMRV9HQVRIRVJfQ09OVFJPTCk7 Cj4+ICsJCVdBX1NFVF9CSVRfTUFTS0VEKEdFTjdfUlNfQ0hJQ0tFTiwKPj4gKwkJCQkgIEdFTjlf UlNfQ0hJQ0tFTl9ESVNBQkxFX0dBVEhFUl9BVF9TSEFERVIpOwo+PiArCX0KPj4gKwo+PiAgIAly ZXR1cm4gMDsKPj4gICB9Cj4+Cj4+IEBAIC0xMDY4LDYgKzEwNzksMTMgQEAgc3RhdGljIGludCBz a2xfaW5pdF93b3JrYXJvdW5kcyhzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICpyaW5nKQo+PiAgIAkJ CQkgIEhEQ19GRU5DRV9ERVNUX1NMTV9ESVNBQkxFIHwKPj4gICAJCQkJICBIRENfQkFSUklFUl9Q RVJGT1JNQU5DRV9ESVNBQkxFKTsKPj4KPj4gKwkvKiBXQSB0byBEaXNhYmxlIGdhdGhlciBhdCBz ZXQgc2hhZGVyIC0gc2tsCj4+ICsJICogVGhpcyBiaXQgbmVlZHMgdG8gYmUgcmVzZXQgaW4gUGVy IGN0eCBXQSBiYXRjaCBhbmQgaXQgaXMgYWxzbwo+PiArCSAqIGRlcGVuZGVudCBvbiBvdGhlciBi aXRzIGluIGRpZmZlcmVudCByZWdpc3RlciwgYWxsIG9mIHRoZW0gbmVlZAo+PiArCSAqIGJlIHNl dCBmb3IgdGhlIFdBIHRvIGJlIGNvbXBsZXRlLgo+PiArCSAqLwo+PiArCVdBX1NFVF9CSVRfTUFT S0VEKENPTU1PTl9TTElDRV9DSElDS0VOMiwgR0VOOV9ESVNBQkxFX0dBVEhFUl9TRVRfU0hBREVS X1NMSUNFKTsKPj4gKwo+PiAgIAlyZXR1cm4gc2tsX3R1bmVfaXpfaGFzaGluZyhyaW5nKTsKPj4g ICB9Cj4+Cj4+IC0tCj4+IDEuOS4xCj4+Cj4+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCj4+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPj4gSW50ZWwtZ2Z4 QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+PiBodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cj4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vaW50ZWwtZ2Z4Cg==