From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michel Thierry <michel.thierry@intel.com>
Subject: Re: [PATCH 1/2 v2] drm/i915: Allow parsing of variable
 size child device entries from VBT
Date: Thu, 6 Aug 2015 14:59:10 +0100
Message-ID: <55C3682E.6080103@intel.com>
References: <1436526655-2965-1-git-send-email-antti.koskipaa@linux.intel.com>
 <1436526655-2965-2-git-send-email-antti.koskipaa@linux.intel.com>
 <20150804135552.GC6150@boom> <20150805085900.GM17734@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by gabe.freedesktop.org (Postfix) with ESMTP id 4287D6E73F
 for <intel-gfx@lists.freedesktop.org>; Thu,  6 Aug 2015 06:59:12 -0700 (PDT)
In-Reply-To: <20150805085900.GM17734@phenom.ffwll.local>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Daniel Vetter <daniel@ffwll.ch>, Antti Koskipaa <antti.koskipaa@linux.intel.com>, "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

T24gOC81LzIwMTUgOTo1OSBBTSwgRGFuaWVsIFZldHRlciB3cm90ZToKPiBPbiBUdWUsIEF1ZyAw
NCwgMjAxNSBhdCAwNDo1NTo1MlBNICswMzAwLCBEYXZpZCBXZWluZWhhbGwgd3JvdGU6Cj4+IFZC
VCB2ZXJzaW9uIDE5NiBpbmNyZWFzZWQgdGhlIHNpemUgb2YgY29tbW9uX2NoaWxkX2Rldl9jb25m
aWcuIFRoZSBwYXJzZXIKPj4gY29kZSBhc3N1bWVkIHRoYXQgdGhlIHNpemUgb2YgdGhpcyBzdHJ1
Y3R1cmUgd291bGQgbm90IGNoYW5nZS4KPj4KPj4gVGhlIG1vZGlmaWVkIGNvZGUgbm93IGNvcGll
cyB0aGUgYW1vdW50IG5lZWRlZCBiYXNlZCBvbiB0aGUgVkJUIHZlcnNpb24sCj4+IGFuZCBlbWl0
cyBhIGRlYnVnIG1lc3NhZ2UgaWYgdGhlIFZCVCB2ZXJzaW9uIGlzIHVua25vd24gKHRvbyBuZXcp
Owo+PiBzaW5jZSB0aGUgc3RydWN0IGNvbmZpZyBibG9jayB3b24ndCBzaHJpbmsgaW4gbmV3ZXIg
dmVyc2lvbnMgaXQgc2hvdWxkCj4+IGJlIGhhcm1sZXNzIHRvIGNvcHkgdGhlIG1heGltdW0ga25v
d24gc2l6ZSBpbiBzdWNoIGNhc2VzLCBzbyB0aGF0J3MKPj4gd2hhdCB3ZSBkbywgYnV0IGVtaXR0
aW5nIHRoZSB3YXJuaW5nIGlzIHByb2JhYmx5IHNlbnNpYmxlIGFueXdheS4KPj4KPj4gSW4gdGhl
IGxvbmdlciBydW4gaXQgbWlnaHQgbWFrZSBzZW5zZSB0byBtb2RpZnkgdGhlIHBhcnNlciBjb2Rl
IHRvCj4+IHVzZSBhIHZlcnNpb24vZmVhdHVyZSBtYXBwaW5nLCByYXRoZXIgdGhhbiBoYXJkY29k
aW5nIHRoaW5ncyBsaWtlIHRoaXMsCj4+IGJ1dCBmb3Igbm93IHRoZSB2YXJpYW50cyBhcmUgZmFp
cmx5IG1hbmFnYWJsZS4KPj4KPj4gdjI6IFN0cmljdGVyIHNpemUgY2hlY2tzCj4+Cj4+IFNpZ25l
ZC1vZmYtYnk6IERhdmlkIFdlaW5laGFsbCA8ZGF2aWQud2VpbmVoYWxsQGxpbnV4LmludGVsLmNv
bT4KPgo+IFNpbmNlIENocmlzIG1lbnRpb25lZCB0aGF0IHRoaXMgc2hvdWxkIGZpeCBhIHJlZ3Jl
c3Npb24gSSBhcHBsaWVkIGl0IHRvCj4gZHJtLWludGVsLWZpeGVzLgo+IC1EYW5pZWwKPgo+PiAt
LS0KPj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9iaW9zLmMgfCAgIDI2ICsrKysrKysr
KysrKysrKysrKysrKystLS0tCj4+ICAgMSBmaWxlIGNoYW5nZWQsIDIyIGluc2VydGlvbnMoKyks
IDQgZGVsZXRpb25zKC0pCj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p
bnRlbF9iaW9zLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9iaW9zLmMKPj4gaW5kZXgg
MmZmOWViMDBmZGVjLi44YTFmM2UxZmM1OTggMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry
bS9pOTE1L2ludGVsX2Jpb3MuYwo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9i
aW9zLmMKPj4gQEAgLTEwMTUsMTUgKzEwMTUsMzMgQEAgcGFyc2VfZGV2aWNlX21hcHBpbmcoc3Ry
dWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+PiAgICAgICAgY29uc3QgdW5pb24gY2hp
bGRfZGV2aWNlX2NvbmZpZyAqcF9jaGlsZDsKPj4gICAgICAgIHVuaW9uIGNoaWxkX2RldmljZV9j
b25maWcgKmNoaWxkX2Rldl9wdHI7Cj4+ICAgICAgICBpbnQgaSwgY2hpbGRfZGV2aWNlX251bSwg
Y291bnQ7Cj4+IC0gICAgIHUxNiAgICAgYmxvY2tfc2l6ZTsKPj4gKyAgICAgdTggZXhwZWN0ZWRf
c2l6ZTsKPj4gKyAgICAgdTE2IGJsb2NrX3NpemU7Cj4+Cj4+ICAgICAgICBwX2RlZnMgPSBmaW5k
X3NlY3Rpb24oYmRiLCBCREJfR0VORVJBTF9ERUZJTklUSU9OUyk7Cj4+ICAgICAgICBpZiAoIXBf
ZGVmcykgewo+PiAgICAgICAgICAgICAgICBEUk1fREVCVUdfS01TKCJObyBnZW5lcmFsIGRlZmlu
aXRpb24gYmxvY2sgaXMgZm91bmQsIG5vIGRldmljZXMgZGVmaW5lZC5cbiIpOwo+PiAgICAgICAg
ICAgICAgICByZXR1cm47Cj4+ICAgICAgICB9Cj4+IC0gICAgIGlmIChwX2RlZnMtPmNoaWxkX2Rl
dl9zaXplIDwgc2l6ZW9mKCpwX2NoaWxkKSkgewo+PiAtICAgICAgICAgICAgIERSTV9FUlJPUigi
R2VuZXJhbCBkZWZpbml0b24gYmxvY2sgY2hpbGQgZGV2aWNlIHNpemUgaXMgdG9vIHNtYWxsLlxu
Iik7Cj4+ICsgICAgIGlmIChiZGItPnZlcnNpb24gPCAxOTUpIHsKPj4gKyAgICAgICAgICAgICBl
eHBlY3RlZF9zaXplID0gMzM7Cj4+ICsgICAgIH0gZWxzZSBpZiAoYmRiLT52ZXJzaW9uID09IDE5
NSkgewo+PiArICAgICAgICAgICAgIGV4cGVjdGVkX3NpemUgPSAzNzsKPj4gKyAgICAgfSBlbHNl
IGlmIChiZGItPnZlcnNpb24gPD0gMTk3KSB7Cj4+ICsgICAgICAgICAgICAgZXhwZWN0ZWRfc2l6
ZSA9IDM4Owo+PiArICAgICB9IGVsc2Ugewo+PiArICAgICAgICAgICAgIGV4cGVjdGVkX3NpemUg
PSAzODsKPj4gKyAgICAgICAgICAgICBEUk1fREVCVUdfRFJJVkVSKCJFeHBlY3RlZCBjaGlsZF9k
ZXZpY2VfY29uZmlnIHNpemUgZm9yIEJEQiB2ZXJzaW9uICV1IG5vdCBrbm93bjsgYXNzdW1pbmcg
JXVcbiIsIGV4cGVjdGVkX3NpemUpOwoKSGksIHRoZSBsaW5lIGFib3ZlIHRocm93cyBhIHdhcm5p
bmcgYmVjYXVzZSB0aGVyZSBhcmUgdHdvICcldScgYnV0IG9ubHkgCm9uZSB2YXJpYWJsZS4gTG9v
a3MgbGlrZSBiZGItPnZlcnNpb24gc2hvdWxkIGJlIHRoZSAxc3QgcHJpbnRlZCB2YWx1ZS4KCj4+
ICsgICAgIH0KPj4gKwo+PiArICAgICBpZiAoZXhwZWN0ZWRfc2l6ZSA+IHNpemVvZigqcF9jaGls
ZCkpIHsKPj4gKyAgICAgICAgICAgICBEUk1fRVJST1IoImNoaWxkX2RldmljZV9jb25maWcgY2Fu
bm90IGZpdCBpbiBwX2NoaWxkXG4iKTsKPj4gKyAgICAgICAgICAgICByZXR1cm47Cj4+ICsgICAg
IH0KPj4gKwo+PiArICAgICBpZiAocF9kZWZzLT5jaGlsZF9kZXZfc2l6ZSAhPSBleHBlY3RlZF9z
aXplKSB7Cj4+ICsgICAgICAgICAgICAgRFJNX0VSUk9SKCJTaXplIG1pc21hdGNoOyBjaGlsZF9k
ZXZpY2VfY29uZmlnIHNpemU9JXUgKGV4cGVjdGVkICV1KTsgYmRiLT52ZXJzaW9uOiAldVxuIiwK
Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgcF9kZWZzLT5jaGlsZF9kZXZfc2l6ZSwgZXhwZWN0
ZWRfc2l6ZSwgYmRiLT52ZXJzaW9uKTsKPj4gICAgICAgICAgICAgICAgcmV0dXJuOwo+PiAgICAg
ICAgfQo+PiAgICAgICAgLyogZ2V0IHRoZSBibG9jayBzaXplIG9mIGdlbmVyYWwgZGVmaW5pdGlv
bnMgKi8KPj4gQEAgLTEwNzAsNyArMTA4OCw3IEBAIHBhcnNlX2RldmljZV9tYXBwaW5nKHN0cnVj
dCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPj4KPj4gICAgICAgICAgICAgICAgY2hpbGRf
ZGV2X3B0ciA9IGRldl9wcml2LT52YnQuY2hpbGRfZGV2ICsgY291bnQ7Cj4+ICAgICAgICAgICAg
ICAgIGNvdW50Kys7Cj4+IC0gICAgICAgICAgICAgbWVtY3B5KGNoaWxkX2Rldl9wdHIsIHBfY2hp
bGQsIHNpemVvZigqcF9jaGlsZCkpOwo+PiArICAgICAgICAgICAgIG1lbWNweShjaGlsZF9kZXZf
cHRyLCBwX2NoaWxkLCBwX2RlZnMtPmNoaWxkX2Rldl9zaXplKTsKPj4gICAgICAgIH0KPj4gICAg
ICAgIHJldHVybjsKPj4gICB9Cj4+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fCj4+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPj4gSW50ZWwtZ2Z4QGxpc3Rz
LmZyZWVkZXNrdG9wLm9yZwo+PiBodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v
bGlzdGluZm8vaW50ZWwtZ2Z4Cj4KPiAtLQo+IERhbmllbCBWZXR0ZXIKPiBTb2Z0d2FyZSBFbmdp
bmVlciwgSW50ZWwgQ29ycG9yYXRpb24KPiBodHRwOi8vYmxvZy5mZndsbC5jaAo+IF9fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxp
bmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwOi8vbGlzdHMu
ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cj4KX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlz
dApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3Rv
cC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK