From: "Siluvery, Arun" <arun.siluvery@linux.intel.com>
To: Mika Kuoppala <mika.kuoppala@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/skl WaDisableSbeCacheDispatchPortSharing
Date: Thu, 6 Aug 2015 16:01:48 +0100 [thread overview]
Message-ID: <55C376DC.7010106@linux.intel.com> (raw)
In-Reply-To: <87614sxypw.fsf@gaia.fi.intel.com>
On 06/08/2015 15:45, Mika Kuoppala wrote:
> "Siluvery, Arun" <arun.siluvery@linux.intel.com> writes:
>
>> On 06/08/2015 14:51, Mika Kuoppala wrote:
>>> Add WaDisableSbeCacheDispatchPortSharing:skl
>>>
>>> Cc: Arun Siluvery <arun.siluvery@linux.intel.com>
>>> Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
>>> ---
>>> drivers/gpu/drm/i915/intel_ringbuffer.c | 7 +++++++
>>> 1 file changed, 7 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c
>>> index 1c14233..1a10358 100644
>>> --- a/drivers/gpu/drm/i915/intel_ringbuffer.c
>>> +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
>>> @@ -1059,6 +1059,13 @@ static int skl_init_workarounds(struct intel_engine_cs *ring)
>>> HDC_FENCE_DEST_SLM_DISABLE |
>>> HDC_BARRIER_PERFORMANCE_DISABLE);
>>>
>>> + /* WaDisableSbeCacheDispatchPortSharing:skl */
>>> + if (INTEL_REVID(dev) <= SKL_REVID_F0) {
>>> + WA_SET_BIT_MASKED(
>>> + GEN7_HALF_SLICE_CHICKEN1,
>>> + GEN7_SBE_SS_CACHE_DISPATCH_PORT_SHARING_DISABLE);
>>> + }
>>> +
>> seems to be applicable for BXT also until B0.
>>
>
> Yes, we have that in bxt_init_workarounds. I pondered
> it is more clean to have rev check for each in their
> respective setup functions.
fine with this.
Reviewed-by: Arun Siluvery <arun.siluvery@linux.intel.com>
regards
Arun
>
> -Mika
>
>
>> regards
>> Arun
>>
>>> return skl_tune_iz_hashing(ring);
>>> }
>>>
>>>
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2015-08-06 15:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-06 13:51 [PATCH] drm/i915/skl WaDisableSbeCacheDispatchPortSharing Mika Kuoppala
2015-08-06 14:31 ` Siluvery, Arun
2015-08-06 14:45 ` Mika Kuoppala
2015-08-06 15:01 ` Siluvery, Arun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C376DC.7010106@linux.intel.com \
--to=arun.siluvery@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kuoppala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox