From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Goel, Akash" Subject: Re: [PATCH] drm/i915: Only move to the CPU write domain if keeping the GTT pages Date: Sun, 9 Aug 2015 16:23:01 +0530 Message-ID: <55C7310D.2000703@intel.com> References: <1438879419-15555-1-git-send-email-chris@chris-wilson.co.uk> <20150807080728.GJ17734@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id F10D26E0D0 for ; Sun, 9 Aug 2015 03:53:04 -0700 (PDT) In-Reply-To: <20150807080728.GJ17734@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter , Chris Wilson Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org CgpPbiA4LzcvMjAxNSAxOjM3IFBNLCBEYW5pZWwgVmV0dGVyIHdyb3RlOgo+IE9uIFRodSwgQXVn IDA2LCAyMDE1IGF0IDA1OjQzOjM5UE0gKzAxMDAsIENocmlzIFdpbHNvbiB3cm90ZToKPj4gV2Ug aGF2ZSBmb3IgYSBsb25nIHRpbWUgYmVlbiB1bHRyYS1wYXJhbm9pZCBhYm91dCB0aGUgc2l0dWF0 aW9uIHdoZXJlYnkKPj4gd2UgaGFuZCBiYWNrIHBhZ2VzIHRvIHRoZSBzeXN0ZW0gdGhhdCBoYXZl IGJlZW4gd3JpdHRlbiB0byBieSB0aGUgR1BVCj4+IGFuZCBwb3RlbnRpYWxseSBzaW11bHRhbmVv dXNseSBieSB0aGUgdXNlciB0aHJvdWdoIGEgQ1BVIG1tYXBwaW5nLiBXZQo+PiBjYW4gcmVsYXgg dGhpcyByZXN0cmljdGlvbiB3aGVuIHdlIGtub3cgdGhhdCB0aGUgY2FjaGUgZG9tYWluIHRyYWNr aW5nCj4+IGlzIHRydWUgYW5kIHRoZXJlIGNhbiBiZSBubyBzdGFsZSBjYWNoZWxpbmUgaW52YWxp ZGF0YXRpb25zLiBUaGlzIGlzCj4+IHRydWUgaWYgdGhlIG9iamVjdCBoYXMgbmV2ZXIgYmVlbiBD UFUgbW1hcGVkIGFzIGFsbCBpbnRlcm5hbCBhY2Nlc3Nlcwo+PiAoaS5lLiBrbWFwL2lvbWFwKSBh cmUgY2FyZWZ1bGx5IGZsdXNoZWQuIEZvciBhIENQVSBtbWFwaW5nLCBvbmUgd291bGQKPj4gZXhw ZWN0IHRoYXQgdGhlIGludmFsaWQgY2FjaGUgbGluZXMgYXJlIHJlc29sdmVkIG9uIFBURS9UTEIg c2hvb3Rkb3duCj4+IGR1cmluZyBtdW5tYXAoKSwgc28gdGhlIG9ubHkgc2l0dWF0aW9uIHdlIG5l ZWQgdG8gYmUgcGFyYW5vaWQgYWJvdXQgaXMKPgo+IFRoYXQgc2VlbXMgYSBwcmV0dHkgc3Ryb25n IGFzc3VtcHRpb24gZ2l2ZW4gdGhhdCB4ODYgY2FjaGUgYXJlIHBoeXNpY2FsbHkKPiBpbmRleGVk IC0gSSdkIG5ldmVyIGV4cGVjdCBmbHVzaGluZyB0byBoYXBwZW4gb24gbXVubWFwLgoKCng4NiBM MSBjYWNoZXMgYXJlIG1vc3QgcHJvYmFibHkgdmlydHVhbGx5IGluZGV4ZWQvcGh5c2ljYWxseSB0 YWdnZWQgYW5kIApnZW5lcmFsbHkgdGhpcyBpcyB0aGUgcHJldmFsZW50ICYgbW9zdCBvcHRpbWFs IENhY2hlIGNvbmZpZ3VyYXRpb24uCgpGb3IgdGhlIHZpcnR1YWxseSBpbmRleGVkL3BoeXNpY2Fs bHkgdGFnZ2VkIGNhY2hlcywgdGhlIGNhY2hlIGZsdXNoIGlzIApub3QgcmVhbGx5IHJlcXVpcmVk IGVpdGhlciBvbiBDb250ZXh0IHN3aXRjaCBvciBvbiBwYWdlIHRhYmxlIHVwZGF0ZSAKKG11bm1h cCwgUFRFL1RMQiBzaG9vdGRvd24pLgoKU28gdGhlcmUgY291bGQgYmUgZmV3IGNhY2hlIGxpbmVz LCBob2xkaW5nIHRoZSBzdGFsZSBkYXRhIChkdWUgdG8gYSAKcHJpb3IgQ1BVIG1tYXBwaW5nKSwg Zm9yIHRoZSBvYmplY3QgYmVpbmcgcHVyZ2VkL3RydW5jYXRlZC4KCj4KPj4gd2hlbiBzdWNoIGEg Q1BVIG1tYXBpbmcgZXhpc3RzIGF0IHRoZSB0aW1lIG9mIHB1dF9wYWdlcy4gR2l2ZW4gdGhhdCB3 ZQo+PiBuZWVkIHRvIHRyZWF0IHB1dF9wYWdlcyBjYXJlZnVsbHkgYXMgd2UgbWF5IHJldHVybiBs aXZlIGRhdGEgdG8gdGhlCj4+IHN5c3RlbSB0aGF0IHdlIHdhbnQgdG8gdXNlIGFnYWluIGluIHRo ZSBmdXR1cmUgKGkuZS4gSTkxNV9NQURWX1dJTExORUVECj4+IHBhZ2VzKSB3ZSBjYW4gc2ltcGx5 IHRyZWF0IGEgbGl2ZSBDUFUgbW1hcGluZyBhcyBhIHNwZWNpYWwgY2FzZSBvZgo+PiBXSUxMTkVF RCAod2hpY2ggaXQgaXMhKS4gQW55IEk5MTVfTUFEVl9ET05UTkVFRCBwYWdlcyBhbmQgdGhlaXIK Pj4gbW1hcGluZ3MgYXJlIHNob3Rkb3duIGltbWVkaWF0ZWx5IGZvbGxvd2luZyBwdXRfcGFnZXMu Cj4+Cj4+IFNpZ25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNv LnVrPgo+PiBDYzogIkdvZWwsIEFrYXNoIiA8YWthc2guZ29lbEBpbnRlbC5jb20+Cj4+IENjOiBW aWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+PiBDYzogRGFu aWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KPj4gQ2M6IEplc3NlIEJhcm5lcyA8 amJhcm5lc0B2aXJ0dW91c2dlZWsub3JnPgo+Cj4gQnV0IGl0J3Mgc3RpbGwgc2FsdmFnZWFibGUg SSB0aGluayBzaW5jZSB3ZSBvbmx5IGNhcmUgYWJvdXQgY29oZXJlbmN5IGZvcgo+IHRoZSBncHUg KHdoZXJlIGRhdGEgbWlnaHQgYmUgc3R1Y2sgaW4gY3B1IGNhY2hlcykuIEZyb20gdGhlIGNwdSdz IHBvdiAoYW5kCj4gaGVuY2UgdGhlIGVudGlyZSBzeXN0ZW0gZXhjZXB0IHRoZSBncHUpIHdlIHNo b3VsZCBuZXZlciBzZWUgaW5jb25zaXN0ZW5jeQo+IHJlYWxseSAtIGFzIHNvb24gYXMgdGhlIGdw dSBkb2VzIGEgd3JpdGUgdG8gYSBjYWNoZWxpbmUgaXQnbGwgd2luLCBhbmQKPiBiZWZvcmUgdGhh dCBub3RoaW5nIGluIHRoZSBzeXN0ZW0gY2FuIGFzc3VtZSBhbnl0aGluZyBhYm91dCB0aGUgY29u dGVudHMKPiBvZiB0aGVzZSBwYWdlcy4KPgo+IFNvIGltbyBhIHNpbXBsZQo+Cj4gCS8qIEZvciBw dXJnZWFibGUgb2JqZWN0cyB3ZSBkb24ndCBjYXJlIGFib3V0IG9iamVjdCBjb250ZW50cy4gKi8K Pgo+IHdvdWxkIGJlIGVub3VnaC4KPgo+IFdlbGwgZXhjZXB0IHRoYXQgdGhlcmUncyBnbCBleHRl bnNpb25zIHdoaWNoIGV4cG9zZSBwdXJnZWFibGUgb2JqZWN0cywgc28KPiBJIGd1ZXNzIHdlIGNh bid0IGFjdHVhbGx5IGRvIHRoaXMuCj4KPiBJIHByZXN1bWUgdGhvdWdoIHlvdSBvbmx5IHdhbnQg dG8gYXZvaWQgY2xmbHVzaCB3aGVuIGFjdHVhbGx5IHB1cmdpbmcgYW4KPiBvYmplY3QsIHNvIG1h eWJlIHdlIGNhbiBrZWVwIHRoaXMgYnkgcHVyZ2luZyB0aGUgc2htZW0gYmFja2luZyBub2RlIGZp cnN0Cj4gYW5kIGNoZWNraW5nIGhlcmUgZm9yIF9fSTkxNV9NQURWX1BVUkdFRCBpbnN0ZWFkPwoK QW4gb2JqZWN0IG1hcmtlZCBhcyBNQURWX0RPTlRfTkVFRCwgaW1wbGllcyB0aGF0IGl0IHdpbGwg YmUgCnB1cmdlZC90cnVuY2F0ZWQgcmlnaHQgYXdheSBhZnRlciB0aGUgY2FsbCB0byBwdXRfcGFn ZXNfZ3R0IGZ1bmN0aW9uLgpTbyBkb2luZyB0aGUgb3RoZXIgd2F5IHJvdW5kIGJ5IHB1cmdpbmcg Zmlyc3QgYW5kIHRoZW4gY2hlY2tpbmcgZm9yIApfX0k5MTVfTUFEVl9QVVJHRUQsIG1pZ2h0IGJl IGVxdWl2YWxlbnQuCgpCZXN0IHJlZ2FyZHMKQWthc2gKCgo+IE9oIGFuZCBzb21lIHBlcmYgZGF0 YSB3b3VsZCBiZSBnb29kIGZvciB0aGlzLgo+IC1EYW5pZWwKPgo+PiAtLS0KPj4gICBkcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jIHwgNDkgKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrLS0tLS0tLS0tLS0KPj4gICAxIGZpbGUgY2hhbmdlZCwgMzYgaW5zZXJ0aW9ucygrKSwgMTMg ZGVsZXRpb25zKC0pCj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2dlbS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+PiBpbmRleCAyZGZlNzA3 ZjExZDMuLjI0ZGVhY2UzNjRhNSAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9nZW0uYwo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4+IEBA IC0yMDQ3LDIyICsyMDQ3LDQ1IEBAIGk5MTVfZ2VtX29iamVjdF9wdXRfcGFnZXNfZ3R0KHN0cnVj dCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmopCj4+Cj4+ICAgCUJVR19PTihvYmotPm1hZHYgPT0g X19JOTE1X01BRFZfUFVSR0VEKTsKPj4KPj4gLQlyZXQgPSBpOTE1X2dlbV9vYmplY3Rfc2V0X3Rv X2NwdV9kb21haW4ob2JqLCB0cnVlKTsKPj4gLQlpZiAocmV0KSB7Cj4+IC0JCS8qIEluIHRoZSBl dmVudCBvZiBhIGRpc2FzdGVyLCBhYmFuZG9uIGFsbCBjYWNoZXMgYW5kCj4+IC0JCSAqIGhvcGUg Zm9yIHRoZSBiZXN0Lgo+PiAtCQkgKi8KPj4gLQkJV0FSTl9PTihyZXQgIT0gLUVJTyk7Cj4+IC0J CWk5MTVfZ2VtX2NsZmx1c2hfb2JqZWN0KG9iaiwgdHJ1ZSk7Cj4+IC0JCW9iai0+YmFzZS5yZWFk X2RvbWFpbnMgPSBvYmotPmJhc2Uud3JpdGVfZG9tYWluID0gSTkxNV9HRU1fRE9NQUlOX0NQVTsK Pj4gLQl9Cj4+IC0KPj4gICAJaTkxNV9nZW1fZ3R0X2ZpbmlzaF9vYmplY3Qob2JqKTsKPj4KPj4g LQlpZiAoaTkxNV9nZW1fb2JqZWN0X25lZWRzX2JpdDE3X3N3aXp6bGUob2JqKSkKPj4gLQkJaTkx NV9nZW1fb2JqZWN0X3NhdmVfYml0XzE3X3N3aXp6bGUob2JqKTsKPj4gKwkvKiBJZiB3ZSBuZWVk IHRvIGFjY2VzcyB0aGUgZGF0YSBpbiB0aGUgZnV0dXJlLCB3ZSBuZWVkIHRvCj4+ICsJICogYmUg c3VyZSB0aGF0IHRoZSBjb250ZW50cyBvZiB0aGUgb2JqZWN0IGlzIGNvaGVyZW50IHdpdGgKPj4g KwkgKiB0aGUgQ1BVIHByaW9yIHRvIHJlbGVhc2luZyB0aGUgcGFnZXMgYmFjayB0byB0aGUgc3lz dGVtLgo+PiArCSAqIE9uY2Ugd2UgdW5waW4gdGhlbSwgdGhlIG1tIGlzIGZyZWUgdG8gbW92ZSB0 aGVtIHRvIGRpZmZlcmVudAo+PiArCSAqIHpvbmVzIG9yIGV2ZW4gc3dhcCB0aGVtIG91dCB0byBk aXNrIC0gYWxsIHdpdGhvdXQgb3VyCj4+ICsJICogaW50ZXJ2ZW50aW9uLiAoVGhvdWdoIHdlIGNv dWxkIHRyYWNrIHN1Y2ggb3BlcmF0aW9ucyB3aXRoIG91cgo+PiArCSAqIG93biBnZW1mcywgaWYg d2UgZXZlciB3cml0ZSBvbmUuKSBBcyBzdWNoIGlmIHdlIHdhbnQgdG8ga2VlcAo+PiArCSAqIHRo ZSBkYXRhLCBzZXQgaXQgdG8gdGhlIENQVSBkb21haW4gbm93IGp1c3QgaW4gY2FzZSBzb21lb25l Cj4+ICsJICogZWxzZSB0b3VjaGVzIGl0Lgo+PiArCSAqCj4+ICsJICogRm9yIGEgbG9uZyB0aW1l IHdlIGhhdmUgYmVlbiBwYXJhbm9pZCBhYm91dCBoYW5kaW5nIGJhY2sKPj4gKwkgKiBwYWdlcyB0 byB0aGUgc3lzdGVtIHdpdGggc3RhbGUgY2FjaGVsaW5lIGludmFsaWRhdGlvbi4gRm9yCj4+ICsJ ICogYWxsIGludGVybmFsIHVzZSAoa21hcC9pb21hcCksIHdlIGtub3cgdGhhdCB0aGUgZG9tYWlu IHRyYWNraW5nIGlzCj4+ICsJICogYWNjdXJhdGUuIEhvd2V2ZXIsIHRoZSB1c2Vyc3BhY2UgQVBJ IGlzIGxheCBhbmQgdGhlIHVzZXIgY2FuIENQVQo+PiArCSAqIG1tYXAgdGhlIG9iamVjdCBhbmQg aW52YWxpZGF0ZSBjYWNoZWxpbmVzIHdpdGhvdXQgb3VyIGFjY3VyYXRlCj4+ICsJICogdHJhY2tp bmcuIFdlIGhhdmUgYmVlbiBwYXJhbm9pZCB0byBiZSBzdXJlIHRoYXQgd2UgYWx3YXlzIGZsdXNo ZWQKPj4gKwkgKiB0aGUgY2FjaGVsaW5lcyB3aGVuIHdlIHN0b3BwZWQgdXNpbmcgdGhlIHBhZ2Vz LiBIb3dldmVyLCBnaXZlbgo+PiArCSAqIHRoYXQgdGhlIENQVSBQVEUvVExCIHNob290ZG93biBt dXN0IGhhdmUgaW52YWxpZGF0ZWQgdGhlIGNhY2hlbGluZXMKPj4gKwkgKiB1cG9uIG11bm1hcCgp LCB3ZSBvbmx5IG5lZWQgdG8gYmUgcGFyYW5vaWQgYWJvdXQgYSBsaXZlIENQVSBtbWFwCj4+ICsJ ICogbm93LiBGb3IgdGhpcywgd2UgbmVlZCBvbmx5IHRyZWF0IGl0IGFzIGxpdmUgZGF0YSBzZWUK Pj4gKwkgKiBkaXNjYXJkX2JhY2tpbmdfc3RvcmFnZSgpLgo+PiArCSAqLwo+PiArCWlmIChvYmot Pm1hZHYgPT0gSTkxNV9NQURWX1dJTExORUVEKSB7Cj4+ICsJCXJldCA9IGk5MTVfZ2VtX29iamVj dF9zZXRfdG9fY3B1X2RvbWFpbihvYmosIHRydWUpOwo+PiArCQlpZiAocmV0KSB7Cj4+ICsJCQkv KiBJbiB0aGUgZXZlbnQgb2YgYSBkaXNhc3RlciwgYWJhbmRvbiBhbGwgY2FjaGVzIGFuZAo+PiAr CQkJICogaG9wZSBmb3IgdGhlIGJlc3QuCj4+ICsJCQkgKi8KPj4gKwkJCVdBUk5fT04ocmV0ICE9 IC1FSU8pOwo+PiArCQkJaTkxNV9nZW1fY2xmbHVzaF9vYmplY3Qob2JqLCB0cnVlKTsKPj4gKwkJ CW9iai0+YmFzZS5yZWFkX2RvbWFpbnMgPSBJOTE1X0dFTV9ET01BSU5fQ1BVOwo+PiArCQkJb2Jq LT5iYXNlLndyaXRlX2RvbWFpbiA9IEk5MTVfR0VNX0RPTUFJTl9DUFU7Cj4+ICsJCX0KPj4KPj4g LQlpZiAob2JqLT5tYWR2ID09IEk5MTVfTUFEVl9ET05UTkVFRCkKPj4gKwkJaWYgKGk5MTVfZ2Vt X29iamVjdF9uZWVkc19iaXQxN19zd2l6emxlKG9iaikpCj4+ICsJCQlpOTE1X2dlbV9vYmplY3Rf c2F2ZV9iaXRfMTdfc3dpenpsZShvYmopOwo+PiArCX0gZWxzZQo+PiAgIAkJb2JqLT5kaXJ0eSA9 IDA7Cj4+Cj4+ICAgCXN0X2Zvcl9lYWNoX3BhZ2UoJml0ZXIsIG9iai0+cGFnZXMpIHsKPj4gLS0K Pj4gMi41LjAKPj4KPgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdm eAo=